Repository navigation
[Impeller] Fix SurfaceContextVK submission tracking and double HostBuffer reset - #196064
Conversation
github-actions
Bot
added
engine
|
I tested these fixes on the leak fix PR #192937 (
|
574500b to
3d53a29
Compare
… double HostBuffer reset in DisplayListToTexture
3d53a29 to
86d1419
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors transient buffer resets in Impeller by replacing manual resets of data and index buffers with a unified ResetTransientsBuffers call in dl_dispatcher.cc and entity_playground.cc, supported by a new unit test. It also exposes the GpuSubmissionTracker in SurfaceContextVK with an accompanying unit test, and re-enables the 'toImage and toImageSync have identical contents' test on Linux and Vulkan platforms. I have no feedback to provide on these changes.
andywolff
added
the
autosubmit
auto-submit
Bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/flutter/196064, because - The status or check suite Presubmit has failed. Please fix the issues identified (or deflake) before re-applying this label. |
andywolff
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
Fixes #196063
Fixes #193029
Pre-requisite for #192937
Fixes two host buffer bugs I ran into while working on #192937.
SurfaceContextVKnow forwards its parent's GPU submission tracker, andDisplayListToTextureandEntityPlaygroundonly reset the transient host buffer once when the data and index buffers are shared.I also removed the skip on the
toImage/toImageSynccomparison test incanvas_test.dart(added while testing #192937). Snapshots don't reset the host buffer onmasteryet, so the test already passes on Linux and Vulkan, and #192937 will exercise it with resets enabled.Pre-launch Checklist
///).