Skip to content

[web] Respect Uint8List view bounds when detecting animated WebP/GIF - #196010

Merged
auto-submit[bot] merged 5 commits into
flutter:masterfrom
harryterkelsen:web-respect-uint8list-offsetinbytes-lengthinbytes
Nov 5, 2026
Merged

auto-submit[bot] merged 5 commits into
flutter:masterfrom
harryterkelsen:web-respect-uint8list-offsetinbytes-lengthinbytes

Conversation

@harryterkelsen

Copy link
Copy Markdown
Contributor

detectImageType in the web engine sniffs WebP and GIF headers to decide whether an image is animated. The WebP and GIF header readers were given data.buffer.asByteData(), a view of the whole backing buffer starting at byte 0, rather than a view of the Uint8List itself. When the image bytes are a view into a larger buffer (for example Uint8List.sublistView, an image embedded in a container format, or a slice of a pooled network buffer), the readers looked at whatever came before the image in the buffer instead of the image's own header. Animated WebP and GIF images in such views were misclassified as static and sent down the single-frame decode path, so they did not animate. A static image stored right after an animated image in the same buffer could also be misreported as animated.

This change builds both readers from ByteData.sublistView(data), which covers exactly the bytes of data (respecting offsetInBytes and lengthInBytes) without copying. The signature check and AVIF detection already index data directly and were unaffected.

Related: #151911 (animated WebP/GIF detection in detectImageType). No separate issue was filed for this bug.

Behavioral Changes

  • Before: detectImageType(view) on an animated WebP/GIF stored at a non-zero offsetInBytes in its buffer returned ImageType.webp / ImageType.gif (static), so the image decoded as a single frame.
    After: it returns ImageType.animatedWebp / ImageType.animatedGif, the same result as for a standalone copy of the same bytes.
  • Before: a static WebP/GIF stored after an animated image in the same buffer could be classified as animated (the readers parsed the earlier image).
    After: it is classified as ImageType.webp / ImageType.gif.
  • Before: on a truncated WebP/GIF view, the readers could read past the end of the view into unrelated bytes of the backing buffer.
    After: reads are bounded by the view, so a truncated view behaves like a truncated standalone buffer (which already throws a RangeError today; hardening that is left to a separate change).

Where to focus

  • Primary file: engine/src/flutter/lib/web_ui/lib/src/engine/image_format_detector.dart, the two reader call sites in detectImageType. The readers themselves are unchanged; they start at position 0, so handing them a view based at offsetInBytes is the whole fix.
  • Why ByteData.sublistView instead of copying: it's a zero-copy view on both dart2js (DataView(buffer, offset, length)) and dart2wasm, so detection cost is unchanged. The readers only use getUint8, so unaligned offsets are fine.
  • Tests: engine/src/flutter/lib/web_ui/test/engine/image_format_detector_test.dart. A table of fixtures (animated/static WebP, animated/static GIF, AVIF) runs against several buffer layouts: leading padding only, trailing padding only, both, and an unaligned offset. The padding bytes are 0xFF, so they can't accidentally match a header. The "static image stored right after an animated image" cases cover the opposite failure, where the old code returned animated for a static image.
  • Out of scope: making the readers tolerate truncated or malformed streams. That is a pre-existing issue for all inputs, not just views.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@github-actions github-actions Bot added engine flutter/engine related. See also e: labels. platform-web Web applications specifically team-web Owned by Web platform team labels Nov 4, 2026
@harryterkelsen harryterkelsen added the CICD Run CI/CD label Nov 5, 2026
@harryterkelsen
harryterkelsen marked this pull request as ready for review November 5, 2026 00:02

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies image_format_detector.dart to use ByteData.sublistView instead of asByteData on the underlying buffer, ensuring correct image type detection when handling Uint8List views. It also introduces unit tests to validate detection behavior on padded subviews and subviews within larger buffers. There are no review comments, so no additional feedback is provided.

@harryterkelsen harryterkelsen added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 5, 2026
@auto-submit
auto-submit Bot added this pull request to the merge queue Nov 5, 2026
Merged via the queue into flutter:master with commit a5c26aa Nov 5, 2026
23 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 5, 2026
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Nov 6, 2026
Roll Flutter from 3623d2d34543 to 09175cdeac89 (61 revisions)

flutter/flutter@3623d2d...09175cd

2026-11-06 [email protected] Roll Skia from ae35b7b2221f to 793b8ac73d4b (3 revisions) (flutter/flutter#196091)
2026-11-06 [email protected] [web] Rasterize scenes at the size passed to `FlutterView.render` (flutter/flutter#196052)
2026-11-06 [email protected] Roll Skia from 4aa043a81e0c to ae35b7b2221f (1 revision) (flutter/flutter#196086)
2026-11-06 [email protected] Roll Fuchsia Linux SDK from Fqe3UlLwAohsPbsCS... to KIc0XZbhLmvDpTluZ... (flutter/flutter#196085)
2026-11-06 [email protected] Allow a zero scale change in InteractiveViewer (flutter/flutter#194949)
2026-11-06 [email protected] Roll Skia from dd5c2553a856 to 4aa043a81e0c (2 revisions) (flutter/flutter#196079)
2026-11-06 [email protected] [web] Keep ImageFilter.blur bounds in equality and description (flutter/flutter#196013)
2026-11-06 [email protected] iOS: Remove unused PlatformViewIOS setup from FlutterPlatformViewsTest (flutter/flutter#196033)
2026-11-06 [email protected] Serialize LoggerTests that mutate the shared Logger (flutter/flutter#196028)
2026-11-06 [email protected] Use reverseDuration for the AnimatedCrossFade size animation (flutter/flutter#194860)
2026-11-05 [email protected] Roll Skia from a5aacd103e68 to dd5c2553a856 (8 revisions) (flutter/flutter#196073)
2026-11-05 [email protected] Fix ListWheelScrollView null check error when it reads itemIndex before content dimensions are set (flutter/flutter#194859)
2026-11-05 [email protected] Allow zero cross axis extent in SliverGridDelegateWithMaxCrossAxisExtent (flutter/flutter#194858)
2026-11-05 [email protected] Revert: Allow color delta tolerance in in-memory fuzzy image comparator (flutter/flutter#196067)
2026-11-05 [email protected] Revert: Mitigate snapshot race in 3D transform test by reducing loop density (flutter/flutter#196066)
2026-11-05 [email protected] Delegate createStream in ResizeImage and ScrollAwareImageProvider (flutter/flutter#194756)
2026-11-05 [email protected] [iOS] Introduce FlutterShell and move thread host and profiler (flutter/flutter#195388)
2026-11-05 [email protected] [web] Support FragmentShader.getImageSampler on CanvasKit and Skwasm (flutter/flutter#195854)
2026-11-05 [email protected] Deprecates setFloat API (flutter/flutter#195505)
2026-11-05 [email protected] [flutter_tools] Remove public GlobalToolContext and globals from runner (flutter/flutter#195561)
2026-11-05 [email protected] Defer TLHC PlatformViewWrapper frame post and avoid initial 1x1 buffer resize (flutter/flutter#195861)
2026-11-05 [email protected] Roll Skia from b5abed66da86 to a5aacd103e68 (17 revisions) (flutter/flutter#196054)
2026-11-05 [email protected] Made `FlutterWindowControllerSizeTest.SizedToContentNotResizable` more robust (flutter/flutter#195845)
2026-11-05 [email protected] Update docs for contributor ladder (flutter/flutter#196011)
2026-11-05 [email protected] [Impeller] Use the transfer stage for the Vulkan readback barrier (flutter/flutter#194991)
2026-11-05 [email protected] Remove Mac mac_unopt builder (flutter/flutter#196027)
2026-11-05 [email protected] Updated Instructions for Determining Gradle Version for `gradle_dists` in CIPD (flutter/flutter#193310)
2026-11-05 [email protected] Move ios_app_with_extensions_test into the tool integration shard (flutter/flutter#195609)
2026-11-05 [email protected] [web] Respect Uint8List view bounds when detecting animated WebP/GIF (flutter/flutter#196010)
2026-11-05 [email protected] Add platform_views_layout to build_tests so iOS/Android build breaks are caught in presubmit (flutter/flutter#192985)
2026-11-05 [email protected] [flutter_tools] Detect macOS TCC permission crashes and provide diagnostic guidance (flutter/flutter#192432)
2026-11-05 [email protected] Roll Packages from 670b30e to 0478162 (15 revisions) (flutter/flutter#196047)
2026-11-05 [email protected] [web] Support Skwasm rendering without bitmap capture (flutter/flutter#195103)
2026-11-05 [email protected] [flutter_tools] Reland fix for local CanvasKit asset paths on Windows (flutter/flutter#195770)
2026-11-05 [email protected] Roll Skia from f96be51af95d to b5abed66da86 (14 revisions) (flutter/flutter#196017)
2026-11-05 [email protected] Split chrome web engine test drone (flutter/flutter#195873)
2026-11-05 [email protected] Roll Dart SDK from c9153304136a to 6623b84628f3 (1 revision) (flutter/flutter#196026)
2026-11-05 [email protected] Roll ICU from 4fe960221710 to a0ea93436c52 (6 revisions) (flutter/flutter#196025)
2026-11-05 [email protected] Add more guidance in README and AGENTS for contributing to flutter_tools (flutter/flutter#195998)
2026-11-05 [email protected] Roll Fuchsia Linux SDK from p0HDXLISPIElJfSz7... to Fqe3UlLwAohsPbsCS... (flutter/flutter#196019)
2026-11-05 [email protected] Roll Dart SDK from e362a23e9738 to c9153304136a (18 revisions) (flutter/flutter#196014)
2026-11-05 [email protected] [Impeller] Fix dilation input bounds when clipping saveLayers (flutter/flutter#195652)
2026-11-05 [email protected] Add `variantOf` to the M3E migration checklist (flutter/flutter#195099)
2026-11-05 [email protected] [flutter_tools] Eliminate globals from remaining subsystem files (flutter/flutter#195555)
2026-11-05 [email protected] Fix gap flipping when dragging variable height reorderable items (flutter/flutter#194478)
2026-11-05 [email protected] [A11y] Send un-merged SemanticsNodes in the same update that first references them (flutter/flutter#195829)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD engine flutter/engine related. See also e: labels. platform-web Web applications specifically team-web Owned by Web platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants