Skip to content

Take impeller_primitives_perf_suite_ios__timeline_summary out of bringup - #196007

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
jmagman:impeller_primitives_perf_suite_ios__timeline_summary-bringup
Nov 5, 2026
Merged

auto-submit[bot] merged 1 commit into
flutter:masterfrom
jmagman:impeller_primitives_perf_suite_ios__timeline_summary-bringup

Conversation

@jmagman

@jmagman jmagman commented Nov 4, 2026

Copy link
Copy Markdown
Member

Passing in postsubmit #195661, take out of bringup
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20impeller_primitives_perf_suite_ios__timeline_summary/50/overview

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Nov 4, 2026
@jmagman
jmagman requested a review from gaaclarke November 4, 2026 23:13

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the bringup: true property from the Mac_ios impeller_primitives_perf_suite_ios__timeline_summary target in .ci.yaml. There are no review comments, and I have no feedback to provide.

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 4, 2026
@auto-submit
auto-submit Bot added this pull request to the merge queue Nov 5, 2026
Merged via the queue into flutter:master with commit 45cc392 Nov 5, 2026
27 of 28 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 5, 2026
@jmagman
jmagman deleted the impeller_primitives_perf_suite_ios__timeline_summary-bringup branch November 11, 2026 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants