Revert: Goma is dead, long live RBE! by flutteractionsbot · Pull Request #196001 · flutter/flutter

flutteractionsbot · 2026-11-04T21:24:09Z

Initiated by: @jtmcdole

Reason for reverting: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8666031972009164465/+/u/gn_--ios_--simulator_--simulator-cpu_arm64_--runtime-mode_debug_--unoptimized_--no-stripped_--no-lto_--xcode-symlinks_--rbe_--no-goma_--rbe-server-address_unix:___Volumes_Work_s_w_ir_x_w_rc_rbe62p4t_vg_reproxy.sock/stdout

Original PR Author: @rmacnak-google

Reviewed By: @ievdokdm

The original PR description is provided below:

This reverts commit b9944cf.

flutter-dashboard · 2026-11-04T21:24:23Z

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If both you and the PR author believe this PR qualifies for a test exemption, escalate to the tech lead for the changed area to review and apply the test-exempt label. All reviewers should feel empowered to ask for tests before escalating.

gemini-code-assist

Code Review

This pull request adds --goma and --no-goma command-line flags to the GN build tool and updates various CI builder configuration files to include the --no-goma argument. Feedback on these changes includes addressing a bug in the GN argument parser where the default value for the goma destination unintentionally resolves to True instead of None because --no-goma lacks an explicit default. Additionally, minor formatting cleanup is recommended to remove unnecessary blank lines in mac_host_engine.json.

gemini-code-assist · 2026-11-04T21:25:10Z

+  parser.add_argument('--goma', default=None, action='store_true')
+  parser.add_argument('--no-goma', dest='goma', action='store_false')


In argparse, when multiple arguments share the same destination (dest='goma'), the default value of the last defined argument will overwrite any previously specified default. Since --no-goma is defined second with action='store_false' and no explicit default, its default value of True will overwrite the default=None specified on --goma. This means args.goma will default to True when neither flag is passed, which may unintentionally enable Goma by default and break builds for environments without Goma.

To preserve the intended None default (allowing for auto-detection or conditional logic), we should explicitly set default=None on the --no-goma argument as well.

Suggested change

parser.add_argument('--goma', default=None, action='store_true')

parser.add_argument('--no-goma', dest='goma', action='store_false')

parser.add_argument('--goma', default=None, action='store_true')

parser.add_argument('--no-goma', dest='goma', default=None, action='store_false')

gemini-code-assist · 2026-11-04T21:25:10Z

                "--xcode-symlinks"
+
            ],


Remove the unnecessary blank line inside the JSON array to maintain clean and consistent formatting.

"--xcode-symlinks" ],

gemini-code-assist · 2026-11-04T21:25:10Z

                "--xcode-symlinks"
+
            ],


Remove the unnecessary blank line inside the JSON array to maintain clean and consistent formatting.

"--xcode-symlinks" ],

flutter-dashboard · 2026-11-04T21:27:11Z

Detected the emergency label.

If you add the autosubmit label, the bot will wait until all presubmits pass but ignore the tree status, allowing fixes for tree breakages while still validating that they don't break any existing presubmits.

The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue".

jtmcdole · 2026-11-04T23:22:55Z

re-running Mac mac_unopt - not sure why this is failing:

Running command "/Volumes/Work/s/w/ir/cache/builder/engine/src/out/ci/host_debug_unopt_arm64/flutter_tester --force-multithreading --disable-vm-service --no-enable-impeller --use-test-fonts --icu-data-file-path=/Volumes/Work/s/w/ir/cache/builder/engine/src/out/ci/host_debug_unopt_arm64/icudtl.dat --flutter-assets-dir=/Volumes/Work/s/w/ir/cache/builder/engine/src/out/ci/host_debug_unopt_arm64/gen/flutter/lib/ui/assets --disable-asset-fonts /Volumes/Work/s/w/ir/cache/builder/engine/src/out/ci/host_debug_unopt_arm64/gen/fail_test.dart.dill" in "/Volumes/Work/s/w/ir/cache/builder/engine/src"
+0 -1: test smoke test -- this test SHOULD FAIL [E]

  Expected: true
    Actual: <false>


  package:matcher/src/expect/expect.dart 195:31             fail
  package:matcher/src/expect/expect.dart 189:3              _expect
  package:matcher/src/expect/expect.dart 68:11              expect.<fn>
  package:matcher/src/async_matcher_restriction.dart 34:65  allowAsyncMatchers
  package:matcher/src/expect/expect.dart 67:3               expect
  flutter/testing/smoke_test_failure/fail_test.dart 9:5     main.<fn>
  package:test_api/src/backend/declarer.dart 253:25         Declarer.test.<fn>.<fn>
  ===== asynchronous gap ===========================
  package:test_api/src/backend/declarer.dart 250:11         Declarer.test.<fn>
  ===== asynchronous gap ===========================
  package:test_api/src/backend/invoker.dart 318:9           Invoker._waitForOutstandingCallbacks.<fn>


+0 -1: Some tests failed.

Revert "Goma is dead, long live RBE! (flutter#195798)"

54824c7

This reverts commit b9944cf.

flutteractionsbot mentioned this pull request Nov 4, 2026

Goma is dead, long live RBE! #195798

Merged

flutter-dashboard Bot added CICD Run CI/CD missing-tests labels Nov 4, 2026

github-actions Bot added the engine flutter/engine related. See also e: labels. label Nov 4, 2026

gemini-code-assist Bot reviewed Nov 4, 2026

View reviewed changes

jtmcdole added the emergency Jump the queue; land PR in front of all others; only use for emergencies label Nov 4, 2026

Renzo-Olivares approved these changes Nov 4, 2026

View reviewed changes

Renzo-Olivares added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 4, 2026

auto-submit Bot added this pull request to the merge queue Nov 4, 2026

Merged via the queue into flutter:master with commit a4a2939 Nov 5, 2026
37 of 38 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 5, 2026

flutteractionsbot deleted the revert-195798-1793827443 branch November 5, 2026 00:30

Navigation Menu

Repository navigation

Revert: Goma is dead, long live RBE! - #196001

Revert: Goma is dead, long live RBE!#196001
auto-submit[bot] merged 1 commit into
flutter:masterfrom
flutteractionsbot:revert-195798-1793827443

flutteractionsbot commented Nov 4, 2026

Uh oh!

flutter-dashboard Bot commented Nov 4, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Nov 4, 2026

Uh oh!

gemini-code-assist Bot Nov 4, 2026

Uh oh!

gemini-code-assist Bot Nov 4, 2026

Uh oh!

flutter-dashboard Bot commented Nov 4, 2026

Uh oh!

jtmcdole commented Nov 4, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		parser.add_argument('--goma', default=None, action='store_true')
		parser.add_argument('--no-goma', dest='goma', action='store_false')

Conversation

flutteractionsbot commented Nov 4, 2026

Uh oh!

flutter-dashboard Bot commented Nov 4, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Nov 4, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Nov 4, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Nov 4, 2026

Choose a reason for hiding this comment

Uh oh!

flutter-dashboard Bot commented Nov 4, 2026

Uh oh!

jtmcdole commented Nov 4, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants