Repository navigation
Reference dart-lang/sdk#61464 on deprecated_web_configuration ignores - #195931
Merged
auto-submit[bot] merged 1 commit intoNov 5, 2026
Merged
Conversation
Annotate the `// ignore: deprecated_web_configuration` conditional imports added in flutter#184130 and the corresponding `sdk_rewriter.dart` entry with dart-lang/sdk#61464 so they can be migrated to `if (dart.tool.dart2wasm)` once that SDK feature lands. Also adds a test case in `sdk_rewriter_test.dart` verifying that `sdk_rewriter.dart` strips `// ignore: deprecated_web_configuration` comment lines preceding conditional imports in part files.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds references to Dart SDK issue #61464 across several files. Specifically, it updates the 'deprecated_web_configuration' ignore comments in renderer.dart, utils.dart, and sdk_rewriter_test.dart to include the issue link, and adds a TODO comment in sdk_rewriter.dart regarding the migration to dart.tool.dart2wasm. There are no review comments, and I have no feedback to provide.
github-actions
Bot
added
engine
srujzs
approved these changes
Nov 4, 2026
flutter-dashboard
Bot
removed
the
autosubmit
This was referenced Nov 5, 2026
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Annotate the
// ignore: deprecated_web_configurationconditional imports added in #184130 and the correspondingsdk_rewriter.dartrule with dart-lang/sdk#61464 so they can be migrated toif (dart.tool.dart2wasm)once that SDK feature lands.Also adds a test case in
sdk_rewriter_test.dartverifying thatsdk_rewriter.dartstrips// ignore: deprecated_web_configurationcomment lines preceding conditional imports in part files.Related issues:
Pre-launch Checklist
///).