Repository navigation
Goma is dead, long live RBE! - #195798
Merged
Merged
Goma is dead, long live RBE!#195798
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes Goma-related arguments from various CI builder configuration files and the GN build helper script. Several JSON files, specifically linux_unopt.json and local_engine.json, contain syntax errors due to missing commas where the Goma arguments were removed, which will cause JSON parsing failures.
Contributor
Author
Member
|
reason for revert: tree failing; |
Contributor
|
Successfully created revert PR: #196001 |
flutteractionsbot
removed
the
revert
harryterkelsen
pushed a commit
to harryterkelsen/flutter
that referenced
this pull request
Nov 5, 2026
Reverts: [Goma is dead, long live RBE!](flutter#195798) Initiated by: @jtmcdole Reason for reverting: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8666031972009164465/+/u/gn_--ios_--simulator_--simulator-cpu_arm64_--runtime-mode_debug_--unoptimized_--no-stripped_--no-lto_--xcode-symlinks_--rbe_--no-goma_--rbe-server-address_unix:___Volumes_Work_s_w_ir_x_w_rc_rbe62p4t_vg_reproxy.sock/stdout Original PR Author: @rmacnak-google Reviewed By: @ievdokdm The original PR description is provided below:
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.