Repository navigation
Update skills_lint to 0.5.3 - #195796
Merged
auto-submit[bot] merged 5 commits intoNov 3, 2026
Merged
Update skills_lint to 0.5.3#195796
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the 'skills_lint' dependency to version '0.5.3' in 'dev/tools/pubspec.yaml' and updates the lockfile accordingly, which also introduces the transitive dependency 'tar'. Additionally, it configures the 'disallowed-field' rule as an error and adjusts the directory path in 'skills_lint.yaml'. Finally, it adds an assertion in 'validate_skills_test.dart' to verify that the configuration loads without parsing errors. There are no review comments, and I have no feedback to provide.
reidbaker
previously approved these changes
Nov 2, 2026
reidbaker
approved these changes
Nov 2, 2026
Piinks
added
the
c: agentic-engineering
jtmcdole
approved these changes
Nov 3, 2026
jtmcdole
left a comment
jtmcdole
left a comment
Member
There was a problem hiding this comment.
The CodeFu Platinum LGTM Card: For everywhere you want your PR to land.
- 1.337% LGTM-back savings on every landing
- Zero annual fees - its open source software
- Some repository restrictions apply. Not valid on flaky or missing tests, unapproved infra changes
reidbaker
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Nov 4, 2026
flutter/flutter@9347202...3623d2d 2026-11-04 [email protected] Roll Skia from 49ec2655bf51 to aaa39bfcd393 (5 revisions) (flutter/flutter#195956) 2026-11-04 [email protected] Roll pub packages (flutter/flutter#195950) 2026-11-04 [email protected] Roll pub packages (flutter/flutter#195948) 2026-11-04 [email protected] local_engine_builds_common out of bringup (flutter/flutter#195862) 2026-11-04 [email protected] [web][a11y] Initialize slider semantics values when enabling (flutter/flutter#195564) 2026-11-04 [email protected] Drop Android SDK, JDK, and Gradle dependencies from framework_tests_misc (flutter/flutter#195869) 2026-11-04 [email protected] Roll Fuchsia Test Scripts from B6zarykZp6PKWRueg... to Jo-ZgQSNDuPsjlZ4s... (flutter/flutter#195937) 2026-11-04 [email protected] Balance tool_tests_commands and web_tool_tests subshards by duration (flutter/flutter#195863) 2026-11-04 [email protected] Roll Fuchsia Linux SDK from T_-6-6X1lDMghhAvX... to p0HDXLISPIElJfSz7... (flutter/flutter#195939) 2026-11-03 [email protected] Roll Skia from 3eeafac94f07 to 49ec2655bf51 (8 revisions) (flutter/flutter#195933) 2026-11-03 [email protected] Roll pub packages (flutter/flutter#195932) 2026-11-03 [email protected] [flutter_tools] Lazily initialize AppleContext dependencies via builder closures (flutter/flutter#191992) 2026-11-03 [email protected] [Android] Upgrade linux_android_emu_vulkan_stable avd_cipd_version to 36.1.9 (build_id:8670032186093418337) (flutter/flutter#195856) 2026-11-03 [email protected] [vulkan]: adds "color attachment read" dst dependency to subpass (flutter/flutter#195714) 2026-11-03 [email protected] [flutter_tools] Stream web dev server proxy responses instead of buffering them (flutter/flutter#194934) 2026-11-03 [email protected] Roll Skia from d80db8f8f856 to 3eeafac94f07 (6 revisions) (flutter/flutter#195926) 2026-11-03 [email protected] [flutter_tools] Add flutter assemble support for tool extension assemble targets (flutter/flutter#194563) 2026-11-03 [email protected] Manual roll Dart SDK from fe609902984b to e362a23e9738 (2 revisions) (flutter/flutter#195914) 2026-11-03 [email protected] feat(flutter_test): add startHover and startHoverAt helper to WidgetTester (flutter/flutter#190630) 2026-11-03 [email protected] [flutter_tools] Remove trailing dots from bug report URLs (flutter/flutter#194132) 2026-11-03 [email protected] Update skills_lint to 0.5.3 (flutter/flutter#195796) 2026-11-03 [email protected] Roll Skia from 58295d932350 to d80db8f8f856 (5 revisions) (flutter/flutter#195900) 2026-11-03 [email protected] [flutter_tools] Make DeviceLogReader.dispose asynchronous (flutter/flutter#195389) 2026-11-03 [email protected] Roll Packages from 3f34a6f to 1df8447 (10 revisions) (flutter/flutter#195895) 2026-11-03 [email protected] Roll Skia from c733ad3e37cb to 58295d932350 (1 revision) (flutter/flutter#195894) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to skills_lint 0.5.3.
Along the way we found that
dev/tools/skills_lint.yamlpointed at the wrong directory when the CLI runs directly.@reidbaker
Details
Updates the
skills_lintdependency indev/toolsfrom^0.5.1to^0.5.3.Changes:
dev/tools/pubspec.yaml:skills_lint: ^0.5.3.dev/tools/skills_lint.yaml: changes thedirectoriespath from.agents/skillsto../../.agents/skills. Since 0.5.2, skills_lint resolvesdirectoriespaths relative to the config file, not the working directory. With the old path, runningdart run skills_lintfromdev/toolsfails with "Specified root directory does not exist: .../dev/tools/.agents/skills". With the new path, it checks the 12 skills in the repo-root.agents/skillsand exits 0. The test is not affected either way, because it passesskillDirPathsexplicitly and does not readdirectories, so the test does not guard this path.dev/tools/test/validate_skills_test.dart: addsexpect(config.parsingErrors, isEmpty). The 0.5.3 CHANGELOG notes thatvalidateSkillsreturnstrueeven whenconfig.parsingErrorsis not empty, so without this check a typo inskills_lint.yaml(for example, an unknown rule name, which 0.5.3 reports as a config error) would still pass the test.pubspec.lockand thePUBSPEC CHECKSUMindev/tools/pubspec.yaml: regenerated withflutter update-packages --update-hashes. The only lockfile changes areskills_lint0.5.1 → 0.5.3 and the new transitive dependencytar2.0.3, which 0.5.3 adds.Local checks against skills_lint 0.5.3 from pub.dev:
flutter test dev/tools/test/validate_skills_test.dartpasses,dart analyze --fatal-infos dev/toolsreports no issues,dart run skills_lintindev/toolsexits 0, anddart formatmakes no changes.No issue tracks this routine dependency update, so this PR does not link one.
I prepared this change with help from an AI agent and reviewed it.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.