Repository navigation
Roll Fuchsia Linux SDK from QdgqP02_cYpRQQQNN... to Iu2joHYXNoLxJhszC... - #195418
Closed
engine-flutter-autoroll wants to merge 1 commit into
Conversation
If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added
the
autosubmit
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
fluttergithubbot
approved these changes
Oct 27, 2026
auto-submit
Bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/flutter/195418, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
This was referenced Oct 27, 2026
engine-flutter-autoroll
added
the
autosubmit
auto-submit
Bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/flutter/195418, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added
the
autosubmit
auto-submit
Bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/flutter/195418, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Contributor
Author
|
Commit queue failed; closing this roll. |
dayanruben
pushed a commit
to dayanruben/flutter
that referenced
this pull request
Oct 28, 2026
…tter#195420) The Fuchsia Linux SDK roll into Flutter has not landed since 2026-09-28. Every roll attempt (for example flutter#195418) fails `Linux linux_fuchsia_tests` because `text-input-test`, `touch-input-test`, and `mouse-input-test` no longer compile: ``` portable_ui_test.h:8:10: fatal error: 'fuchsia/sysmem2/cpp/fidl.h' file not found portable_ui_test.h:10:10: fatal error: 'fuchsia/ui/composition/cpp/fidl.h' file not found ``` `portable_ui_test.h` includes the `fuchsia.sysmem2` and `fuchsia.ui.composition` bindings, but only `portable_ui_test.cc` uses them, and both are private `deps` of `:portable_ui_test`. The tests were only finding these headers transitively through `fuchsia.accessibility.semantics` -> `fuchsia.ui.gfx`, and https://fuchsia-review.googlesource.com/c/fuchsia/+/1617688 removed those `fuchsia.ui.gfx` dependencies. This PR: - Drops the `fuchsia.sysmem2` and `fuchsia.ui.composition` includes from `portable_ui_test.h`. - Includes `fuchsia.ui.composition` in `portable_ui_test.cc`, which uses it (`fuchsia.sysmem2` is already included there). - Includes `fuchsia.ui.observation.geometry` directly in `portable_ui_test.h`, which uses its types but was previously getting the header through `fuchsia.ui.test.scene`. This builds against both the currently pinned SDK and newer SDKs. It is a follow-up to flutter#193244, which removed the unused `fuchsia/sysmem/cpp/fidl.h` includes for the same Fuchsia change. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant in-code documentation (doc comments with `///`). - [x] If this PR introduces a new feature or capability, I created and linked a website documentation issue or PR in [flutter/website] (or verified none is needed). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/CONTRIBUTING.ai.md [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [flutter/website]: https://github.com/flutter/website [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
suryaKommana2662
pushed a commit
to suryaKommana2662/flutter
that referenced
this pull request
Oct 29, 2026
…tter#195420) The Fuchsia Linux SDK roll into Flutter has not landed since 2026-09-28. Every roll attempt (for example flutter#195418) fails `Linux linux_fuchsia_tests` because `text-input-test`, `touch-input-test`, and `mouse-input-test` no longer compile: ``` portable_ui_test.h:8:10: fatal error: 'fuchsia/sysmem2/cpp/fidl.h' file not found portable_ui_test.h:10:10: fatal error: 'fuchsia/ui/composition/cpp/fidl.h' file not found ``` `portable_ui_test.h` includes the `fuchsia.sysmem2` and `fuchsia.ui.composition` bindings, but only `portable_ui_test.cc` uses them, and both are private `deps` of `:portable_ui_test`. The tests were only finding these headers transitively through `fuchsia.accessibility.semantics` -> `fuchsia.ui.gfx`, and https://fuchsia-review.googlesource.com/c/fuchsia/+/1617688 removed those `fuchsia.ui.gfx` dependencies. This PR: - Drops the `fuchsia.sysmem2` and `fuchsia.ui.composition` includes from `portable_ui_test.h`. - Includes `fuchsia.ui.composition` in `portable_ui_test.cc`, which uses it (`fuchsia.sysmem2` is already included there). - Includes `fuchsia.ui.observation.geometry` directly in `portable_ui_test.h`, which uses its types but was previously getting the header through `fuchsia.ui.test.scene`. This builds against both the currently pinned SDK and newer SDKs. It is a follow-up to flutter#193244, which removed the unused `fuchsia/sysmem/cpp/fidl.h` includes for the same Fuchsia change. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant in-code documentation (doc comments with `///`). - [x] If this PR introduces a new feature or capability, I created and linked a website documentation issue or PR in [flutter/website] (or verified none is needed). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/CONTRIBUTING.ai.md [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [flutter/website]: https://github.com/flutter/website [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
engine-flutter-autoroll
deleted the
fuchsia-linux-sdk-flutter-93f295f7-dd69-45e2-b7aa-756b03a8d76f-1793109106
branch
November 3, 2026 14:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If this roll has caused a breakage, revert this CL and set the roller
to dry run mode using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md