Repository navigation
Include misspelledSelectionColor in SpellCheckConfiguration equality - #195404
Open
ChandraChaan wants to merge 4 commits into
Open
ChandraChaan wants to merge 4 commits into
ChandraChaan wants to merge 4 commits into
Conversation
github-actions
Bot
added
the
framework
ChandraChaan
marked this pull request as ready for review
October 27, 2026 14:40
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds misspelledSelectionColor to the equality operator and hashCode of SpellCheckConfiguration. It also introduces unit and widget tests to verify the equality logic and ensure EditableText updates when misspelledSelectionColor changes. There are no review comments, and I have no feedback to provide.
Author
Author
|
Thank you for the review, @chunhtai! I have merged |
Author
|
Thanks for the review, @chunhtai! Could you or another maintainer add the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SpellCheckConfiguration.operator ==andhashCodeleave outmisspelledSelectionColor, so configurations that differ only in that color compare equal. BecauseEditableTextState.didUpdateWidgetre-infers its spell check configuration only when the old and new configurations are unequal, changing justmisspelledSelectionColorhas no effect until something else changes.This adds the field to both, and adds tests for the equality and for
EditableTextpicking up the new color. Both tests fail without the fix.Fixes #195403
Pre-launch Checklist
///).