Fix TableBorder.lerp and scale dropping borderRadius - #195398

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #195398 at sha 97b0523

The one golden change, cupertino.cupertinoActionSheet.pressed on macOS Impeller, looks unrelated: 60 pixels (0.06%) differ, CupertinoActionSheet doesn't use TableBorder, and this PR doesn't touch Cupertino. Could a reviewer triage it on Gold when convenient? Thanks!

Thanks for adding the label, @justinmc. ci.yaml validation failed because the branch was behind master (it reported Mac_ios rrect_blur_perf_ios__timeline_summary as a new builder, and this PR does not touch .ci.yaml), so I have merged master in as the check suggests.

The merge removed the CICD label again. Could you re-add it when you get a chance so the presubmits can run?

Thanks for adding the label, @navaronbracke. The presubmits ran: 75 of 76 builds passed, and the one failure is Linux firebase_release_smoke_test, which ended as an infra failure ("The build was cancelled" in the gcloud firebase step) after about an hour, not as a test failure. This PR only touches table_border.dart and its test.

Could someone with access re-run that job? I do not think I can from my side.

Friendly follow-up, @navaronbracke and @justinmc: this is approved and everything except Linux firebase_release_smoke_test passed. That job ended as an infra failure (the gcloud firebase step was cancelled), and it has passed on almost every other recent presubmit run, so a re-run should go through.

If re-running that one job is awkward, I am happy to merge master in instead so the whole set runs fresh. That would need the CICD label re-added afterwards. Whichever is easier for you. Thanks!

I've rebased, since I think that smoke test might be behind because of the outdated HEAD on this PR?

Let's keep an eye on it

Thank you for rebasing and re-adding the label, @navaronbracke! That did it: all 77 presubmit builds passed this time, including Linux firebase_release_smoke_test, and flutter-gold is green. Only Google testing is still pending.

Once that passes, would you be able to add the autosubmit label so it can land?