Skip to content

[CP-beta][macOS] Fix FlutterTextInputPluginTest crash - #195340

Merged
auto-submit[bot] merged 1 commit into
flutter:flutter-3.50-candidate.0from
flutteractionsbot:cp-beta-f4e2bc99cd0a625ed35114b7161907047246751b
Oct 27, 2026
Merged

auto-submit[bot] merged 1 commit into
flutter:flutter-3.50-candidate.0from
flutteractionsbot:cp-beta-f4e2bc99cd0a625ed35114b7161907047246751b

Conversation

@flutteractionsbot

@flutteractionsbot flutteractionsbot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

Issue Link:

What is the link to the issue this cherry-pick is addressing?

#194251

Impact Description:

What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)?
Does it impact development (ex. flutter doctor crashes when Android Studio is installed),
or the shipping of production apps (the app crashes on launch).
This information is for domain experts and release engineers to understand the consequences of saying yes or no to the cherry pick.

CI test-only change to make macOS FlutterTextInputPluginTest less flakey and more stable on macOS 26.

Changelog Description:

Explain this cherry pick:

  • In one line that is accessible to most Flutter developers.
  • That describes the state prior to the fix.
  • That includes which platforms are impacted.
    See best practices for examples.

N/A - CI test-only change

Workaround:

Is there a workaround for this issue?

Rerun test

Risk:

What is the risk level of this cherry-pick?

  • Low
  • Medium
  • High

Test Coverage:

Are you confident that your fix is well-tested by automated tests?

  • Yes
  • No

Validation Steps:

What are the steps to validate that this fix works?

Test runs in CI or run locally with ./engine/src/out/host_release_arm64/flutter_desktop_darwin_unittests --gtest_shuffle --gtest_repeat=10

Fix was generated by gemini:

In FlutterTextInputPluginTest.mm, TextInputTestViewController previously
overrode `-createFlutterViewWithMTLDevice:commandQueue:` to return
`OCMClassMock([NSView class])`, which allocates a 72-byte
`OCClassMockObject` (`NSProxy` subclass) rather than a real `NSView`.


https://github.com/flutter/flutter/blob/449fb191435ed8ae509b71623142fc35e6932f46/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterTextInputPluginTest.mm#L49-L52

When `-[FlutterViewController loadView]` added that mock to a real
NSView (`FlutterViewWrapper`) via `-[NSView addSubview:]`, AppKit
directly accessed `NSView` instance variables at offsets beyond the
72-byte `OCClassMockObject` allocation, corrupting adjacent blocks in
the malloc freelist and triggering a libsystem_malloc EXC_BREAKPOINT
(memory corruption of free block) on subsequent allocations.


https://github.com/flutter/flutter/blob/449fb191435ed8ae509b71623142fc35e6932f46/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterViewController.mm#L384-L400

To fix this, `TextInputTestViewController` now overrides `-loadView` to
set `self.view` to a real `NSView` instance and `-flutterView` to return
the `OCMClassMock([FlutterView class])` directly without adding the
`NSProxy` mock to the AppKit view hierarchy.

---

Tested and verified manually:

I was able to re-create the crash locally and therefore verify it was
fixed using:
`./engine/src/out/host_release_arm64/flutter_desktop_darwin_unittests
--gtest_shuffle --gtest_repeat=10`

Fixes flutter#194251.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant in-code documentation (doc comments with
`///`).
- [x] If this PR introduces a new feature or capability, I created and
linked a website documentation issue or PR in [flutter/website] (or
verified none is needed).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

If this change needs to override an active code freeze, provide a
comment explaining why. The code freeze workflow can be overridden by
code reviewers. See pinned issues for any active code freezes with
guidance.

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[AI contribution guidelines]:
https://github.com/flutter/flutter/blob/main/CONTRIBUTING.ai.md
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[flutter/website]: https://github.com/flutter/website
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
@flutteractionsbot
flutteractionsbot requested a review from a team as a code owner October 26, 2026 18:32
@flutteractionsbot flutteractionsbot added the cp: review Cherry-picks in the review queue label Oct 26, 2026
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Oct 26, 2026
@flutteractionsbot

Copy link
Copy Markdown
Contributor Author

@vashworth please fill out the PR description above, afterwards the release team will review this request.

@flutter-dashboard

Copy link
Copy Markdown

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@github-actions github-actions Bot added a: text input Entering text in a text field or keyboard related problems engine flutter/engine related. See also e: labels. platform-macos Building on or for macOS specifically a: desktop Running on desktop team-macos Owned by the macOS platform team labels Oct 26, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors TextInputTestViewController in FlutterTextInputPluginTest.mm to initialize and expose a mocked FlutterView during the loadView lifecycle. Feedback suggests ensuring the view loading lifecycle is triggered within the flutterView getter by accessing self.view to prevent returning nil if accessed prematurely.

Comment on lines +57 to 59
- (FlutterView*)flutterView {
return _flutterViewMock;
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

If flutterView is accessed before the view controller's view is loaded, _flutterViewMock will be nil because loadView has not been triggered. Accessing self.view inside the getter ensures that the view loading lifecycle is triggered and _flutterViewMock is properly initialized.

- (FlutterView*)flutterView {
  (void)self.view;
  return _flutterViewMock;
}

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 27, 2026
@auto-submit
auto-submit Bot merged commit 8ec493d into flutter:flutter-3.50-candidate.0 Oct 27, 2026
11 checks passed
@flutteractionsbot
flutteractionsbot deleted the cp-beta-f4e2bc99cd0a625ed35114b7161907047246751b branch October 27, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: desktop Running on desktop a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD cp: review Cherry-picks in the review queue engine flutter/engine related. See also e: labels. platform-macos Building on or for macOS specifically team-macos Owned by the macOS platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants