Skip to content

Roll Skia from 62095415d5e2 to ab9b798555a6 (20 revisions) - #195339

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
engine-flutter-autoroll:skia-flutter-autoroll-0a2d0b47-da4e-4af7-a1de-56dc618be258-1793038925
Oct 26, 2026
Merged

auto-submit[bot] merged 1 commit into
flutter:masterfrom
engine-flutter-autoroll:skia-flutter-autoroll-0a2d0b47-da4e-4af7-a1de-56dc618be258-1793038925

Conversation

@engine-flutter-autoroll

Copy link
Copy Markdown
Contributor

https://skia.googlesource.com/skia.git/+log/62095415d5e2..ab9b798555a6

2026-10-26 [email protected] [ganesh] Don't set texImageFormat for BGRA as RGBx
2026-10-26 [email protected] Fix heap-buffer-overflow in RunBasedAdditiveBlitter and AAA convex walker
2026-10-26 [email protected] Fix potential heap OOB write in SkRgnBuilder for conic paths
2026-10-26 [email protected] [SkRecorder] Add Tests for skcpu::Recorder
2026-10-26 [email protected] [skparagraph] Reset font resolution caches when FontCollection changes
2026-10-26 [email protected] [canvaskit] Add softHyphenString to ParagraphStyle
2026-10-26 [email protected] Copy memory-backed streams in one bounded write
2026-10-26 [email protected] Honor mask preblend in the 3x LCD filter
2026-10-26 [email protected] [skunicode] Query ICU once per code point in computeCodeUnitFlags
2026-10-26 [email protected] Replace packed 4:2:2 RG16 support with the pair-interleaved view
2026-10-26 [email protected] [fontations] Call populate_axes outside SkASSERT
2026-10-26 [email protected] [DWriteFont] Avoid enumerating all TTC faces
2026-10-26 [email protected] Roll vulkan-deps from 7724413aefba to abafc97144c3 (1 revision)
2026-10-26 [email protected] Roll Skia Infra from 9446ff738410 to 5fece1179c24 (9 revisions)
2026-10-26 [email protected] Roll ANGLE from b938f6073bfd to 9addc2983b90 (19 revisions)
2026-10-26 [email protected] Roll Dawn from 537308541a07 to 1716e88cc9e5 (16 revisions)
2026-10-26 [email protected] Roll skottie-base from e9e9bc8435a6 to add81ce1dbe7
2026-10-26 [email protected] Roll jsfiddle-base from 56c9f227c169 to 267ae6e25ccf
2026-10-26 [email protected] Roll shaders-base from b5d16ac50a7b to 70b316187d0f
2026-10-26 [email protected] Roll debugger-app-base from 2ab63f6bb595 to cd38a27b85c7

If this roll has caused a breakage, revert this CL and set the roller
to dry run mode using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

https://skia.googlesource.com/skia.git/+log/62095415d5e2..ab9b798555a6

2026-10-26 [email protected] [ganesh] Don't set texImageFormat for BGRA as RGBx
2026-10-26 [email protected] Fix heap-buffer-overflow in RunBasedAdditiveBlitter and AAA convex walker
2026-10-26 [email protected] Fix potential heap OOB write in SkRgnBuilder for conic paths
2026-10-26 [email protected] [SkRecorder] Add Tests for skcpu::Recorder
2026-10-26 [email protected] [skparagraph] Reset font resolution caches when FontCollection changes
2026-10-26 [email protected] [canvaskit] Add softHyphenString to ParagraphStyle
2026-10-26 [email protected] Copy memory-backed streams in one bounded write
2026-10-26 [email protected] Honor mask preblend in the 3x LCD filter
2026-10-26 [email protected] [skunicode] Query ICU once per code point in computeCodeUnitFlags
2026-10-26 [email protected] Replace packed 4:2:2 RG16 support with the pair-interleaved view
2026-10-26 [email protected] [fontations] Call populate_axes outside SkASSERT
2026-10-26 [email protected] [DWriteFont] Avoid enumerating all TTC faces
2026-10-26 [email protected] Roll vulkan-deps from 7724413aefba to abafc97144c3 (1 revision)
2026-10-26 [email protected] Roll Skia Infra from 9446ff738410 to 5fece1179c24 (9 revisions)
2026-10-26 [email protected] Roll ANGLE from b938f6073bfd to 9addc2983b90 (19 revisions)
2026-10-26 [email protected] Roll Dawn from 537308541a07 to 1716e88cc9e5 (16 revisions)
2026-10-26 [email protected] Roll skottie-base from e9e9bc8435a6 to add81ce1dbe7
2026-10-26 [email protected] Roll jsfiddle-base from 56c9f227c169 to 267ae6e25ccf
2026-10-26 [email protected] Roll shaders-base from b5d16ac50a7b to 70b316187d0f
2026-10-26 [email protected] Roll debugger-app-base from 2ab63f6bb595 to cd38a27b85c7

If this roll has caused a breakage, revert this CL and set the roller
to dry run mode using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@engine-flutter-autoroll engine-flutter-autoroll added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 26, 2026
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Oct 26, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@github-actions github-actions Bot added the engine flutter/engine related. See also e: labels. label Oct 26, 2026
@auto-submit
auto-submit Bot added this pull request to the merge queue Oct 26, 2026
Merged via the queue into flutter:master with commit cf2948e Oct 26, 2026
27 of 28 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 26, 2026
dbebawy added a commit to dbebawy/flutter that referenced this pull request Oct 27, 2026
CanvasKit's ParagraphStyle gained softHyphenString in Skia 1bd2b0627c,
which rolled into Flutter in flutter#195339. CkParagraphStyle now sets it from
ParagraphStyle.hyphenCharacter, so the hyphenCharacter test runs on
CanvasKit too.

Part of flutter#189617.
suryaKommana2662 pushed a commit to suryaKommana2662/flutter that referenced this pull request Oct 29, 2026
…95339)

https://skia.googlesource.com/skia.git/+log/62095415d5e2..ab9b798555a6

2026-10-26 [email protected] [ganesh] Don't set texImageFormat
for BGRA as RGBx
2026-10-26 [email protected] Fix heap-buffer-overflow in
RunBasedAdditiveBlitter and AAA convex walker
2026-10-26 [email protected] Fix potential heap OOB write in
SkRgnBuilder for conic paths
2026-10-26 [email protected] [SkRecorder] Add Tests for
skcpu::Recorder
2026-10-26 [email protected] [skparagraph] Reset font resolution
caches when FontCollection changes
2026-10-26 [email protected] [canvaskit] Add softHyphenString to
ParagraphStyle
2026-10-26 [email protected] Copy memory-backed streams in one
bounded write
2026-10-26 [email protected] Honor mask preblend in the 3x LCD filter
2026-10-26 [email protected] [skunicode] Query ICU once per code point in
computeCodeUnitFlags
2026-10-26 [email protected] Replace packed 4:2:2 RG16 support with
the pair-interleaved view
2026-10-26 [email protected] [fontations] Call populate_axes outside
SkASSERT
2026-10-26 [email protected] [DWriteFont] Avoid enumerating all
TTC faces
2026-10-26 [email protected] Roll
vulkan-deps from 7724413aefba to abafc97144c3 (1 revision)
2026-10-26 [email protected] Roll Skia
Infra from 9446ff738410 to 5fece1179c24 (9 revisions)
2026-10-26 [email protected] Roll ANGLE
from b938f6073bfd to 9addc2983b90 (19 revisions)
2026-10-26 [email protected] Roll Dawn
from 537308541a07 to 1716e88cc9e5 (16 revisions)
2026-10-26 [email protected] Roll
skottie-base from e9e9bc8435a6 to add81ce1dbe7
2026-10-26 [email protected] Roll
jsfiddle-base from 56c9f227c169 to 267ae6e25ccf
2026-10-26 [email protected] Roll
shaders-base from b5d16ac50a7b to 70b316187d0f
2026-10-26 [email protected] Roll
debugger-app-base from 2ab63f6bb595 to cd38a27b85c7

If this roll has caused a breakage, revert this CL and set the roller
to dry run mode using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
[email protected],[email protected],[email protected] on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@engine-flutter-autoroll
engine-flutter-autoroll deleted the skia-flutter-autoroll-0a2d0b47-da4e-4af7-a1de-56dc618be258-1793038925 branch November 2, 2026 19:02
dbebawy added a commit to dbebawy/flutter that referenced this pull request Nov 3, 2026
CanvasKit's ParagraphStyle gained softHyphenString in Skia 1bd2b0627c,
which rolled into Flutter in flutter#195339. CkParagraphStyle now sets it from
ParagraphStyle.hyphenCharacter, so the hyphenCharacter test runs on
CanvasKit too.

Part of flutter#189617.
dbebawy added a commit to dbebawy/flutter that referenced this pull request Nov 3, 2026
CanvasKit's ParagraphStyle gained softHyphenString in Skia 1bd2b0627c,
which rolled into Flutter in flutter#195339. CkParagraphStyle now sets it from
ParagraphStyle.hyphenCharacter, so the hyphenCharacter test runs on
CanvasKit too.

Part of flutter#189617.
dbebawy added a commit to dbebawy/flutter that referenced this pull request Nov 5, 2026
CanvasKit's ParagraphStyle gained softHyphenString in Skia 1bd2b0627c,
which rolled into Flutter in flutter#195339. CkParagraphStyle now sets it from
ParagraphStyle.hyphenCharacter, so the hyphenCharacter test runs on
CanvasKit too.

Part of flutter#189617.
chingjun pushed a commit to chingjun/flutter that referenced this pull request Nov 7, 2026
Adds `hyphenCharacter` to `dart:ui`'s `ParagraphStyle`, so apps can
choose the string drawn at the end of a line that breaks at a soft
hyphen (U+00AD) instead of always "-". If it is null, "-" is drawn as
before. The empty string draws nothing, and the line still breaks there.

The engine passes it to Skia's `ParagraphStyle::setSoftHyphenString`,
which already reserves the string's width when breaking lines and
includes it in selection boxes. Skwasm gets a
`paragraphStyle_setSoftHyphenString` binding for the same call, and
CanvasKit sets the `softHyphenString` property that rolled in with
flutter#195339.

This is the additive `dart:ui` part of flutter#189617. The name and shape
follow the API question there, and I am happy to change them. The
framework side (`TextStyle.getParagraphStyle`, `TextPainter`,
`RenderParagraph`, `RichText` and `Text`) is ready as a follow-up PR,
along with a breaking change page for flutter/website, since a new
`getParagraphStyle` parameter breaks classes that override it. I will
open both once this lands.

WebParagraph stores the value but does not draw soft hyphens yet.
flutter#195366 adds soft hyphens there for flutter#193506, and can use this value once
both land.

Part of flutter#189617.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant in-code documentation (doc comments with
`///`).
- [ ] If this PR introduces a new feature or capability, I created and
linked a website documentation issue or PR in [flutter/website] (or
verified none is needed).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[AI contribution guidelines]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/website]: https://github.com/flutter/website
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD engine flutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants