Repository navigation
Fix web semantics language tags for locales with country codes - #195258
Draft
rahulshahDEV wants to merge 1 commit into
Draft
rahulshahDEV wants to merge 1 commit into
rahulshahDEV wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use
Locale.toLanguageTag()when writing the web semanticslangattribute. A locale constructed asLocale('es', 'US')now produces the BCP 47 tages-USinstead ofes_US, allowing browsers and assistive technology to recognize the language correctly.Fixes #194688
Verification
es-US, actuales_US.dart analyze: no issues found.dart format --set-exit-if-changedandgit diff --checkpassed.Contributor review completed on 2026-10-26, and independent spec and standards reviews found no actionable findings. The PR remains a draft because GitHub denied the ready-for-review state change.
Pre-launch Checklist
///).