Skip to content

Remove skia iOS benchmark - #195180

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
jmagman:new_gallery_skia_ios__transition_perf
Oct 26, 2026
Merged

auto-submit[bot] merged 1 commit into
flutter:masterfrom
jmagman:new_gallery_skia_ios__transition_perf

Conversation

@jmagman

@jmagman jmagman commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

Impeller opt-out for iOS was removed a long time ago. new_gallery_skia_ios__transition_perf and new_gallery_ios__transition_perf were testing the same things. Remove the skia variant.

Also very_long_picture_scrolling_perf_ios__e2e_summary was passing in impeller: false which is ignored on iOS. Swap the impeller to true. This doesn't change behavior but now isn't lying about what it's testing.

This will need a cherry-pick to beta so it doesn't fail in release.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@jmagman jmagman self-assigned this Oct 23, 2026
@jmagman jmagman added the engine flutter/engine related. See also e: labels. label Oct 23, 2026
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Oct 23, 2026
@github-actions github-actions Bot added f: scrolling Viewports, list views, slivers, etc. and removed engine flutter/engine related. See also e: labels. labels Oct 23, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the 'new_gallery_skia_ios__transition_perf' devicelab task, including its configuration in '.ci.yaml', its entry in 'TESTOWNERS', and its task file. It also updates the 'very_long_picture_scrolling_perf_ios__e2e_summary' task to enable Impeller. No review comments were provided, and there is no additional feedback.

@jmagman jmagman added the engine flutter/engine related. See also e: labels. label Oct 23, 2026
@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 26, 2026
@auto-submit
auto-submit Bot added this pull request to the merge queue Oct 26, 2026
Merged via the queue into flutter:master with commit 2594b88 Oct 26, 2026
38 of 39 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 26, 2026
@jmagman jmagman added cp: beta cherry pick this pull request to beta release candidate branch cp: stable cherry pick this pull request to stable release candidate branch labels Oct 26, 2026
@jmagman
jmagman deleted the new_gallery_skia_ios__transition_perf branch October 26, 2026 22:23
@flutteractionsbot

Copy link
Copy Markdown
Contributor

Failed to create CP due to merge conflicts.
You will need to create the PR manually. See the cherrypick wiki for more info.

auto-submit Bot pushed a commit that referenced this pull request Oct 27, 2026
### Issue Link:
#195180 (PR, there was no open issue)

### Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)?
Does it impact development (ex. flutter doctor crashes when Android Studio is installed),
or the shipping of production apps (the app crashes on launch).
This information is for domain experts and release engineers to understand the consequences of saying yes or no to the cherry pick.

Release builders should match the master branch configs. new_gallery_skia_ios__transition_perf was removed in #189377. Without this change, the beta release branch will try to run the old builder names and fail because the infra config is missing.

### Changelog Description:
Explain this cherry pick:
* In one line that is accessible to most Flutter developers.
* That describes the state prior to the fix.
* That includes which platforms are impacted.
See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples.

[flutter/195180] Remove obsolete iOS Skia performance benchmark.

### Workaround:
Is there a workaround for this issue?

N/A

### Risk:
What is the risk level of this cherry-pick?

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

### Validation Steps:
What are the steps to validate that this fix works?

Release PRs should not complain about missing new_gallery_skia_ios__transition_perf builder.
auto-submit Bot pushed a commit that referenced this pull request Oct 27, 2026
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

### Issue Link:
#195180 (PR, there was no open issue)

### Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)?
Does it impact development (ex. flutter doctor crashes when Android Studio is installed),
or the shipping of production apps (the app crashes on launch).
This information is for domain experts and release engineers to understand the consequences of saying yes or no to the cherry pick.

Release builders should match the master branch configs. new_gallery_skia_ios__transition_perf was removed in #189377. Without this change, the beta release branch will try to run the old builder names and fail because the infra config is missing.

### Changelog Description:
Explain this cherry pick:
* In one line that is accessible to most Flutter developers.
* That describes the state prior to the fix.
* That includes which platforms are impacted.
See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples.

[flutter/195180] Remove obsolete iOS Skia performance benchmark.

### Workaround:
Is there a workaround for this issue?

N/A

### Risk:
What is the risk level of this cherry-pick?

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

### Validation Steps:
What are the steps to validate that this fix works?

Release PRs should not complain about missing new_gallery_skia_ios__transition_perf builder.
suryaKommana2662 pushed a commit to suryaKommana2662/flutter that referenced this pull request Oct 29, 2026
Impeller opt-out for iOS was removed a long time ago.
`new_gallery_skia_ios__transition_perf` and
`new_gallery_ios__transition_perf` were testing the same things. Remove
the skia variant.

Also `very_long_picture_scrolling_perf_ios__e2e_summary` was passing in
`impeller: false` which is ignored on iOS. Swap the impeller to true.
This doesn't change behavior but now isn't lying about what it's
testing.

This will need a cherry-pick to beta so it doesn't fail in release.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant in-code documentation (doc comments with
`///`).
- [x] If this PR introduces a new feature or capability, I created and
linked a website documentation issue or PR in [flutter/website] (or
verified none is needed).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

If this change needs to override an active code freeze, provide a
comment explaining why. The code freeze workflow can be overridden by
code reviewers. See pinned issues for any active code freezes with
guidance.

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[AI contribution guidelines]:
https://github.com/flutter/flutter/blob/main/CONTRIBUTING.ai.md
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[flutter/website]: https://github.com/flutter/website
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
jose-pr pushed a commit to Boriken-Dev/flutter that referenced this pull request Nov 8, 2026
### Issue Link:
flutter/flutter#195180 (PR, there was no open issue)

### Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)?
Does it impact development (ex. flutter doctor crashes when Android Studio is installed),
or the shipping of production apps (the app crashes on launch).
This information is for domain experts and release engineers to understand the consequences of saying yes or no to the cherry pick.

Release builders should match the master branch configs. new_gallery_skia_ios__transition_perf was removed in flutter/flutter#189377. Without this change, the beta release branch will try to run the old builder names and fail because the infra config is missing.

### Changelog Description:
Explain this cherry pick:
* In one line that is accessible to most Flutter developers.
* That describes the state prior to the fix.
* That includes which platforms are impacted.
See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples.

[flutter/195180] Remove obsolete iOS Skia performance benchmark.

### Workaround:
Is there a workaround for this issue?

N/A

### Risk:
What is the risk level of this cherry-pick?

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

### Validation Steps:
What are the steps to validate that this fix works?

Release PRs should not complain about missing new_gallery_skia_ios__transition_perf builder.
jose-pr pushed a commit to Boriken-Dev/flutter that referenced this pull request Nov 8, 2026
### Issue Link:
flutter/flutter#195180 (PR, there was no open issue)

### Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)?
Does it impact development (ex. flutter doctor crashes when Android Studio is installed),
or the shipping of production apps (the app crashes on launch).
This information is for domain experts and release engineers to understand the consequences of saying yes or no to the cherry pick.

Release builders should match the master branch configs. new_gallery_skia_ios__transition_perf was removed in flutter/flutter#189377. Without this change, the beta release branch will try to run the old builder names and fail because the infra config is missing.

### Changelog Description:
Explain this cherry pick:
* In one line that is accessible to most Flutter developers.
* That describes the state prior to the fix.
* That includes which platforms are impacted.
See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples.

[flutter/195180] Remove obsolete iOS Skia performance benchmark.

### Workaround:
Is there a workaround for this issue?

N/A

### Risk:
What is the risk level of this cherry-pick?

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

### Validation Steps:
What are the steps to validate that this fix works?

Release PRs should not complain about missing new_gallery_skia_ios__transition_perf builder.
jose-pr pushed a commit to Boriken-Dev/flutter that referenced this pull request Nov 9, 2026
### Issue Link:
flutter/flutter#195180 (PR, there was no open issue)

### Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)?
Does it impact development (ex. flutter doctor crashes when Android Studio is installed),
or the shipping of production apps (the app crashes on launch).
This information is for domain experts and release engineers to understand the consequences of saying yes or no to the cherry pick.

Release builders should match the master branch configs. new_gallery_skia_ios__transition_perf was removed in flutter/flutter#189377. Without this change, the beta release branch will try to run the old builder names and fail because the infra config is missing.

### Changelog Description:
Explain this cherry pick:
* In one line that is accessible to most Flutter developers.
* That describes the state prior to the fix.
* That includes which platforms are impacted.
See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples.

[flutter/195180] Remove obsolete iOS Skia performance benchmark.

### Workaround:
Is there a workaround for this issue?

N/A

### Risk:
What is the risk level of this cherry-pick?

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

### Validation Steps:
What are the steps to validate that this fix works?

Release PRs should not complain about missing new_gallery_skia_ios__transition_perf builder.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD cp: beta cherry pick this pull request to beta release candidate branch cp: stable cherry pick this pull request to stable release candidate branch engine flutter/engine related. See also e: labels. f: scrolling Viewports, list views, slivers, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants