Add benchmark for warmed pipeline usage by walley892 · Pull Request #195001 · flutter/flutter

walley892 · 2026-10-21T21:40:54Z

Adds Impeller shader-warmup coverage metrics to the existing new_gallery benchmarks using the existing pipeline_variant_recorder.

Also fixes a bug in the recorder that prevented the ClipPipeline from being properly logged

Pre-launch Checklist

walley892 · 2026-10-21T21:42:13Z

/gemini review

gemini-code-assist

Code Review

This pull request enhances Impeller pipeline warmup metrics reporting by tracking whether pipelines were created eagerly (warmed) or lazily, along with their specialization constants and usage counts. It updates the PipelineLibrary to store this detailed usage, exposes it via the _flutter.getPipelineUsage service protocol, and integrates these metrics into the Devicelab performance tests and transition benchmarks. Feedback on the changes suggests catching all Object types instead of just Exception in the Dart performance test driver to robustly handle potential TypeError or other non-Exception errors during JSON parsing.

gemini-code-assist

Code Review

This pull request refactors Impeller's pipeline tracking to record both execution counts and whether a pipeline was eagerly created (warmed). It updates the _flutter.getPipelineUsage service protocol to return detailed pipeline metadata, including labels, specialization constants, counts, and warmup status. Additionally, it integrates these warmup metrics into the Devicelab performance tests and the Flutter Gallery transition benchmarks, and adds corresponding unit and integration tests. No review comments were provided.

gaaclarke

noice, just needs a bit of shuffling and organization

gaaclarke · 2026-10-22T20:18:47Z

+      if (std::optional<PipelineDescriptor> desc = pipeline->GetDescriptor()) {
+        context.GetPipelineLibrary()->LogPipelineCreation(*desc);
+      }


Instead of calling this here, can we do it at a higher level and only do it in non-release builds? I want to try to reduce the amount that logging invades essential logic.

LogPipelineCreation is a noop in release builds

flutter/engine/src/flutter/impeller/renderer/pipeline_library.cc

Line 42 in cc2c290

#if FLUTTER_RUNTIME_MODE == FLUTTER_RUNTIME_MODE_DEBUG || \

.

We could keep the logic where it is, but ClipPipeline will be missed in the logging because it uses SetDefault directly. We would have to add a manual LogPipeline call there.

I could rework things to have ClipPipeline go through the same entrypoint as everything else, but I'd probably want to do that in a follow-on PR rather than here.

Okay, let's just pass in the pipeline library instead of the context then. Let's give the function the minimal it needs to function.

gaaclarke · 2026-10-22T20:25:43Z

 #if FLUTTER_RUNTIME_MODE == FLUTTER_RUNTIME_MODE_DEBUG || \
    FLUTTER_RUNTIME_MODE == FLUTTER_RUNTIME_MODE_PROFILE
-  mutable RWMutex pipeline_use_counts_mutex_;
+  mutable RWMutex pipeline_usage_mutex_;


Remind me why we needed a readwrite mutex on this? Could we have just executed things on the raster thread instead?

The logging should always happen on the raster thread, but the calls to GetPipelineUseCounts happens on the I/O thread.

gaaclarke

Looking good, one more request to improve encapsulation

gaaclarke · 2026-10-23T17:51:30Z

+      if (std::optional<PipelineDescriptor> desc = pipeline->GetDescriptor()) {
+        context.GetPipelineLibrary()->LogPipelineCreation(*desc);
+      }


Okay, let's just pass in the pipeline library instead of the context then. Let's give the function the minimal it needs to function.

gaaclarke

lgtm, thanks!

walley892 · 2026-10-26T23:19:43Z

@gaaclarke updated because of clang-tidy failure

gaaclarke

tidy, you could eat off of this pr

flutter/flutter@d4c8577...0c2473c 2026-10-28 [email protected] Roll Packages from a8549ae to 13d38e0 (9 revisions) (flutter/flutter#195488) 2026-10-28 [email protected] Use int.oneBitCount in PersistentHashMap and scope 53-bit caps to JS (flutter/flutter#195005) 2026-10-28 [email protected] Roll pub packages (flutter/flutter#195483) 2026-10-28 [email protected] [iPhone Duo] Use the correct UIScreen to report the display size and update when fold/unfold (flutter/flutter#195199) 2026-10-28 [email protected] [fuchsia] Fix portable_ui_test.h includes for newer Fuchsia SDKs (flutter/flutter#195420) 2026-10-28 [email protected] Change default pipeline options to match production draw calls (flutter/flutter#194597) 2026-10-28 [email protected] Roll Fuchsia Test Scripts from 2T18KC7-LDQtmQiLP... to xl1LWBuppzu-BnOzV... (flutter/flutter#195450) 2026-10-27 [email protected] [flutter_tools] Inject dependencies into Darwin build targets, native assets, and Xcode build settings (flutter/flutter#194052) 2026-10-27 [email protected] Revert: Reland square corners fix (flutter/flutter#195436) 2026-10-27 [email protected] [flutter_tools] Add DeviceService app launch and flutter run support for tool extensions (flutter/flutter#194589) 2026-10-27 [email protected] [engine] Honor targetWidth/targetHeight for animated images (flutter/flutter#194615) 2026-10-27 [email protected] [Android][a11y] Set visibleToUser=false for hidden semantics nodes (flutter/flutter#194411) 2026-10-27 [email protected] Fix repo deletion test flake (flutter/flutter#195349) 2026-10-27 [email protected] Roll Packages from 23a05b6 to a8549ae (10 revisions) (flutter/flutter#195434) 2026-10-27 [email protected] [web] Capture pointers to the Flutter view so drags survive platform view iframes (flutter/flutter#195187) 2026-10-27 [email protected] [web] Add opt-in raw samples, measured sample count and warm-up phase hook to the web benchmark recorder (flutter/flutter#195118) 2026-10-27 [email protected] Link migration guide in deprecation messages (flutter/flutter#195361) 2026-10-27 [email protected] Pin basic_material_app_macos__compile to macOS 26 (flutter/flutter#195429) 2026-10-27 [email protected] Add benchmark for warmed pipeline usage (flutter/flutter#195001) 2026-10-27 [email protected] [flutter_tools] Add device log streaming support to DeviceService and ExtensionBackedDevice (flutter/flutter#194964) 2026-10-27 [email protected] Roll Dart SDK from 1d16c04dc346 to 65fc979759ca (4 revisions) (flutter/flutter#195383) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Adds Impeller shader-warmup coverage metrics to the existing new_gallery benchmarks using the existing pipeline_variant_recorder. Also fixes a bug in the recorder that prevented the ClipPipeline from being properly logged ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant in-code documentation (doc comments with `///`). - [x] If this PR introduces a new feature or capability, I created and linked a website documentation issue or PR in [flutter/website] (or verified none is needed). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.

Add benchmark for warmed pipeline usage

856a322

github-actions Bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Oct 21, 2026

gemini-code-assist Bot reviewed Oct 21, 2026

View reviewed changes

Comment thread dev/integration_tests/new_gallery/test_driver/transitions_perf_test.dart Resolved

walley892 added the CICD Run CI/CD label Oct 21, 2026

gem gem

0affb25

walley892 requested a review from gaaclarke October 22, 2026 18:23

walley892 marked this pull request as ready for review October 22, 2026 18:23

gemini-code-assist Bot reviewed Oct 22, 2026

View reviewed changes

gaaclarke requested changes Oct 22, 2026

View reviewed changes

willie

7f498b6

walley892 requested a review from gaaclarke October 22, 2026 23:31

gaaclarke requested changes Oct 23, 2026

View reviewed changes

walley892 added 2 commits October 26, 2026 14:43

willie round 2

a97172d

Merge remote-tracking branch 'upstream/master' into devicelab-cold-fetch

cbac685

walley892 requested a review from gaaclarke October 26, 2026 21:49

gaaclarke previously approved these changes Oct 26, 2026

View reviewed changes

tidy

9929661

walley892 dismissed gaaclarke’s stale review via 9929661 October 26, 2026 23:18

walley892 requested a review from gaaclarke October 26, 2026 23:19

gaaclarke approved these changes Oct 26, 2026

View reviewed changes

Merge branch 'master' into devicelab-cold-fetch

44e1b9f

walley892 added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 27, 2026

auto-submit Bot added this pull request to the merge queue Oct 27, 2026

Merged via the queue into flutter:master with commit 7ebd815 Oct 27, 2026
24 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 27, 2026

engine-flutter-autoroll mentioned this pull request Oct 27, 2026

Roll Flutter from a3d71d82160a to 7ebd8154adff (166 revisions) flutter/packages#13456

Closed

Conversation

walley892 commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

walley892 commented Oct 21, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gaaclarke left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gaaclarke Oct 22, 2026

Choose a reason for hiding this comment

Uh oh!

walley892 Oct 22, 2026

Choose a reason for hiding this comment

Uh oh!

gaaclarke Oct 23, 2026

Choose a reason for hiding this comment

Uh oh!

walley892 Oct 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

gaaclarke Oct 22, 2026

Choose a reason for hiding this comment

Uh oh!

walley892 Oct 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gaaclarke left a comment

Choose a reason for hiding this comment

Uh oh!

gaaclarke Oct 23, 2026

Choose a reason for hiding this comment

Uh oh!

gaaclarke left a comment

Choose a reason for hiding this comment

Uh oh!

walley892 commented Oct 26, 2026

Uh oh!

gaaclarke left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

walley892 commented Oct 21, 2026 •

edited

Loading