Repository navigation
[Linux] Add a tested memory duplication helper for older GLib headers - #194924
Draft
richyo-codes wants to merge 2 commits into
Draft
richyo-codes wants to merge 2 commits into
richyo-codes wants to merge 2 commits into
Conversation
Extract the private GLib compatibility helper independently of GTK4 and the accessibility semantics store. GLib headers before 2.68 use g_memdup after rejecting sizes that cannot fit its guint argument; newer headers retain the native g_memdup2 declaration. Related to flutter#194923. This is preparatory infrastructure; current upstream Linux sources do not yet call g_memdup2. Extracted from d4cb0c9 (header only; source-list registration adapted for upstream master).
Verify binary copies, independent storage, null and zero-length input, and rejection before truncating a gsize to the legacy guint API. Standalone tests pass with Bullseye GLib 2.66 headers (4 tests), Trixie GLib 2.82 headers (3 tests), and host headers (3 tests), linked to host GLib. Removing the size guard makes the old-header regression fail. Full engine/sysroot builds were not run.
github-actions
Bot
added
engine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Add a private compatibility helper for g_memdup2, introduced in GLib 2.68, so Linux code can use the same API with Bullseye and Trixie sysroot headers.
With older headers, the helper rejects sizes larger than G_MAXUINT before calling g_memdup, preventing silent truncation. Newer headers use GLib’s native implementation.
Tests cover binary copies, independent storage, null input, zero length, and oversized requests.
This is preparatory work related to #194923, extracted independently of GTK4 and accessibility changes. Current upstream Linux sources have no consumer yet; no public API or minimum runtime requirement changes.
g_memdup2is needed for GTK4 accessibility implementation.Validation:
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.