Repository navigation
[Android] Upgrade linux_android_emu_vulkan_stable AVD and temporarily skip GL-VK interop tests on Vulkan - #194887
Merged
auto-submit[bot] merged 4 commits intoOct 21, 2026
Conversation
… skip GL-VK interop tests on Vulkan
gmackall
marked this pull request as ready for review
October 20, 2026 20:47
gmackall
requested review from
a team and
mboetger
and removed request for
a team
October 20, 2026 20:47
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Android emulator CIPD version in .ci.yaml and temporarily skips two tests on the Vulkan backend in run_android_engine_tests.dart due to a gfxstream GL-VK interop regression. The reviewer recommends adding a TODO comment with a link to a tracking GitHub issue to ensure the workaround is documented and can be easily cleaned up later.
Comment on lines
+48
to
+52
| // Temporarily skip these two tests on the Vulkan emulator due to a gfxstream | ||
| // GL-VK interop regression in newer Android Emulator versions where | ||
| // AHardwareBuffers written via an offscreen OpenGL FBO read back as black | ||
| // when sampled in Vulkan. Both tests continue to run on OpenGL ES | ||
| // (ImpellerBackend.opengles). |
Contributor
There was a problem hiding this comment.
When temporarily skipping tests or adding workarounds, it is highly recommended to include a TODO comment with a link to the tracking GitHub issue. This ensures that the workaround is easily discoverable and can be cleaned up once the underlying issue is resolved.
// TODO(https://github.com/flutter/flutter/issues/170024): Re-enable these tests once the gfxstream GL-VK interop regression is fixed.
// Temporarily skip these two tests on the Vulkan emulator due to a gfxstream
// GL-VK interop regression in newer Android Emulator versions where
// AHardwareBuffers written via an offscreen OpenGL FBO read back as black
// when sampled in Vulkan. Both tests continue to run on OpenGL ES
// (ImpellerBackend.opengles).
mboetger
approved these changes
Oct 20, 2026
gmackall
added
the
autosubmit
auto-submit
Bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter/194887, Failed to enqueue flutter/flutter/194887 with HTTP 400: Pull request Required status check "Check Code Freeze" is queued.. |
gmackall
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
This was referenced Oct 21, 2026
LongCatIsLooong
pushed a commit
to LongCatIsLooong/flutter
that referenced
this pull request
Oct 22, 2026
… skip GL-VK interop tests on Vulkan (flutter#194887) Upgrades `linux_android_emu_vulkan_stable` in `.ci.yaml` from `build_id:8733065022087935185` to `build_id:8719362231152674241` (keeping `android_35_google_apis_x64.textpb`), unblocking the emulator upgrade off `build_id:8733065022087935185`. Temporarily skips `surface_texture_smiley_face_main.dart` and `virtual_display_platform_view_main.dart` on the Vulkan emulator in `run_android_engine_tests.dart` due to an Android Emulator `gfxstream` GL-VK interop regression where `AHardwareBuffer`s written via an offscreen OpenGL FBO read back as black when sampled in Vulkan. Both tests continue to run on OpenGL ES (`Linux_android_emu android_engine_opengles_tests`). Addresses flutter#170024 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant in-code documentation (doc comments with `///`). - [x] If this PR introduces a new feature or capability, I created and linked a website documentation issue or PR in [flutter/website] (or verified none is needed). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [flutter/website]: https://github.com/flutter/website [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Gray Mackall <[email protected]>
This was referenced Oct 22, 2026
suryaKommana2662
pushed a commit
to suryaKommana2662/flutter
that referenced
this pull request
Oct 29, 2026
… skip GL-VK interop tests on Vulkan (flutter#194887) Upgrades `linux_android_emu_vulkan_stable` in `.ci.yaml` from `build_id:8733065022087935185` to `build_id:8719362231152674241` (keeping `android_35_google_apis_x64.textpb`), unblocking the emulator upgrade off `build_id:8733065022087935185`. Temporarily skips `surface_texture_smiley_face_main.dart` and `virtual_display_platform_view_main.dart` on the Vulkan emulator in `run_android_engine_tests.dart` due to an Android Emulator `gfxstream` GL-VK interop regression where `AHardwareBuffer`s written via an offscreen OpenGL FBO read back as black when sampled in Vulkan. Both tests continue to run on OpenGL ES (`Linux_android_emu android_engine_opengles_tests`). Addresses flutter#170024 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant in-code documentation (doc comments with `///`). - [x] If this PR introduces a new feature or capability, I created and linked a website documentation issue or PR in [flutter/website] (or verified none is needed). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [flutter/website]: https://github.com/flutter/website [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Gray Mackall <[email protected]>
gmackall
added a commit
to Ram-Dawson/flutter
that referenced
this pull request
Nov 4, 2026
… 36.1.9 (build_id:8670032186093418337) (flutter#195856) Upgrades `linux_android_emu_vulkan_stable` in `.ci.yaml` from `build_id:8719362231152674241` (Android Emulator `35.3.11.0`, build `12836668`) to `build_id:8670032186093418337` (Android Emulator `36.1.9.0`, build `13823996`), matching `linux_android_emu_unstable`. Gemini suggests that the specific crash was fixed in the following AOSP links: In flutter#194887, `linux_android_emu_vulkan_stable` was bumped to `build_id:8719362231152674241` (API 35, Emulator `35.3.11.0`). However, Emulator `35.3.11.0` predates the upstream `gfxstream` host-visible memory mapping deadlock fixes ([aosp/3417044](https://android-review.googlesource.com/c/platform/hardware/google/gfxstream/+/3417044) and [aosp/3426215](https://android-review.googlesource.com/c/platform/hardware/google/gfxstream/+/3426215)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades
linux_android_emu_vulkan_stablein.ci.yamlfrombuild_id:8733065022087935185tobuild_id:8719362231152674241(keepingandroid_35_google_apis_x64.textpb), unblocking the emulator upgrade offbuild_id:8733065022087935185.Temporarily skips
surface_texture_smiley_face_main.dartandvirtual_display_platform_view_main.darton the Vulkan emulator inrun_android_engine_tests.dartdue to an Android EmulatorgfxstreamGL-VK interop regression whereAHardwareBuffers written via an offscreen OpenGL FBO read back as black when sampled in Vulkan. Both tests continue to run on OpenGL ES (Linux_android_emu android_engine_opengles_tests).Addresses #170024
Pre-launch Checklist
///).