Skip to content

Link the webview_flutter_wkwebview pin to its tracking issue - #194872

Merged
auto-submit[bot] merged 4 commits into
flutter:masterfrom
mdebbar:wkwebview-pin-issue-link
Oct 21, 2026
Merged

auto-submit[bot] merged 4 commits into
flutter:masterfrom
mdebbar:wkwebview-pin-issue-link

Conversation

@mdebbar

@mdebbar mdebbar commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #194864 (stacked on it until that lands).

Adds the tracking issue link next to the webview_flutter_wkwebview pin so whoever unpins it knows what to check.

Part of #194871

@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If both you and the PR author believe this PR qualifies for a test exemption, escalate to the tech lead for the changed area to review and apply the test-exempt label. All reviewers should feel empowered to ask for tests before escalating.

@github-actions github-actions Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 20, 2026
bkonyi
bkonyi previously approved these changes Oct 20, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request downgrades webview_flutter_wkwebview from version 3.27.1 to 3.27.0 in pubspec.yaml and pubspec.lock, and adds it to the manually pinned dependencies in update_packages_pins.dart to address an iOS compatibility issue. One review comment suggests adding double quotes around the sha256 value in pubspec.lock to maintain consistent formatting and prevent unexpected local diffs.

Comment thread pubspec.lock Resolved
@mdebbar
mdebbar dismissed bkonyi’s stale review October 20, 2026 16:41

The merge-base changed after approval.

@mdebbar
mdebbar requested a review from bkonyi October 20, 2026 16:42
@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 20, 2026
@auto-submit
auto-submit Bot added this pull request to the merge queue Oct 20, 2026
Merged via the queue into flutter:master with commit 85a6ad8 Oct 21, 2026
22 of 23 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 21, 2026
LongCatIsLooong pushed a commit to LongCatIsLooong/flutter that referenced this pull request Oct 22, 2026
…er#194872)

Follow-up to flutter#194864 (stacked on
it until that lands).

Adds the tracking issue link next to the `webview_flutter_wkwebview` pin
so whoever unpins it knows what to check.

Part of flutter#194871
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants