Repository navigation
Link the webview_flutter_wkwebview pin to its tracking issue - #194872
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If both you and the PR author believe this PR qualifies for a test exemption, escalate to the tech lead for the changed area to review and apply the |
There was a problem hiding this comment.
Code Review
This pull request downgrades webview_flutter_wkwebview from version 3.27.1 to 3.27.0 in pubspec.yaml and pubspec.lock, and adds it to the manually pinned dependencies in update_packages_pins.dart to address an iOS compatibility issue. One review comment suggests adding double quotes around the sha256 value in pubspec.lock to maintain consistent formatting and prevent unexpected local diffs.
The merge-base changed after approval.
…er#194872) Follow-up to flutter#194864 (stacked on it until that lands). Adds the tracking issue link next to the `webview_flutter_wkwebview` pin so whoever unpins it knows what to check. Part of flutter#194871
…er#194872) Follow-up to flutter#194864 (stacked on it until that lands). Adds the tracking issue link next to the `webview_flutter_wkwebview` pin so whoever unpins it knows what to check. Part of flutter#194871
Follow-up to #194864 (stacked on it until that lands).
Adds the tracking issue link next to the
webview_flutter_wkwebviewpin so whoever unpins it knows what to check.Part of #194871