Repository navigation
Pin webview_flutter_wkwebview to 3.27.0 - #194864
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If both you and the PR author believe this PR qualifies for a test exemption, escalate to the tech lead for the changed area to review and apply the |
github-actions
Bot
added
the
tool
mdebbar
added
the
emergency
|
Detected the If you add the The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue". |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request downgrades the webview_flutter_wkwebview package from version 3.27.1 to 3.27.0 in pubspec.yaml and pubspec.lock, and adds it to the manually pinned dependencies in update_packages_pins.dart to prevent SwiftPM resolution failures. I have no feedback to provide.
| 'flutter_template_images': '5.0.0', // Must always exactly match flutter_tools template. | ||
| 'material_color_utilities': '0.13.0', // Keep pinned to latest until 1.0.0. | ||
| 'data_assets': '0.20.0', // Keep pinned to latest until 1.0.0. Rolled by @dcharkes. | ||
| // 3.27.1 requires iOS 15, but google_mobile_ads' Package.swift still declares |
There was a problem hiding this comment.
Can we create an issue to track this?
|
Tracking issue for the unpin: #194871 |
Revert part of #13294 that updated the iOS and macOS versions. Re-add the availability checks. Still fix the `SecTrustGetCertificateAtIndex` deprecation issue. Due to Swift Package Manager issue flutter/flutter#194864, this broke plugins with dependencies targeting lower versions. Unblocks flutter/flutter#194871 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
…er#194872) Follow-up to flutter#194864 (stacked on it until that lands). Adds the tracking issue link next to the `webview_flutter_wkwebview` pin so whoever unpins it knows what to check. Part of flutter#194871
…er#194872) Follow-up to flutter#194864 (stacked on it until that lands). Adds the tracking issue link next to the `webview_flutter_wkwebview` pin so whoever unpins it knows what to check. Part of flutter#194871
`webview_flutter_wkwebview` 3.27.1 (flutter/packages#13294) raised its Swift package floor to [iOS 15](https://github.com/flutter/packages/blob/1c44dbf537a533f2abc96291e5c52f5e3cb5d691/packages/webview_flutter/webview_flutter_wkwebview/darwin/webview_flutter_wkwebview/Package.swift#L12). `google_mobile_ads` still declares [iOS 13](https://github.com/googleads/googleads-mobile-flutter/blob/ea70f22f17ed3c275e443a8d2dcbdd7fe0cf1cbf/packages/google_mobile_ads/ios/google_mobile_ads/Package.swift#L9) and depends on the [`webview-flutter-wkwebview` product](https://github.com/googleads/googleads-mobile-flutter/blob/ea70f22f17ed3c275e443a8d2dcbdd7fe0cf1cbf/packages/google_mobile_ads/ios/google_mobile_ads/Package.swift#L17-L24), so SwiftPM refuses to build any app that has both. `dev/benchmarks/platform_views_layout` is one of those apps, which took down the four `Mac_ios platform_views_scroll_perf_*` builders since flutter#194819: ``` Target Integrity (Xcode): The package product 'webview-flutter-wkwebview' requires minimum platform version 15.0 for the iOS platform, but this target supports 13.0 ``` Example CI failures: - https://ci.chromium.org/b/8667465549370430577 - https://ci.chromium.org/b/8667466129370978161 This pins `webview_flutter_wkwebview` to 3.27.0 until `google_mobile_ads` raises its minimum iOS version to 15 (its latest release, 9.1.0, still declares iOS 13).
…er#194872) Follow-up to flutter#194864 (stacked on it until that lands). Adds the tracking issue link next to the `webview_flutter_wkwebview` pin so whoever unpins it knows what to check. Part of flutter#194871
webview_flutter_wkwebview3.27.1 (flutter/packages#13294) raised its Swift package floor to iOS 15.google_mobile_adsstill declares iOS 13 and depends on thewebview-flutter-wkwebviewproduct, so SwiftPM refuses to build any app that has both.dev/benchmarks/platform_views_layoutis one of those apps, which took down the fourMac_ios platform_views_scroll_perf_*builders since #194819:Example CI failures:
This pins
webview_flutter_wkwebviewto 3.27.0 untilgoogle_mobile_adsraises its minimum iOS version to 15 (its latest release, 9.1.0, still declares iOS 13).