Repository navigation
[flutter_tools] Share Analytics.isBot and make isRunningOnBot sync - #194744
Merged
auto-submit[bot] merged 10 commits intoNov 9, 2026
Merged
Conversation
Bumps unified_analytics to 8.2.0, delegates BotDetector.isRunningOnBot to Analytics.isBot, and converts BotDetector.isRunningOnBot and globals.isRunningOnBot from Future<bool> to synchronous bool. Fixes flutter#194405
github-actions
Bot
added
platform-ios
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors BotDetector.isRunningOnBot to be synchronous, returning bool instead of Future<bool>, and delegates environment checks to Analytics.isBot from the updated unified_analytics package (version 8.2.0). This change propagates across the codebase, removing unnecessary await keywords and simplifying context runner initialization. Feedback suggests localizing _platform.environment to a local variable in BotDetector.isRunningOnBot to improve readability and avoid repeated lookups.
kevmoo
marked this pull request as draft
October 19, 2026 15:04
…94405 Resolves packages/flutter_tools/pubspec.yaml and pubspec.lock to origin/master (unified_analytics 8.2.0 rolled in flutter#194819) and caches _platform.environment locally in BotDetector.isRunningOnBot.
kevmoo
marked this pull request as ready for review
October 21, 2026 21:10
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors BotDetector.isRunningOnBot from an asynchronous getter returning Future<bool> to a synchronous getter returning bool, delegating the environment check to Analytics.isBot from package:unified_analytics. Consequently, all asynchronous calls to this getter across the codebase, including tests and helper methods, have been updated to run synchronously. Feedback on the changes points out that runInContext in context_runner.dart is still marked async but no longer contains any await expressions, which will trigger an unnecessary_async warning; adding await to the context.run call is suggested to resolve this.
github-actions
Bot
removed
platform-ios
github-actions
Bot
added
platform-ios
github-actions
Bot
added
team-ios
Member
|
@kevmoo looks like there are some merge conflicts to resolve. |
Contributor
Author
|
Merged master to resolve a conflict in |
bkonyi
approved these changes
Nov 9, 2026
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Nov 10, 2026
flutter/flutter@d463821...fffd8c2 2026-11-10 [email protected] Roll Fuchsia Test Scripts from 8QcsP_SmbsT09VgUs... to PXc5D7S_q6sIYpfFJ... (flutter/flutter#196273) 2026-11-10 [email protected] [web] Accept the capped letter spacing line shift in kitchensink (flutter/flutter#196148) 2026-11-10 [email protected] Fix Vulkan MSAA diagonal seam in FramebufferBlend (flutter/flutter#196197) 2026-11-10 [email protected] Read back images on the raster thread on OpenGLES (flutter/flutter#195927) 2026-11-10 [email protected] [web] Unify ui.Paint across CanvasKit and Skwasm (flutter/flutter#196071) 2026-11-10 [email protected] Roll Fuchsia Test Scripts from p3N3B-Kchh1bthB6n... to 8QcsP_SmbsT09VgUs... (flutter/flutter#196249) 2026-11-09 [email protected] [Impeller] Reland clipped BackdropFilter square corners fix (flutter/flutter#195716) 2026-11-09 [email protected] [web] Recreate canvas and context on CkOffscreenSurface resize to fix WebGL clipping (flutter/flutter#192769) 2026-11-09 [email protected] Roll Dart SDK from ee0f66fa0ad2 to a2baae273bb2 (1 revision) (flutter/flutter#196245) 2026-11-09 [email protected] Add Mac web_tool_tests_1_2 and _2_2 in bringup (flutter/flutter#196241) 2026-11-09 [email protected] Roll pub packages (flutter/flutter#196246) 2026-11-09 [email protected] Increase number of 'Windows tool_integration_tests' subshards (flutter/flutter#196243) 2026-11-09 [email protected] Roll Fuchsia Test Scripts from Jo-ZgQSNDuPsjlZ4s... to p3N3B-Kchh1bthB6n... (flutter/flutter#196238) 2026-11-09 [email protected] Skip UIScene pre-migration test cases on Xcode 27 (flutter/flutter#194755) 2026-11-09 [email protected] [flutter_tools] Share Analytics.isBot and make isRunningOnBot sync (flutter/flutter#194744) 2026-11-09 [email protected] [flutter_tools] Retry chromedriver startup when its port is taken (flutter/flutter#196150) 2026-11-09 [email protected] Remove unused vulkan_provider.cc (flutter/flutter#195513) 2026-11-09 [email protected] Roll Dart SDK from 3b174b7217fe to ee0f66fa0ad2 (13 revisions) (flutter/flutter#196217) 2026-11-09 [email protected] Goma is dead, long live RBE! (Take 2) (flutter/flutter#196212) 2026-11-09 [email protected] Split DevTools customer tests into its own customer_testing_devtools shard (flutter/flutter#195871) 2026-11-09 [email protected] Split mac_host_{debug,profile,release}_arm64_tests into one step per type (flutter/flutter#196031) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delegates
BotDetector.isRunningOnBottoAnalytics.isBotand convertsBotDetector.isRunningOnBotandglobals.isRunningOnBotfromFuture<bool>to synchronousbool.Fixes #194405
Pre-launch Checklist
///).