Repository navigation
Enable the comment_references lint - #194728
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If both you and the PR author believe this PR qualifies for a test exemption, escalate to the tech lead for the changed area to review and apply the |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enables the "comment_references" linter rule in analysis_options_common.yaml and disables it in engine/src/flutter/analysis_options.yaml with a TODO comment referencing an issue. No review comments were provided, and there is no additional feedback.
binding.dart imports dart:ui as ui with a show list that has no FlutterView, so [ui.FlutterView.viewId] does not resolve now that the comment_references lint is enabled (flutter#194728). The unprefixed reference resolves through the file's @DocImport 'dart:ui', like the other FlutterView references in it.
Enables the `comment_references` lint for the framework. All doc comment references outside the engine now resolve in Dart scope. The engine opts out for now.
Enables the
comment_referenceslint for the framework. All doc comment references outside the engine now resolve in Dart scope. The engine opts out for now.