Repository navigation
Use local Flutter/FlutterMacOS podspecs to validate plugin podspecs - #194604
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates plugin_lint_mac.dart to set up and include local podspecs for Flutter and FlutterMacOS during pod linting, and bumps the platform deployment targets in projectName.podspec.tmpl and integration_test.podspec. Review feedback suggests optimizing the setup by using symbolic links instead of copying large framework directories, which would also allow removing the copyDirectorySync helper. If the copy helper is retained, it must be updated to handle symbolic links to prevent crashes when encountering them in macOS framework bundles.
That one uses |
And update Flutter's supporting libraries to match. This version of Flutter requires AGP 9.1.1 or later: flutter/flutter#193813 We meet that since an earlier commit in this series, which upgraded AGP to 9.3.3. Also update generated files to match: - windows/flutter/: Flutter now registers each plugin after the plugins it depends on, and share_plus depends on url_launcher_windows: flutter/flutter#191591 - ios/Podfile.lock: Flutter's integration_test plugin now declares iOS 15.0 as its minimum, up from 12.0, which changes its podspec checksum: flutter/flutter#194604 Without this, `pod install` rewrites that line on current Flutter, and the iOS CI job fails on the change. Co-Authored-By: Claude Opus 5.5 <[email protected]>
…lutter#194604) Previously this test used CocoaPods remote pods for the Flutter and FlutterMacOS frameworks when linting plugin podspec. This required us to publish remote pods for the sole purpose of supporting this test (see go/upgrade-flutter-cocoapod-specs). CocoaPods will soon become read-only and we won't be able to update those any longer. This changes it to use a local podspec and framework instead of the remote one. This allows us to edit the podspec (increasing the minimum versions) without publishing it to the CocoaPods trunk. This PR also updates a few places we missed increasing the minimum versions. Fixes flutter#194583. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant in-code documentation (doc comments with `///`). - [x] If this PR introduces a new feature or capability, I created and linked a website documentation issue or PR in [flutter/website] (or verified none is needed). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/CONTRIBUTING.ai.md [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [flutter/website]: https://github.com/flutter/website [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Previously this test used CocoaPods remote pods for the Flutter and FlutterMacOS frameworks when linting plugin podspec. This required us to publish remote pods for the sole purpose of supporting this test (see go/upgrade-flutter-cocoapod-specs). CocoaPods will soon become read-only and we won't be able to update those any longer.
This changes it to use a local podspec and framework instead of the remote one. This allows us to edit the podspec (increasing the minimum versions) without publishing it to the CocoaPods trunk.
This PR also updates a few places we missed increasing the minimum versions.
Fixes #194583.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.