Skip to content

Use local Flutter/FlutterMacOS podspecs to validate plugin podspecs - #194604

Merged
auto-submit[bot] merged 3 commits into
flutter:masterfrom
vashworth:xcode_27_plugin_lint_mac
Oct 19, 2026
Merged

auto-submit[bot] merged 3 commits into
flutter:masterfrom
vashworth:xcode_27_plugin_lint_mac

Conversation

@vashworth

@vashworth vashworth commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Previously this test used CocoaPods remote pods for the Flutter and FlutterMacOS frameworks when linting plugin podspec. This required us to publish remote pods for the sole purpose of supporting this test (see go/upgrade-flutter-cocoapod-specs). CocoaPods will soon become read-only and we won't be able to update those any longer.

This changes it to use a local podspec and framework instead of the remote one. This allows us to edit the podspec (increasing the minimum versions) without publishing it to the CocoaPods trunk.

This PR also updates a few places we missed increasing the minimum versions.

Fixes #194583.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@vashworth
vashworth requested review from a team as code owners October 16, 2026 21:52
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Oct 16, 2026
@github-actions github-actions Bot added a: tests "flutter test", flutter_test, or one of our tests tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. f: integration_test The flutter/packages/integration_test plugin team-ios Owned by iOS platform team team-macos Owned by the macOS platform team labels Oct 16, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates plugin_lint_mac.dart to set up and include local podspecs for Flutter and FlutterMacOS during pod linting, and bumps the platform deployment targets in projectName.podspec.tmpl and integration_test.podspec. Review feedback suggests optimizing the setup by using symbolic links instead of copying large framework directories, which would also allow removing the copyDirectorySync helper. If the copy helper is retained, it must be updated to handle symbolic links to prevent crashes when encountering them in macOS framework bundles.

@vashworth
vashworth requested a review from jmagman October 16, 2026 22:03

@jmagman jmagman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vashworth

Copy link
Copy Markdown
Contributor Author

chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this pull request Oct 21, 2026
And update Flutter's supporting libraries to match.

This version of Flutter requires AGP 9.1.1 or later:
  flutter/flutter#193813
We meet that since an earlier commit in this series, which upgraded
AGP to 9.3.3.

Also update generated files to match:

- windows/flutter/: Flutter now registers each plugin after the
  plugins it depends on, and share_plus depends on
  url_launcher_windows:
    flutter/flutter#191591

- ios/Podfile.lock: Flutter's integration_test plugin now declares
  iOS 15.0 as its minimum, up from 12.0, which changes its podspec
  checksum:
    flutter/flutter#194604
  Without this, `pod install` rewrites that line on current Flutter,
  and the iOS CI job fails on the change.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
suryaKommana2662 pushed a commit to suryaKommana2662/flutter that referenced this pull request Oct 29, 2026
…lutter#194604)

Previously this test used CocoaPods remote pods for the Flutter and
FlutterMacOS frameworks when linting plugin podspec. This required us to
publish remote pods for the sole purpose of supporting this test (see
go/upgrade-flutter-cocoapod-specs). CocoaPods will soon become read-only
and we won't be able to update those any longer.

This changes it to use a local podspec and framework instead of the
remote one. This allows us to edit the podspec (increasing the minimum
versions) without publishing it to the CocoaPods trunk.

This PR also updates a few places we missed increasing the minimum
versions.

Fixes flutter#194583.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant in-code documentation (doc comments with
`///`).
- [x] If this PR introduces a new feature or capability, I created and
linked a website documentation issue or PR in [flutter/website] (or
verified none is needed).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

If this change needs to override an active code freeze, provide a
comment explaining why. The code freeze workflow can be overridden by
code reviewers. See pinned issues for any active code freezes with
guidance.

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[AI contribution guidelines]:
https://github.com/flutter/flutter/blob/main/CONTRIBUTING.ai.md
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[flutter/website]: https://github.com/flutter/website
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tests "flutter test", flutter_test, or one of our tests CICD Run CI/CD f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels. team-ios Owned by iOS platform team team-macos Owned by the macOS platform team tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Xcode 27] Mac_arm64 plugin_lint_mac fails

2 participants