Skip to content

[macOS] Fix FlutterTextInputPluginTest crash - #194581

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
vashworth:flutter_desktop_darwin_unittests_crash
Oct 19, 2026
Merged

auto-submit[bot] merged 1 commit into
flutter:masterfrom
vashworth:flutter_desktop_darwin_unittests_crash

Conversation

@vashworth

@vashworth vashworth commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Fix was generated by gemini:

In FlutterTextInputPluginTest.mm, TextInputTestViewController previously overrode -createFlutterViewWithMTLDevice:commandQueue: to return OCMClassMock([NSView class]), which allocates a 72-byte OCClassMockObject (NSProxy subclass) rather than a real NSView.

- (nonnull FlutterView*)createFlutterViewWithMTLDevice:(id<MTLDevice>)device
commandQueue:(id<MTLCommandQueue>)commandQueue {
return OCMClassMock([NSView class]);
}

When -[FlutterViewController loadView] added that mock to a real NSView (FlutterViewWrapper) via -[NSView addSubview:], AppKit directly accessed NSView instance variables at offsets beyond the 72-byte OCClassMockObject allocation, corrupting adjacent blocks in the malloc freelist and triggering a libsystem_malloc EXC_BREAKPOINT (memory corruption of free block) on subsequent allocations.

- (void)loadView {
FlutterView* flutterView;
id<MTLDevice> device = _engine.renderer.device;
id<MTLCommandQueue> commandQueue = _engine.renderer.commandQueue;
if (!device || !commandQueue) {
NSLog(@"Unable to create FlutterView; no MTLDevice or MTLCommandQueue available.");
return;
}
flutterView = [self createFlutterViewWithMTLDevice:device commandQueue:commandQueue];
if (_backgroundColor != nil) {
[flutterView setBackgroundColor:_backgroundColor];
}
FlutterViewWrapper* wrapperView = [[FlutterViewWrapper alloc] initWithFlutterView:flutterView
controller:self];
self.view = wrapperView;
_flutterView = flutterView;
}

To fix this, TextInputTestViewController now overrides -loadView to set self.view to a real NSView instance and -flutterView to return the OCMClassMock([FlutterView class]) directly without adding the NSProxy mock to the AppKit view hierarchy.


Tested and verified manually:

I was able to re-create the crash locally and therefore verify it was fixed using: ./engine/src/out/host_release_arm64/flutter_desktop_darwin_unittests --gtest_shuffle --gtest_repeat=10

Fixes #194251.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@vashworth
vashworth requested a review from a team as a code owner October 16, 2026 18:43
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Oct 16, 2026
@github-actions github-actions Bot added a: text input Entering text in a text field or keyboard related problems engine flutter/engine related. See also e: labels. platform-macos Building on or for macOS specifically a: desktop Running on desktop team-macos Owned by the macOS platform team labels Oct 16, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors TextInputTestViewController in FlutterTextInputPluginTest.mm by introducing a private _flutterViewMock instance variable, implementing loadView to initialize the view and mock, and adding a flutterView getter. The review feedback identifies two Objective-C style guide violations regarding pointer asterisk placement: one in the instance variable declaration and another in the flutterView method return type.

@jmagman jmagman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tricky one!

@vashworth vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 19, 2026
@auto-submit
auto-submit Bot added this pull request to the merge queue Oct 19, 2026
Merged via the queue into flutter:master with commit f4e2bc9 Oct 19, 2026
30 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 19, 2026
@vashworth vashworth added cp: beta cherry pick this pull request to beta release candidate branch cp: stable cherry pick this pull request to stable release candidate branch labels Oct 26, 2026
suryaKommana2662 pushed a commit to suryaKommana2662/flutter that referenced this pull request Oct 29, 2026
Fix was generated by gemini:

In FlutterTextInputPluginTest.mm, TextInputTestViewController previously
overrode `-createFlutterViewWithMTLDevice:commandQueue:` to return
`OCMClassMock([NSView class])`, which allocates a 72-byte
`OCClassMockObject` (`NSProxy` subclass) rather than a real `NSView`.


https://github.com/flutter/flutter/blob/449fb191435ed8ae509b71623142fc35e6932f46/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterTextInputPluginTest.mm#L49-L52

When `-[FlutterViewController loadView]` added that mock to a real
NSView (`FlutterViewWrapper`) via `-[NSView addSubview:]`, AppKit
directly accessed `NSView` instance variables at offsets beyond the
72-byte `OCClassMockObject` allocation, corrupting adjacent blocks in
the malloc freelist and triggering a libsystem_malloc EXC_BREAKPOINT
(memory corruption of free block) on subsequent allocations.


https://github.com/flutter/flutter/blob/449fb191435ed8ae509b71623142fc35e6932f46/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterViewController.mm#L384-L400

To fix this, `TextInputTestViewController` now overrides `-loadView` to
set `self.view` to a real `NSView` instance and `-flutterView` to return
the `OCMClassMock([FlutterView class])` directly without adding the
`NSProxy` mock to the AppKit view hierarchy.

---

Tested and verified manually:

I was able to re-create the crash locally and therefore verify it was
fixed using:
`./engine/src/out/host_release_arm64/flutter_desktop_darwin_unittests
--gtest_shuffle --gtest_repeat=10`

Fixes flutter#194251.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant in-code documentation (doc comments with
`///`).
- [x] If this PR introduces a new feature or capability, I created and
linked a website documentation issue or PR in [flutter/website] (or
verified none is needed).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

If this change needs to override an active code freeze, provide a
comment explaining why. The code freeze workflow can be overridden by
code reviewers. See pinned issues for any active code freezes with
guidance.

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[AI contribution guidelines]:
https://github.com/flutter/flutter/blob/main/CONTRIBUTING.ai.md
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[flutter/website]: https://github.com/flutter/website
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: desktop Running on desktop a: text input Entering text in a text field or keyboard related problems CICD Run CI/CD cp: beta cherry pick this pull request to beta release candidate branch cp: stable cherry pick this pull request to stable release candidate branch engine flutter/engine related. See also e: labels. platform-macos Building on or for macOS specifically team-macos Owned by the macOS platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[macOS 26] Mac_unopt flutter_desktop_darwin_unittests flakey, occasionally crashes

2 participants