Repository navigation
Stop compiling the PorterDuffBlend kScreen variant - #194538
Conversation
github-actions
Bot
added
engine
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the screen blend pipeline and its associated methods, constants, and configurations from the Impeller content context. A review comment suggests using 'const auto' instead of hardcoding the array size for 'porter_duff_constants' to improve maintainability.
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If both you and the PR author believe this PR qualifies for a test exemption, escalate to the tech lead for the changed area to review and apply the |
There was a problem hiding this comment.
Code Review
This pull request removes the screen blend pipeline and its associated methods and constants from ContentContext. The feedback suggests using auto for the porter_duff_constants declaration to avoid hardcoding the array size and improve maintainability.
| const std::array<std::vector<Scalar>, 14> porter_duff_constants = | ||
| GetPorterDuffSpecConstants(supports_decal); |
There was a problem hiding this comment.
Using auto here avoids duplicating the hardcoded array size 14 and improves maintainability if the number of Porter-Duff constants changes in the future.
| const std::array<std::vector<Scalar>, 14> porter_duff_constants = | |
| GetPorterDuffSpecConstants(supports_decal); | |
| const auto porter_duff_constants = | |
| GetPorterDuffSpecConstants(supports_decal); |
walley892
added
the
autosubmit
auto-submit
Bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/flutter/194538, because - This pull request has the |
walley892
added
autosubmit
auto-submit
Bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/flutter/194538, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
walley892
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
Stops compiling the PorterDuffBlend kScreen variant. This variant is unused, and the getter - GetScreenBlendPipeline has no callers in the codebase. When it was initially added in flutter-team-archive/engine#41098, it was also unused. Part of flutter#194511 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant in-code documentation (doc comments with `///`). - [x] If this PR introduces a new feature or capability, I created and linked a website documentation issue or PR in [flutter/website] (or verified none is needed). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
Stops compiling the PorterDuffBlend kScreen variant.
This variant is unused, and the getter - GetScreenBlendPipeline has no callers in the codebase. When it was initially added in flutter-team-archive/engine#41098, it was also unused.
Part of #194511
Pre-launch Checklist
///).