Repository navigation
Reland square corners fix - #194314
Merged
Merged
Reland square corners fix#194314
Conversation
Contributor
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates Impeller's canvas and clip stack implementation to preserve parent clip states across sibling restorations and prevent premature depth budget exhaustion. Specifically, it introduces a clip height tracking mechanism in EntityPassClipStack to selectively pop child clips, adjusts depth advancement in Canvas::Restore to only occur when clips are recorded, and updates Canvas::kMaxDepth to fit within 18-bit precision. Additionally, ClipContents::Render now supports an optional transform matrix, and several unit tests have been added to verify clip depth maintenance, parent clip preservation, and emulated advanced blends. There are no review comments to address, and I have no further feedback to provide.
github-actions
Bot
added
engine
andywolff
marked this pull request as ready for review
October 13, 2026 21:52
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces several changes to the Impeller engine's display list and canvas rendering logic to improve clip depth management and backdrop filter rendering. Key updates include modifying Canvas::Restore to conditionally advance depth, updating Canvas::SaveLayer to incorporate the 'is_onscreen' state, and enhancing ClipContents::Render to support optional transformation matrices. Additionally, the EntityPassClipStack was updated to preserve parent clip entities during restoration, and multiple new unit tests were added to verify these behaviors and ensure depth monotonicity across nested layers. I have no feedback to provide as there were no review comments.
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
gaaclarke
requested changes
Oct 13, 2026
gaaclarke
left a comment
gaaclarke
left a comment
Member
There was a problem hiding this comment.
@andywolff it sounds like this PR isn't verbatim the same as the last time it landed. Can you rebase this as 2 commits? One which is the original landing of the PR and the other is the thing you've changed, please?
Contributor
If the only issue you are addressing is "wasted depths" then we can/should do that as a separate fix in case it causes its own problems. |
andywolff
force-pushed
the
reland_sqfix
branch
from
October 14, 2026 20:21
2e8f991 to
0f5b4a4
Compare
Contributor
Author
Alright, I've changed this PR back to match the original. I'll send you a followup |
10 tasks done
gaaclarke
approved these changes
Oct 14, 2026
andywolff
added
the
autosubmit
auto-submit
Bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/flutter/194314, because - The status or check suite Presubmit has failed. Please fix the issues identified (or deflake) before re-applying this label. |
andywolff
added
the
autosubmit
|
Golden file changes are available for triage from new commit, Click here to view. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter-dashboard
Bot
removed
the
autosubmit
LongCatIsLooong
pushed a commit
to LongCatIsLooong/flutter
that referenced
this pull request
Oct 22, 2026
Fixes flutter#192992 Relands flutter#191096 Fixes flutter#190602 Fixes flutter#162172 This PR relands flutter#191096, which resolves the square corners regression in clipped backdrop filters. The original PR was reverted in flutter#193189 due to test flakiness and order dependencies in CI, which were resolved and landed separately in flutter#193497. This is a pure reland. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
This was referenced Oct 22, 2026
Contributor
|
A reason for requesting a revert of flutter/flutter/194314 could not be found or the reason was not properly formatted. Begin a comment with 'Reason for revert:' to tell the bot why this issue is being reverted. |
flutteractionsbot
removed
the
revert
Contributor
Author
|
reason for revert: changed opacity behavior causing golden flakes #195423 |
10 tasks done
Contributor
|
Successfully created revert PR: #195436 |
flutteractionsbot
removed
the
revert
mdebbar
pushed a commit
to molchanovia/flutter
that referenced
this pull request
Oct 27, 2026
Reverts: [Reland square corners fix](flutter#194314) Initiated by: @andywolff Reason for reverting: changed opacity behavior causing golden flakes flutter#195423 Original PR Author: @andywolff Reviewed By: @gaaclarke The original PR description is provided below: Fixes flutter#192992 Relands flutter#191096 Fixes flutter#190602 Fixes flutter#162172 This PR relands flutter#191096, which resolves the square corners regression in clipped backdrop filters. The original PR was reverted in flutter#193189 due to test flakiness and order dependencies in CI, which were resolved and landed separately in flutter#193497. This is a pure reland. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
suryaKommana2662
pushed a commit
to suryaKommana2662/flutter
that referenced
this pull request
Oct 29, 2026
Fixes flutter#192992 Relands flutter#191096 Fixes flutter#190602 Fixes flutter#162172 This PR relands flutter#191096, which resolves the square corners regression in clipped backdrop filters. The original PR was reverted in flutter#193189 due to test flakiness and order dependencies in CI, which were resolved and landed separately in flutter#193497. This is a pure reland. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
suryaKommana2662
pushed a commit
to suryaKommana2662/flutter
that referenced
this pull request
Oct 29, 2026
Reverts: [Reland square corners fix](flutter#194314) Initiated by: @andywolff Reason for reverting: changed opacity behavior causing golden flakes flutter#195423 Original PR Author: @andywolff Reviewed By: @gaaclarke The original PR description is provided below: Fixes flutter#192992 Relands flutter#191096 Fixes flutter#190602 Fixes flutter#162172 This PR relands flutter#191096, which resolves the square corners regression in clipped backdrop filters. The original PR was reverted in flutter#193189 due to test flakiness and order dependencies in CI, which were resolved and landed separately in flutter#193497. This is a pure reland. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #192992
Relands #191096
Fixes #190602
Fixes #162172
This PR relands #191096, which resolves the square corners regression in clipped backdrop filters. The original PR was reverted in #193189 due to test flakiness and order dependencies in CI, which were resolved and landed separately in #193497.
This is a pure reland.
Pre-launch Checklist
///).