Eliminate Dart 1 benchmarks #19430
Merged
Eliminate Dart 1 benchmarks #19430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Don't we also need to update |
cbracken
force-pushed
the
remove-dart1-benchmarks
branch
from
c7b83f9 to
e4f6362
Compare
Member
Author
Oops! Pushed before committing the non-manifest stuff. Updated. |
Member
|
Looks like the analyzer has one tiny complaint. |
Flutter app development has been Dart 2 only for a significant amount of time, and we're about to remove all support for Dart 1.
Member
Author
|
Fixed. |
cbracken
force-pushed
the
remove-dart1-benchmarks
branch
from
e4f6362 to
15600b1
Compare
Member
Author
|
@sjindel-google FYI the Flutter trees are currently closed pending the resolution of TODAY issues. I'll land this once the tree is re-opened. |
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
Jul 19, 2018
Flutter app development has been Dart 2 only for a significant amount of time, and we're about to remove all support for Dart 1.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flutter app development has been Dart 2 only for a significant amount of
time, and we're about to remove all support for Dart 1.