Skip to content

Conversation

@tianlunlee
Copy link
Contributor

@tianlunlee tianlunlee commented Jul 16, 2018

pesto_before

pesto_after

@willlarche
Copy link
Contributor

LGTM. Wait for LGTM from @HansMuller before merging.

Please also post a before and an after screenshots.

Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianlunlee tianlunlee force-pushed the feature-pesto-new-recipes branch from 9f84446 to 77f4d43 Compare July 20, 2018 14:54
@tianlunlee tianlunlee force-pushed the feature-pesto-new-recipes branch from 373ab27 to dfd0c7e Compare July 25, 2018 21:03
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need a time for this step?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the only step without a duration, but it's not necessary

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. I guess take it out then.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The duration.

@willlarche
Copy link
Contributor

LGTM

@tianlunlee tianlunlee force-pushed the feature-pesto-new-recipes branch 2 times, most recently from 44220e3 to ead0603 Compare August 3, 2018 15:17
@tianlunlee tianlunlee force-pushed the feature-pesto-new-recipes branch 3 times, most recently from 48728c3 to 77c9f19 Compare August 15, 2018 21:41
@tianlunlee tianlunlee force-pushed the feature-pesto-new-recipes branch from 68a952a to f122a21 Compare August 16, 2018 16:20
@HansMuller
Copy link
Contributor

Here's another LGTM for good measure: LGTM

@willlarche willlarche merged commit e2f3b3d into flutter:master Aug 17, 2018
Hixie added a commit that referenced this pull request Aug 18, 2018
Hixie added a commit that referenced this pull request Aug 18, 2018
* Revert "Deprecated CupertinoDialog in favor of a new widget called CupertinoP… (#20649)"

This reverts commit 3a4ae28.

* Revert "Feature pesto new recipes (#19415)"

This reverts commit e2f3b3d.

* Revert "Use markdown table (#20721)"

This reverts commit 82d43b9.

* Revert "Documentation regarding tap gesture callbacks (#20647)"

This reverts commit 3acc278.

* Revert "Add branch to footer information in flutter docs (#20711)"

This reverts commit 9118d3d.

* Revert "Performance test cleanup (#20652)"

This reverts commit 1993a67.

* Revert "Track number of package dependencies in Flutter (#20722)"

This reverts commit 03d6f18.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants