-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Feature pesto new recipes #19415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature pesto new recipes #19415
Conversation
|
LGTM. Wait for LGTM from @HansMuller before merging. Please also post a before and an after screenshots. |
HansMuller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
9f84446 to
77f4d43
Compare
373ab27 to
dfd0c7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need a time for this step?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the only step without a duration, but it's not necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah. I guess take it out then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The duration.
|
LGTM |
44220e3 to
ead0603
Compare
48728c3 to
77c9f19
Compare
This reverts commit 983b5fe38329070f075ec723d59bc9b62f1d73e7.
68a952a to
f122a21
Compare
|
Here's another LGTM for good measure: LGTM |
* Revert "Deprecated CupertinoDialog in favor of a new widget called CupertinoP… (#20649)" This reverts commit 3a4ae28. * Revert "Feature pesto new recipes (#19415)" This reverts commit e2f3b3d. * Revert "Use markdown table (#20721)" This reverts commit 82d43b9. * Revert "Documentation regarding tap gesture callbacks (#20647)" This reverts commit 3acc278. * Revert "Add branch to footer information in flutter docs (#20711)" This reverts commit 9118d3d. * Revert "Performance test cleanup (#20652)" This reverts commit 1993a67. * Revert "Track number of package dependencies in Flutter (#20722)" This reverts commit 03d6f18.
Uh oh!
There was an error while loading. Please reload this page.