Skip to content

[flutter_tools] Remove trailing dots from bug report URLs - #194132

Merged
auto-submit[bot] merged 4 commits into
flutter:masterfrom
Wreos:fix/49445-remove-trailing-dot-from-bug-report-url
Nov 3, 2026
Merged

[flutter_tools] Remove trailing dots from bug report URLs#194132
auto-submit[bot] merged 4 commits into
flutter:masterfrom
Wreos:fix/49445-remove-trailing-dot-from-bug-report-url

Conversation

@Wreos

@Wreos Wreos commented Oct 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Removes trailing periods from the issues URL in Flutter tool bug-report instructions, doctor crash diagnostics, Android debug-symbol stripping errors, browser launch errors, and the Gradle plugin's missing-assets error, preventing punctuation from becoming part of terminal links.
  • Adds or updates regression assertions for the URL suffix and affected diagnostic output.

Fixes #49445.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the AI contribution guidelines and understand my responsibilities, or I am not using AI tools.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant in-code documentation (doc comments with ///). Not applicable: only existing messages are changed.
  • If this PR introduces a new feature or capability, I created and linked a website documentation issue or PR in flutter/website (or verified none is needed). No new feature.
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • I followed the breaking change policy and added Data Driven Fixes where supported. No API change or migration needed.
  • All existing and new tests are passing. The five affected Dart test files (162 tests) and the targeted Kotlin regression test passed locally; full CI is pending.

@Wreos
[flutter_tools] Remove trailing dot from bug report URL
1617f45 
Avoid including sentence punctuation in the issue URL when terminals detect links. Add a regression test for the trailing dot.

Fixes flutter#49445
@github-actions

github-actions Bot commented Oct 10, 2026

Copy link
Copy Markdown

This pull request targets the main branch, but the primary branch for this repository is master.

Please change the base branch of this pull request to master.

See: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-base-branch-of-a-pull-request

@github-actions github-actions Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 10, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Oct 10, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the trailing period from the bug reporting URL in UserMessages and adds a corresponding unit test to ensure the instruction string does not end with a dot. I have no feedback to provide.

@Wreos
Wreos changed the base branch from main to master October 10, 2026 14:24
bkonyi
bkonyi reviewed Nov 2, 2026
View reviewed changes

@bkonyi bkonyi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Wreos, thanks for the fix! LGTM overall.

(Note: I'm an AI agent reviewing this PR on @bkonyi's behalf.)

One quick note: there are a few other spots where we print the issues URL with a trailing period (packages/flutter_tools_core/lib/src/diagnostics.dart:157, lib/src/android/gradle.dart:73, lib/src/web/chrome.dart:464, and gradle/src/main/kotlin/FlutterPlugin.kt:524). If you'd like to update those here as well, that's great! Otherwise, could you update the PR description to Part of https://github.com/flutter/flutter/issues/49445 so we don't prematurely close the tracking issue?

Left one small nit on the test assertion, but otherwise ready once that's settled.

Comment thread packages/flutter_tools/test/general.shard/base/user_messages_test.dart Outdated

testWithoutContext('Flutter tool bug instructions should not end with a dot', () {
final userMessages = UserMessages();
expect(userMessages.flutterToolBugInstructions, isNot(endsWith('.')));

@bkonyi bkonyi Nov 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: consider asserting the URL suffix directly so we verify both the URL and absence of trailing punctuation:

expect(
  userMessages.flutterToolBugInstructions,
  endsWith('https://github.com/flutter/flutter/issues'),
);

@Wreos Wreos Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thanks! Applied to all changes

@Wreos
Wreos requested a review from a team as a code owner November 3, 2026 06:01
@Wreos
Wreos requested review from mboetger and removed request for a team November 3, 2026 06:01
@github-actions github-actions Bot added platform-android Android applications specifically team-android Owned by Android platform team labels Nov 3, 2026
@Wreos Wreos changed the title [flutter_tools] Remove trailing dot from bug report URL [flutter_tools] Remove trailing dots from bug report URLs Nov 3, 2026
@Wreos

Wreos commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

Hi @Wreos, thanks for the fix! LGTM overall.

(Note: I'm an AI agent reviewing this PR on @bkonyi's behalf.)

One quick note: there are a few other spots where we print the issues URL with a trailing period (packages/flutter_tools_core/lib/src/diagnostics.dart:157, lib/src/android/gradle.dart:73, lib/src/web/chrome.dart:464, and gradle/src/main/kotlin/FlutterPlugin.kt:524). If you'd like to update those here as well, that's great! Otherwise, could you update the PR description to Part of https://github.com/flutter/flutter/issues/49445 so we don't prematurely close the tracking issue?

Left one small nit on the test assertion, but otherwise ready once that's settled.

Thank you for the feedback. :)
I updated all things you mentioned, since they are simple fixes and easier to fix at once

@bkonyi bkonyi added the CICD Run CI/CD label Nov 3, 2026
bkonyi
bkonyi approved these changes Nov 3, 2026
View reviewed changes

@bkonyi bkonyi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix! We'll just need one more reviewer before this can land.

@bkonyi bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 3, 2026
@auto-submit
auto-submit Bot added this pull request to the merge queue Nov 3, 2026
Merged via the queue into flutter:master with commit 876fe53 Nov 3, 2026
29 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 3, 2026
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 4, 2026
Merged
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Nov 4, 2026
@engine-flutter-autoroll
Roll Flutter from 934720261be0 to 3623d2d34543 (25 revisions) (#13555)
718b7cf 
flutter/flutter@9347202...3623d2d

2026-11-04 [email protected] Roll Skia from 49ec2655bf51 to aaa39bfcd393 (5 revisions) (flutter/flutter#195956)
2026-11-04 [email protected] Roll pub packages (flutter/flutter#195950)
2026-11-04 [email protected] Roll pub packages (flutter/flutter#195948)
2026-11-04 [email protected] local_engine_builds_common out of bringup (flutter/flutter#195862)
2026-11-04 [email protected] [web][a11y] Initialize slider semantics values when enabling (flutter/flutter#195564)
2026-11-04 [email protected] Drop Android SDK, JDK, and Gradle dependencies from framework_tests_misc (flutter/flutter#195869)
2026-11-04 [email protected] Roll Fuchsia Test Scripts from B6zarykZp6PKWRueg... to Jo-ZgQSNDuPsjlZ4s... (flutter/flutter#195937)
2026-11-04 [email protected] Balance tool_tests_commands and web_tool_tests subshards by duration (flutter/flutter#195863)
2026-11-04 [email protected] Roll Fuchsia Linux SDK from T_-6-6X1lDMghhAvX... to p0HDXLISPIElJfSz7... (flutter/flutter#195939)
2026-11-03 [email protected] Roll Skia from 3eeafac94f07 to 49ec2655bf51 (8 revisions) (flutter/flutter#195933)
2026-11-03 [email protected] Roll pub packages (flutter/flutter#195932)
2026-11-03 [email protected] [flutter_tools] Lazily initialize AppleContext dependencies via builder closures (flutter/flutter#191992)
2026-11-03 [email protected] [Android] Upgrade linux_android_emu_vulkan_stable avd_cipd_version to 36.1.9 (build_id:8670032186093418337) (flutter/flutter#195856)
2026-11-03 [email protected] [vulkan]: adds "color attachment read" dst dependency to subpass (flutter/flutter#195714)
2026-11-03 [email protected] [flutter_tools] Stream web dev server proxy responses instead of buffering them (flutter/flutter#194934)
2026-11-03 [email protected] Roll Skia from d80db8f8f856 to 3eeafac94f07 (6 revisions) (flutter/flutter#195926)
2026-11-03 [email protected] [flutter_tools] Add flutter assemble support for tool extension assemble targets (flutter/flutter#194563)
2026-11-03 [email protected] Manual roll Dart SDK from fe609902984b to e362a23e9738 (2 revisions) (flutter/flutter#195914)
2026-11-03 [email protected] feat(flutter_test): add startHover and startHoverAt helper to WidgetTester (flutter/flutter#190630)
2026-11-03 [email protected] [flutter_tools] Remove trailing dots from bug report URLs (flutter/flutter#194132)
2026-11-03 [email protected] Update skills_lint to 0.5.3 (flutter/flutter#195796)
2026-11-03 [email protected] Roll Skia from 58295d932350 to d80db8f8f856 (5 revisions) (flutter/flutter#195900)
2026-11-03 [email protected] [flutter_tools] Make DeviceLogReader.dispose asynchronous (flutter/flutter#195389)
2026-11-03 [email protected] Roll Packages from 3f34a6f to 1df8447 (10 revisions) (flutter/flutter#195895)
2026-11-03 [email protected] Roll Skia from c733ad3e37cb to 58295d932350 (1 revision) (flutter/flutter#195894)

If this roll has caused a breakage, revert this CL and set the roller
to dry run mode using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mboetger mboetger mboetger approved these changes
@bkonyi bkonyi bkonyi approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CICD Run CI/CD platform-android Android applications specifically team-android Owned by Android platform team tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

URL provided to report issue should not have a dot at the end

3 participants

@Wreos @mboetger @bkonyi