Repository navigation
Improve golden coverage to exercise previously untested shaders - #194055
Conversation
github-actions
Bot
added
engine
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors YUV test texture creation into a shared playground utility and adds unit tests for Impeller's display list rendering, covering YUV texture drawing, Porter-Duff blend color filters, round superellipse mask blurs, multi-stop gradients, and vertices drawing with advanced blend modes. It also corrects a color filter in an existing subpass optimization test. The review feedback recommends adding assertions to verify that fixture images are successfully loaded before use in the new tests to prevent potential null pointer dereferences.
There was a problem hiding this comment.
Code Review
This pull request adds several unit tests to verify YUV texture rendering, Porter-Duff blend color filters, round superellipse mask blurs, texture-backed gradients with many color stops, and vertices with advanced blend modes. It also refactors YUV test texture creation into a shared helper. The review feedback suggests using float literals with the 'f' suffix instead of double literals in several locations to prevent implicit double promotion, in accordance with the Google C++ Style Guide.
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
gaaclarke
left a comment
gaaclarke
left a comment
There was a problem hiding this comment.
Looking good for the most part, let's just demux those tests.
gaaclarke
left a comment
gaaclarke
left a comment
There was a problem hiding this comment.
lgtm assuming goldens look good to you
|
Golden file changes are available for triage from new commit, Click here to view. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
walley892
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
…ter#194055) Add golden tests for previously untested shaders. Follow on from flutter#193319. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant in-code documentation (doc comments with `///`). - [x] If this PR introduces a new feature or capability, I created and linked a website documentation issue or PR in [flutter/website] (or verified none is needed). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
Add golden tests for previously untested shaders. Follow on from #193319.
Pre-launch Checklist
///).