Refactored PipelineLibraryGLES by gaaclarke · Pull Request #193985 · flutter/flutter

gaaclarke · 2026-10-08T02:59:59Z

This PR is just a refactor that lays down the groundwork for the parallel linking work as started in #193066

Refactors:

Deleted PipelineLibraryQueue class, unifying the logic into their implementations.
Split out caching programs from creating pipelines, clearing up the logic.
Created a PendingProgram class to manage programs that are in the process of being linked.
Made queues private implementation details to the pipeline libraries, so they can be modified freely.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

gaaclarke · 2026-10-08T15:40:35Z

/gemini review

gemini-code-assist

Code Review

This pull request refactors the pipeline compilation queue mechanism in Impeller. It removes the generic, base PipelineCompileQueue class and its associated files, replacing it with backend-specific implementations (PipelineCompileQueueGLES and PipelineCompileQueueVulkan) that inherit directly from std::enable_shared_from_this. The PipelineLibrary interface is updated to replace GetPipelineCompileQueue with a new PerformEagerly method, allowing pending pipeline creations to be executed eagerly on the calling thread. Additionally, a new PendingProgram class is introduced in the GLES backend to separate shader compilation and program linking into distinct steps. Unit tests have been updated and expanded to cover these changes. There are no review comments to address, so no further feedback is provided.

gemini-code-assist

Code Review

This pull request refactors the Impeller pipeline compilation infrastructure by removing the base PipelineCompileQueue class and replacing it with backend-specific implementations (GLES and Vulkan). It introduces a new mechanism for eager pipeline compilation, allowing the renderer to perform compilation on the calling thread instead of waiting idly. Additionally, it updates the pipeline library to manage program compilation using a two-step 'Compile' and 'Wait' process, and includes comprehensive unit tests for the new compilation queue logic. I have no feedback to provide as there were no review comments to evaluate.

walley892

Mostly LGTM with some nits on the comments. This took me like 30 minutes to get my head around, which is an improvement on the existing implementation 🧠

walley892 · 2026-10-08T22:40:21Z

+  /// @brief      If the task has not yet been done, perform it eagerly on the
+  ///             calling thread. This can be used in lieu of an idle wait for
+  ///             the task completion on the calling thread.
+  ///
+  /// @param[in]  desc  The description
+  ///
+  void PerformJobEagerly(const PipelineDescriptor& desc);


Based on the PR - a job is something that compiles and waits for a shader and a task is something that's posted to the worker thread that executes a job.

Maybe the comment could read: "If the Job has not been scheduled for execution, perform is eagerly on the calling thread. This can be used in lieu of an idle wait for the job's task completion on the calling thread."

walley892 · 2026-10-08T22:42:35Z

+  /// Posts a task to the worker that performs the next pending job and then
+  /// schedules itself again. Stops once the queue is empty.
+  void ScheduleNextJob();


Nit: I think "schedules itself again" is unclear. Maybe "Posts a task to the worker that performs the next pending job and then schedules a task for the next job in the queue."

walley892 · 2026-10-08T22:44:37Z

+
+  if (!inserted) {
+    // This bit is being extremely conservative. If insertion did not take
+    // place, someone gave the compile queue a job for the same description.


nit: description -> descriptor

gaaclarke · 2026-10-09T19:54:39Z

This took me like 30 minutes to get my head around, which is an improvement on the existing implementation 🧠

Remember this isn't the change yet, just the refactor leading up to the change.

auto-submit · 2026-10-09T23:24:44Z

autosubmit label was removed for flutter/flutter/193985, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

gaaclarke · 2026-10-09T23:47:28Z

Oops, missed clang tidy

walley892

Oops, missed clang tidy

Relatable

…#13220) Manual roll Flutter from d03768eef055 to 4249ccbc18a3 (158 revisions) Manual roll requested by [email protected] flutter/flutter@d03768e...4249ccb 2026-10-12 [email protected] [AGP 9.1.0 Migration #8] Unify add-to-app module wiring on the variant API (flutter/flutter#193717) 2026-10-12 [email protected] [master] Update Flutter DEPS to Dart 5933cb486b4aef2f8cf6b9f89a5651c0d5b0955e (flutter/flutter#193982) 2026-10-12 [email protected] [Android] Fix use-after-free of SurfaceControl.Transaction in HCPP (flutter/flutter#192969) 2026-10-12 [email protected] [windows] Add OpenGL compositor tests against ANGLE at D3D11 feature level 10_0 (flutter/flutter#194114) 2026-10-12 [email protected] Fix HDR image packing for ios (flutter/flutter#192526) 2026-10-12 [email protected] Bump customer tests to pick up material_ui and cupertino_ui (flutter/flutter#194236) 2026-10-12 [email protected] Remove no-shuffle from text_field_test.dart (flutter/flutter#193550) 2026-10-12 [email protected] [web] Clip semantics DOM text labels to stop stealing taps (flutter/flutter#194011) 2026-10-12 [email protected] Roll Skia from 9b6ceba4728d to 17f6986c226c (6 revisions) (flutter/flutter#194232) 2026-10-12 [email protected] [web] Skip non-focusable containers in Focusable.focusAsRouteDefault (flutter/flutter#194138) 2026-10-12 [email protected] [web_paragraph] Honor kTextHeightNone in TextStyle and ParagraphStyle (flutter/flutter#193733) 2026-10-12 [email protected] Roll Skia from c88b49d1d6c7 to 9b6ceba4728d (4 revisions) (flutter/flutter#194226) 2026-10-12 [email protected] Migrate remaining test to macOS 26 (flutter/flutter#193825) 2026-10-12 [email protected] Roll Dart SDK from 047ca322aa9c to 221363557163 (1 revision) (flutter/flutter#194219) 2026-10-12 [email protected] [flutter_tools] Include dev_dependencies hooks for release integration tests (flutter/flutter#193436) 2026-10-12 [email protected] Roll Skia from d8afad1b1829 to c88b49d1d6c7 (1 revision) (flutter/flutter#194198) 2026-10-12 [email protected] Roll Skia from b23ddbff1265 to d8afad1b1829 (4 revisions) (flutter/flutter#194195) 2026-10-11 [email protected] Roll Skia from a168863e44ec to b23ddbff1265 (1 revision) (flutter/flutter#194185) 2026-10-11 [email protected] Roll Skia from 0c1d93abfa04 to a168863e44ec (1 revision) (flutter/flutter#194181) 2026-10-11 [email protected] iOS: Re-enable rendering on willEnterForeground (flutter/flutter#191350) 2026-10-11 [email protected] Roll Skia from 93c9d3ffda25 to 0c1d93abfa04 (1 revision) (flutter/flutter#194179) 2026-10-11 [email protected] Remove more instances of deprecated `withOpacity` (flutter/flutter#193559) 2026-10-11 [email protected] Fix another `parameter_assignments` warning (flutter/flutter#193669) 2026-10-11 [email protected] Roll Skia from 3136abef8f58 to 93c9d3ffda25 (1 revision) (flutter/flutter#194169) 2026-10-11 [email protected] [Impeller] Guard the sampler library caches with a mutex (flutter/flutter#193738) 2026-10-11 [email protected] Roll Dart SDK from e9c89888bcc1 to 047ca322aa9c (1 revision) (flutter/flutter#194157) 2026-10-10 [email protected] Roll Dart SDK from 787baa8aae78 to e9c89888bcc1 (2 revisions) (flutter/flutter#194141) 2026-10-10 [email protected] Fix OverlayPortal layout in shrink-wrapped overlays (flutter/flutter#193079) 2026-10-10 [email protected] Roll Skia from 353076e27b1c to 3136abef8f58 (1 revision) (flutter/flutter#194130) 2026-10-10 [email protected] Roll Dart SDK from 88a07589b1ff to 787baa8aae78 (1 revision) (flutter/flutter#194124) 2026-10-10 [email protected] Route windowing view lookups through WidgetsBinding (flutter/flutter#192666) 2026-10-10 [email protected] Roll Dart SDK from 2a06cab34715 to 88a07589b1ff (1 revision) (flutter/flutter#194117) 2026-10-10 [email protected] Roll Skia from f9043b7aa798 to 353076e27b1c (2 revisions) (flutter/flutter#194115) 2026-10-10 [email protected] Refactored PipelineLibraryGLES (flutter/flutter#193985) 2026-10-09 [email protected] add shorthands for scroll physics subclasses in framework (flutter/flutter#193082) 2026-10-09 [email protected] Roll Dart SDK from ba889e3cee8a to 2a06cab34715 (1 revision) (flutter/flutter#194105) 2026-10-09 [email protected] Roll Skia from 5ea03d8a53a6 to f9043b7aa798 (2 revisions) (flutter/flutter#194099) 2026-10-09 [email protected] Add docs for using bb and led with LUCI (flutter/flutter#193859) 2026-10-09 [email protected] Roll Skia from e329bb617820 to 5ea03d8a53a6 (5 revisions) (flutter/flutter#194087) 2026-10-09 [email protected] Roll Packages from 54706bd to d8d9e97 (5 revisions) (flutter/flutter#194080) 2026-10-09 [email protected] Move the Vulkan wrapped-texture helper out of the GPU surface (flutter/flutter#193001) 2026-10-09 [email protected] Roll Skia from 3e54bcf4c963 to e329bb617820 (1 revision) (flutter/flutter#194078) 2026-10-09 [email protected] Roll Dart SDK from 23f0308f9af8 to ba889e3cee8a (2 revisions) (flutter/flutter#194077) 2026-10-09 [email protected] Bump dartdoc to 9.0.11 (flutter/flutter#194076) ...

@krll-kov

> [!NOTE] > This PR depended on flutter#193985 which refactored code to make way for this change. This PR was authored in lieu of flutter#193066 and was informed by @krll-kov's great investigative work. design doc: https://github.com/flutter/rfc/blob/main/rfc/210.0001-parallel-gles-linking.md issue: flutter#191860 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant in-code documentation (doc comments with `///`). - [x] If this PR introduces a new feature or capability, I created and linked a website documentation issue or PR in [flutter/website] (or verified none is needed). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [flutter/website]: https://github.com/flutter/website [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

This PR is just a refactor that lays down the groundwork for the parallel linking work as started in flutter#193066 Refactors: 1) Deleted PipelineLibraryQueue class, unifying the logic into their implementations. 1) Split out caching programs from creating pipelines, clearing up the logic. 1) Created a PendingProgram class to manage programs that are in the process of being linked. 1) Made queues private implementation details to the pipeline libraries, so they can be modified freely. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant in-code documentation (doc comments with `///`). - [x] If this PR introduces a new feature or capability, I created and linked a website documentation issue or PR in [flutter/website] (or verified none is needed). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [flutter/website]: https://github.com/flutter/website [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

@krll-kov

> [!NOTE] > This PR depended on flutter#193985 which refactored code to make way for this change. This PR was authored in lieu of flutter#193066 and was informed by @krll-kov's great investigative work. design doc: https://github.com/flutter/rfc/blob/main/rfc/210.0001-parallel-gles-linking.md issue: flutter#191860 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant in-code documentation (doc comments with `///`). - [x] If this PR introduces a new feature or capability, I created and linked a website documentation issue or PR in [flutter/website] (or verified none is needed). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [flutter/website]: https://github.com/flutter/website [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

gaaclarke added 6 commits October 7, 2026 17:50

made PipelineCompileQueue an interface

a20c63d

simplified

bd8933f

removed auto

dc7b59e

split out program caching

e03020c

split out pending program

3fc9b57

made Wait return the handle

5581142

gaaclarke added the CICD Run CI/CD label Oct 8, 2026

github-actions Bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Oct 8, 2026

gaaclarke added 4 commits October 7, 2026 22:25

removes queue accessor from the library

fc7ee53

deletes PipelineCompileQueue

5ecbbe3

removed argument from WaitAndGet

c5b5814

removed superfluous branches

1052cbe

gemini-code-assist Bot reviewed Oct 8, 2026

View reviewed changes

oops

ce17457

gaaclarke force-pushed the refactor-pipelines branch from 13c8a98 to ce17457 Compare October 8, 2026 21:10

gaaclarke mentioned this pull request Oct 8, 2026

[impeller] parallelize opengles shader compiles #194022

Merged

11 tasks done

gaaclarke marked this pull request as ready for review October 8, 2026 21:24

gaaclarke requested a review from walley892 October 8, 2026 21:24

gemini-code-assist Bot reviewed Oct 8, 2026

View reviewed changes

walley892 requested changes Oct 8, 2026

View reviewed changes

evan feedback

e2ee683

gaaclarke requested a review from walley892 October 9, 2026 19:54

gaaclarke mentioned this pull request Oct 9, 2026

[Impeller][GLES] Link programs in parallel on ANGLE with GL_KHR_parallel_shader_compile #193066

Closed

7 tasks done

walley892 previously approved these changes Oct 9, 2026

View reviewed changes

Merge branch 'master' into refactor-pipelines

08fe0ce

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 9, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 9, 2026

clang tidy

3b92f46

gaaclarke dismissed walley892’s stale review via 3b92f46 October 9, 2026 23:47

gaaclarke requested a review from walley892 October 9, 2026 23:47

walley892 approved these changes Oct 9, 2026

View reviewed changes

walley892 added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 9, 2026

auto-submit Bot added this pull request to the merge queue Oct 10, 2026

Merged via the queue into flutter:master with commit dfcda7a Oct 10, 2026
23 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 10, 2026

Conversation

gaaclarke commented Oct 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

gaaclarke commented Oct 8, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

walley892 left a comment

Choose a reason for hiding this comment

Uh oh!

walley892 Oct 8, 2026

Choose a reason for hiding this comment

Uh oh!

gaaclarke Oct 9, 2026

Choose a reason for hiding this comment

Uh oh!

walley892 Oct 8, 2026

Choose a reason for hiding this comment

Uh oh!

gaaclarke Oct 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

walley892 Oct 8, 2026

Choose a reason for hiding this comment

Uh oh!

gaaclarke Oct 9, 2026

Choose a reason for hiding this comment

Uh oh!

gaaclarke commented Oct 9, 2026

Uh oh!

auto-submit Bot commented Oct 9, 2026

Uh oh!

gaaclarke commented Oct 9, 2026

Uh oh!

walley892 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gaaclarke commented Oct 8, 2026 •

edited

Loading