Repository navigation
Roll Skia from 5196c6736414 to 4401c6226f78 (15 revisions) - #193884
Merged
Conversation
https://skia.googlesource.com/skia.git/+log/5196c6736414..4401c6226f78 2026-10-06 [email protected] Roll debugger-app-base from cca7f4fd69fd to c34ed9a58f2f 2026-10-06 [email protected] Roll vulkan-deps from b36b0c80377e to 0deac90f2c63 (11 revisions) 2026-10-05 [email protected] [graphite] Various flatten fixes 2026-10-05 [email protected] [graphite] Fix flatten Top/Bot/Right culling 2026-10-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2026-10-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2026-10-05 [email protected] Revert "[gn] Use target_cc for unsafe_buffers_mappings compiler flag check" 2026-10-05 [email protected] SkCrabbyAvifCodec: Set imageContentToDecode explicitly 2026-10-05 [email protected] Manual roll ANGLE from 756d31051f12 to ed4af189c9d1 (9 revisions) 2026-10-05 [email protected] [canvaskit] Add renderSoftHyphens to ParagraphStyle 2026-10-05 [email protected] Report interlaced rowsDecoded in SkPngRustCodec 2026-10-05 [email protected] [rust ico] Preserve metadata for incomplete and oversized entries 2026-10-05 [email protected] [Raster] Optimize lowp::bilerp_clamp_8888 for horizontal scanlines 2026-10-05 [email protected] [SkRecorder] Add SkRecorder::TODO() to unblock removing SkCPURecorder.h 2026-10-05 [email protected] Reland "[spanify] Rewrite C-style arrays to std::array and std::to_array" If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
fluttergithubbot
approved these changes
Oct 6, 2026
This was referenced Oct 6, 2026
engine-flutter-autoroll
deleted the
skia-flutter-autoroll-8f63b758-e5d4-4973-957d-27bb6b4fdff5-1791262593
branch
October 13, 2026 05:15
1 of 11 tasks
dbebawy
added a commit
to dbebawy/flutter
that referenced
this pull request
Oct 15, 2026
CanvasKit's ParagraphStyle gained renderSoftHyphens in Skia 327c15e8176e, which rolled in with flutter#193884. Set it the same way the native engine does: render the hyphen unless hyphens is Hyphens.hidden. The hyphen tests now run on every web renderer, and the TextPainter.hyphens docs no longer need a web caveat.
opensource-fork-sync Bot
pushed a commit
to cla7aye15I4nd/opensource-flutter__flutter
that referenced
this pull request
Oct 17, 2026
Makes `Hyphens` work on the CanvasKit renderer, following flutter#193850 for Skwasm. CanvasKit's `ParagraphStyle` gained `renderSoftHyphens` in Skia (https://skia-review.googlesource.com/c/skia/+/1378836), which rolled into Flutter with flutter#193884. `CkParagraphStyle` now sets it the same way the native engine and Skwasm do: soft hyphens render at a line break unless `Hyphens.hidden` is set. Because CanvasKit is the default renderer for `flutter build web`, text containing U+00AD in most web apps now shows a hyphen at soft-hyphen line breaks, matching native and Skwasm. This also covers a `--wasm` app that falls back to CanvasKit. With both web renderers supported, the hyphen tests in `paragraph_builder_test.dart` and the `TextPainter` hyphen tests no longer skip on the web, and the `TextPainter.hyphens` docs drop the web caveat. WebParagraph, which is experimental and off by default, still ignores `hyphens`; its TODO stays on flutter#193506. Part of flutter#193506. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant in-code documentation (doc comments with `///`). - [ ] If this PR introduces a new feature or capability, I created and linked a website documentation issue or PR in [flutter/website] (or verified none is needed). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/CONTRIBUTING.ai.md [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [flutter/website]: https://github.com/flutter/website [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
suryaKommana2662
pushed a commit
to suryaKommana2662/flutter
that referenced
this pull request
Oct 29, 2026
…93884) https://skia.googlesource.com/skia.git/+log/5196c6736414..4401c6226f78 2026-10-06 [email protected] Roll debugger-app-base from cca7f4fd69fd to c34ed9a58f2f 2026-10-06 [email protected] Roll vulkan-deps from b36b0c80377e to 0deac90f2c63 (11 revisions) 2026-10-05 [email protected] [graphite] Various flatten fixes 2026-10-05 [email protected] [graphite] Fix flatten Top/Bot/Right culling 2026-10-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2026-10-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2026-10-05 [email protected] Revert "[gn] Use target_cc for unsafe_buffers_mappings compiler flag check" 2026-10-05 [email protected] SkCrabbyAvifCodec: Set imageContentToDecode explicitly 2026-10-05 [email protected] Manual roll ANGLE from 756d31051f12 to ed4af189c9d1 (9 revisions) 2026-10-05 [email protected] [canvaskit] Add renderSoftHyphens to ParagraphStyle 2026-10-05 [email protected] Report interlaced rowsDecoded in SkPngRustCodec 2026-10-05 [email protected] [rust ico] Preserve metadata for incomplete and oversized entries 2026-10-05 [email protected] [Raster] Optimize lowp::bilerp_clamp_8888 for horizontal scanlines 2026-10-05 [email protected] [SkRecorder] Add SkRecorder::TODO() to unblock removing SkCPURecorder.h 2026-10-05 [email protected] Reland "[spanify] Rewrite C-style arrays to std::array and std::to_array" If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
suryaKommana2662
pushed a commit
to suryaKommana2662/flutter
that referenced
this pull request
Oct 29, 2026
Makes `Hyphens` work on the CanvasKit renderer, following flutter#193850 for Skwasm. CanvasKit's `ParagraphStyle` gained `renderSoftHyphens` in Skia (https://skia-review.googlesource.com/c/skia/+/1378836), which rolled into Flutter with flutter#193884. `CkParagraphStyle` now sets it the same way the native engine and Skwasm do: soft hyphens render at a line break unless `Hyphens.hidden` is set. Because CanvasKit is the default renderer for `flutter build web`, text containing U+00AD in most web apps now shows a hyphen at soft-hyphen line breaks, matching native and Skwasm. This also covers a `--wasm` app that falls back to CanvasKit. With both web renderers supported, the hyphen tests in `paragraph_builder_test.dart` and the `TextPainter` hyphen tests no longer skip on the web, and the `TextPainter.hyphens` docs drop the web caveat. WebParagraph, which is experimental and off by default, still ignores `hyphens`; its TODO stays on flutter#193506. Part of flutter#193506. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant in-code documentation (doc comments with `///`). - [ ] If this PR introduces a new feature or capability, I created and linked a website documentation issue or PR in [flutter/website] (or verified none is needed). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/CONTRIBUTING.ai.md [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [flutter/website]: https://github.com/flutter/website [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://skia.googlesource.com/skia.git/+log/5196c6736414..4401c6226f78
2026-10-06 [email protected] Roll debugger-app-base from cca7f4fd69fd to c34ed9a58f2f
2026-10-06 [email protected] Roll vulkan-deps from b36b0c80377e to 0deac90f2c63 (11 revisions)
2026-10-05 [email protected] [graphite] Various flatten fixes
2026-10-05 [email protected] [graphite] Fix flatten Top/Bot/Right culling
2026-10-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2026-10-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2026-10-05 [email protected] Revert "[gn] Use target_cc for unsafe_buffers_mappings compiler flag check"
2026-10-05 [email protected] SkCrabbyAvifCodec: Set imageContentToDecode explicitly
2026-10-05 [email protected] Manual roll ANGLE from 756d31051f12 to ed4af189c9d1 (9 revisions)
2026-10-05 [email protected] [canvaskit] Add renderSoftHyphens to ParagraphStyle
2026-10-05 [email protected] Report interlaced rowsDecoded in SkPngRustCodec
2026-10-05 [email protected] [rust ico] Preserve metadata for incomplete and oversized entries
2026-10-05 [email protected] [Raster] Optimize lowp::bilerp_clamp_8888 for horizontal scanlines
2026-10-05 [email protected] [SkRecorder] Add SkRecorder::TODO() to unblock removing SkCPURecorder.h
2026-10-05 [email protected] Reland "[spanify] Rewrite C-style arrays to std::array and std::to_array"
If this roll has caused a breakage, revert this CL and set the roller
to dry run mode using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md