Repository navigation
Reland "[flutter_tools] forward --offline flag to pub.get in update-packages" - #193838
Merged
Merged
Conversation
…ackages" Relands flutter#193619 (reverted in flutter#193808) with `const DelegatingToolContext()` in `update_packages_test.dart` to satisfy `prefer_const_constructors`. Fixes flutter#193423
bkonyi
added
CICD
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for an --offline flag in the UpdatePackagesCommand by passing the offline state to the _pubGet helper and the underlying pub.get call, along with corresponding tests. Feedback suggests simplifying the _pubGet helper method and its call sites by directly accessing the inherited offline instance property instead of passing it as an explicit parameter.
Simplifies `_pubGet` and its call sites in `UpdatePackagesCommand.runCommand` by reading `boolArg(_keyOffline)` directly inside `_pubGet` instead of threading an `offline` parameter.
# Conflicts: # packages/flutter_tools/lib/src/commands/update_packages.dart # packages/flutter_tools/test/commands.shard/hermetic/update_packages_test.dart
Contributor
|
An existing Git SHA, To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with |
bkonyi
marked this pull request as ready for review
October 16, 2026 19:53
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the _pubGet method in UpdatePackagesCommand to use named parameters, including a new offline parameter derived from command-line arguments. It also updates the _FakePub test utility to record these calls and adds test cases to verify that the offline flag is correctly passed. I have no feedback to provide.
chingjun
approved these changes
Oct 20, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 21, 2026
flutter-dashboard
Bot
removed
the
autosubmit
auto-submit
Bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/flutter/193838, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR. |
flutter-dashboard
Bot
removed
the
autosubmit
This was referenced Oct 24, 2026
This was referenced Oct 25, 2026
suryaKommana2662
pushed a commit
to suryaKommana2662/flutter
that referenced
this pull request
Oct 29, 2026
…ackages" (flutter#193838) Relands flutter#193619 (reverted in flutter#193808) with `const` added to `DelegatingToolContext()` in `update_packages_test.dart` to satisfy `prefer_const_constructors`. When running `flutter update-packages --offline`, the `--offline` flag was parsed and used to validate incompatible option combinations (such as `--force-upgrade` and `--cherry-pick-package`), but was not forwarded to the underlying `pub.get` invocations. Read `boolArg(_keyOffline)` in `_pubGet` and forward it to `pub.get` so that `pub` does not attempt network operations in offline environments. Fixes flutter#193423 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [breaking change policy]: https://flutter.dev/to/breaking-changes [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relands #193619 (reverted in #193808) with
constadded toDelegatingToolContext()inupdate_packages_test.dartto satisfyprefer_const_constructors.When running
flutter update-packages --offline, the--offlineflag was parsed and used to validate incompatible option combinations (such as--force-upgradeand--cherry-pick-package), but was not forwarded to the underlyingpub.getinvocations. ReadboolArg(_keyOffline)in_pubGetand forward it topub.getso thatpubdoes not attempt network operations in offline environments.Fixes #193423
Pre-launch Checklist
///).