Skip to content

Fix specify_nonobvious_local_variable_types lint in record_use_test_package - #193720

Merged
auto-submit[bot] merged 2 commits into
flutter:masterfrom
bkonyi:fix_nonobvious_variable_types
Oct 3, 2026
Merged

auto-submit[bot] merged 2 commits into
flutter:masterfrom
bkonyi:fix_nonobvious_variable_types

Conversation

@bkonyi

@bkonyi bkonyi commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Adds an explicit String type annotation to the pattern-introduced local variable in dev/integration_tests/record_use_test_package/hook/link.dart in preparation for https://dart-review.googlesource.com/c/sdk/+/548220.

…t_package`

Adds an explicit `String` type annotation to the pattern-introduced local variable in `dev/integration_tests/record_use_test_package/hook/link.dart` in preparation for https://dart-review.googlesource.com/c/sdk/+/548220.
@bkonyi bkonyi added the CICD Run CI/CD label Oct 2, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the pattern matching in link.dart to explicitly type the extracted value from StringConstant as a String. There are no review comments, and I have no feedback to provide.

@bkonyi
bkonyi requested a review from srawlins October 2, 2026 17:58
@bkonyi bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 2, 2026
@auto-submit
auto-submit Bot added this pull request to the merge queue Oct 3, 2026
Merged via the queue into flutter:master with commit 53d381d Oct 3, 2026
17 of 18 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 3, 2026
suryaKommana2662 pushed a commit to suryaKommana2662/flutter that referenced this pull request Oct 29, 2026
…t_package` (flutter#193720)

Adds an explicit `String` type annotation to the pattern-introduced
local variable in
`dev/integration_tests/record_use_test_package/hook/link.dart` in
preparation for https://dart-review.googlesource.com/c/sdk/+/548220.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants