Repository navigation
[web] Test that Firefox < 147 rejects dart2wasm before Wasm capability checks - #193667
Merged
auto-submit[bot] merged 4 commits intoOct 2, 2026
Merged
Conversation
…y checks
Verifies in `firefox-fallbacks` (`fallbacks_test.dart`) that:
1. Firefox 146 (`< 147`) rejects `dart2wasm` builds before evaluating `WebAssembly.validate` or `_flutter.supportsDart2Wasm` even when `wasmAllowList: { gecko: true }` is configured.
2. Firefox 147 (`>= 147`) passes the Firefox version gate and proceeds to evaluate `WebAssembly.validate`.
Related to flutter#143603 and flutter#186619
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a test to verify that the loader rejects dart2wasm on Firefox versions older than 147 before evaluating Wasm capabilities. Feedback on the test implementation suggests deleting the supportsDart2Wasm property in the finally block to properly restore the global state, and removing a redundant redefinition of supportsDart2Wasm in the second step of the test.
github-actions
Bot
added
engine
…y and restore in finally
mdebbar
previously approved these changes
Oct 1, 2026
mdebbar
approved these changes
Oct 2, 2026
flutter-dashboard
Bot
removed
the
autosubmit
This was referenced Oct 3, 2026
This was referenced Oct 5, 2026
suryaKommana2662
pushed a commit
to suryaKommana2662/flutter
that referenced
this pull request
Oct 29, 2026
…y checks (flutter#193667) Adds a regression test in `fallbacks_test.dart` (`firefox-fallbacks` suite) verifying the `Firefox < 147` version gate added in flutter#193180 (and its precedence over `_flutter.supportsDart2Wasm` in flutter#193271): 1. **Firefox 146 (`< 147`)**: Even when `wasmAllowList: { gecko: true }` is configured, `_flutter.supportsDart2Wasm` is `true`, and `WebAssembly.validate` returns `true`, `FlutterLoader.load` rejects `dart2wasm` builds before invoking `WebAssembly.validate` (`validateCalls == 0`). 2. **Firefox 147 (`>= 147`)**: Passes the Firefox version gate and proceeds to evaluate `WebAssembly.validate` (`validateCalls > 0`). Related to flutter#143603 and flutter#186619 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a regression test in
fallbacks_test.dart(firefox-fallbackssuite) verifying theFirefox < 147version gate added in #193180 (and its precedence over_flutter.supportsDart2Wasmin #193271):< 147): Even whenwasmAllowList: { gecko: true }is configured,_flutter.supportsDart2Wasmistrue, andWebAssembly.validatereturnstrue,FlutterLoader.loadrejectsdart2wasmbuilds before invokingWebAssembly.validate(validateCalls == 0).>= 147): Passes the Firefox version gate and proceeds to evaluateWebAssembly.validate(validateCalls > 0).Related to #143603 and #186619
Pre-launch Checklist
///).