Skip to content

roll engine to 9af920ef22f311588b649ba876127993f5c1362c #19365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
amirh merged 1 commit into from
Jul 14, 2018
Merged

roll engine to 9af920ef22f311588b649ba876127993f5c1362c #19365

amirh merged 1 commit into from
Jul 14, 2018

Conversation

@amirh
Copy link
Contributor

@amirh amirh commented Jul 14, 2018

No description provided.

jonahwilliams
jonahwilliams approved these changes Jul 14, 2018
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amirh amirh merged commit 44995dc into flutter:master Jul 14, 2018
@amirh amirh deleted the roll_engine branch July 14, 2018 15:14
@amirh
Copy link
Contributor Author

amirh commented Jul 14, 2018

Reverting as Appveyor is failing after the roll with a bunch of violations of the "intrinsic protocol contract" e.g:

5:47 +1883 ~23: C:\projects\flutter sdk\packages\flutter\test\widgets\drawer_test.dart: Drawer navigator back button                                                                                  
══╡ EXCEPTION CAUGHT BY RENDERING LIBRARY ╞═════════════════════════════════════════════════════════
The following assertion was thrown during performLayout():
The intrinsic dimension methods of the RenderPadding class returned values that violate the
intrinsic protocol contract.
The following failures was detected:
 * getMinIntrinsicWidth(Infinity) returned a larger value (116.0) than
   getMaxIntrinsicWidth(Infinity) (84.0)
 * getMinIntrinsicWidth(800.0) returned a larger value (116.0) than getMaxIntrinsicWidth(800.0)
   (84.0)
If you are not writing your own RenderBox subclass, then this is not
your fault. Contact support: https://github.com/flutter/flutter/issues/new
When the exception was thrown, this was the stack:
#0      RenderBox.debugAssertDoesMeetConstraints.<anonymous closure> (package:flutter/src/rendering/box.dart:1823:11)
#1      RenderBox.debugAssertDoesMeetConstraints (package:flutter/src/rendering/box.dart:1833:6)
#2      RenderBox.size=.<anonymous closure> (package:flutter/src/rendering/box.dart:1553:17)
#3      RenderBox.size= (package:flutter/src/rendering/box.dart:1553:65)
#4      RenderPadding.performLayout (package:flutter/src/rendering/shifted_box.dart:202:5)
#5      RenderObject.layout (package:flutter/src/rendering/object.dart:1570:7)
#6      _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:109:13)
#7      RenderObject.layout (package:flutter/src/rendering/object.dart:1570:7)
#8      _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:109:13)
#9      RenderObject.layout (package:flutter/src/rendering/object.dart:1570:7)
#10     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:109:13)
#11     RenderObject.layout (package:flutter/src/rendering/object.dart:1570:7)
#12     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:109:13)
#13     RenderObject.layout (package:flutter/src/rendering/object.dart:1570:7)
#14     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:109:13)
#15     _RenderCustomClip.performLayout (package:flutter/src/rendering/proxy_box.dart:1147:11)
#16     RenderObject.layout (package:flutter/src/rendering/object.dart:1570:7)
#17     RenderConstrainedBox.performLayout (package:flutter/src/rendering/proxy_box.dart:263:13)
#18     RenderObject.layout (package:flutter/src/rendering/object.dart:1570:7)
#19     RenderPositionedBox.performLayout (package:flutter/src/rendering/shifted_box.dart:381:13)
#20     RenderObject.layout (package:flutter/src/rendering/object.dart:1570:7)
#21     RenderConstrainedBox.performLayout (package:flutter/src/rendering/proxy_box.dart:263:13)
#22     RenderObject.layout (package:flutter/src/rendering/object.dart:1570:7)
#23     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:109:13)
#24     RenderObject.layout (package:flutter/src/rendering/object.dart:1570:7)
#25     MultiChildLayoutDelegate.layoutChild (package:flutter/src/rendering/custom_layout.dart:141:11)
#26     _ScaffoldLayout.performLayout (package:flutter/src/material/scaffold.dart:338:7)
#27     MultiChildLayoutDelegate._callPerformLayout (package:flutter/src/rendering/custom_layout.dart:211:7)
#28     RenderCustomMultiChildLayoutBox.performLayout (package:flutter/src/rendering/custom_layout.dart:355:14)
#29     RenderObject.layout (package:flutter/src/rendering/object.dart:1570:7)
#30     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:109:13)
#31     RenderObject.layout (package:flutter/src/rendering/object.dart:1570:7)
#32     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:109:13)
#33     _RenderCustomClip.performLayout (package:flutter/src/rendering/proxy_box.dart:1147:11)
#34     RenderObject.layout (package:flutter/src/rendering/object.dart:1570:7)
#35     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:109:13)
#36     RenderObject.layout (package:flutter/src/rendering/object.dart:1570:7)
#37     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:109:13)
#38     RenderObject.layout (package:flutter/src/rendering/object.dart:1570:7)
#39     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:109:13)
#40     RenderObject.layout (package:flutter/src/rendering/object.dart:1570:7)
#41     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:109:13)
#42     RenderObject.layout (package:flutter/src/rendering/object.dart:1570:7)
#43     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:109:13)
#44     RenderObject.layout (package:flutter/src/rendering/object.dart:1570:7)
#45     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:109:13)
#46     RenderObject.layout (package:flutter/src/rendering/object.dart:1570:7)
#47     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:109:13)
#48     RenderObject.layout (package:flutter/src/rendering/object.dart:1570:7)
#49     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:109:13)
#50     RenderOffstage.performLayout (package:flutter/src/rendering/proxy_box.dart:2824:13)
#51     RenderObject.layout (package:flutter/src/rendering/object.dart:1570:7)
#52     RenderStack.performLayout (package:flutter/src/rendering/stack.dart:520:15)
#53     RenderObject.layout (package:flutter/src/rendering/object.dart:1570:7)
#54     __RenderTheatre&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:109:13)
#55     RenderObject.layout (package:flutter/src/rendering/object.dart:1570:7)
#56     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:109:13)
#57     RenderObject.layout (package:flutter/src/rendering/object.dart:1570:7)
#58     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:109:13)
#59     RenderObject.layout (package:flutter/src/rendering/object.dart:1570:7)
#60     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:109:13)
#61     RenderObject.layout (package:flutter/src/rendering/object.dart:1570:7)
#62     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:109:13)
#63     RenderObject.layout (package:flutter/src/rendering/object.dart:1570:7)
#64     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:109:13)
#65     RenderObject.layout (package:flutter/src/rendering/object.dart:1570:7)
#66     RenderView.performLayout (package:flutter/src/rendering/view.dart:147:13)
#67     RenderObject._layoutWithoutResize (package:flutter/src/rendering/object.dart:1445:7)
#68     PipelineOwner.flushLayout (package:flutter/src/rendering/object.dart:704:18)
#69     AutomatedTestWidgetsFlutterBinding.drawFrame (package:flutter_test/src/binding.dart:793:23)
#70     _TestWidgetsFlutterBinding&BindingBase&SchedulerBinding&GestureBinding&RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:208:5)
#71     _TestWidgetsFlutterBinding&BindingBase&SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:990:15)
#72     _TestWidgetsFlutterBinding&BindingBase&SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:930:9)
#73     AutomatedTestWidgetsFlutterBinding.pump.<anonymous closure> (package:flutter_test/src/binding.dart:704:9)
#76     TestAsyncUtils.guard (package:flutter_test/src/test_async_utils.dart:69:44)
#77     AutomatedTestWidgetsFlutterBinding.pump (package:flutter_test/src/binding.dart:691:27)
#78     WidgetTester.pumpWidget.<anonymous closure> (package:flutter_test/src/widget_tester.dart:227:22)
#81     TestAsyncUtils.guard (package:flutter_test/src/test_async_utils.dart:69:44)
#82     WidgetTester.pumpWidget (package:flutter_test/src/widget_tester.dart:224:27)
#83     main.<anonymous closure> (file:///C:/projects/flutter%20sdk/packages/flutter/test/widgets/drawer_test.dart:187:18)
#85     main.<anonymous closure> (file:///C:/projects/flutter%20sdk/packages/flutter/test/widgets/drawer_test.dart:183:47)
#86     testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart:72:23)
#87     TestWidgetsFlutterBinding._runTestBody (package:flutter_test/src/binding.dart:555:19)
#101    AutomatedTestWidgetsFlutterBinding.runTest.<anonymous closure> (package:flutter_test/src/binding.dart:899:17)
#103    AutomatedTestWidgetsFlutterBinding.runTest.<anonymous closure> (package:flutter_test/src/binding.dart:887:39)
(elided 34 frames from class _FakeAsync, package dart:async, and package stack_trace)
The following RenderObject was being processed when the exception was fired:
  RenderPadding#a4313 relayoutBoundary=up10 NEEDS-PAINT
  creator: Padding ← Container ← IconTheme ← Builder ← Listener ← _GestureSemantics ←
  RawGestureDetector ← GestureDetector ← InkWell ← DefaultTextStyle ← AnimatedDefaultTextStyle ←
  _InkFeatures-[GlobalKey#7041a ink renderer] ← ⋯
  parentData: <none> (can use size)
  constraints: BoxConstraints(88.0<=w<=800.0, 36.0<=h<=600.0)
  size: Size(116.0, 36.0)
  padding: EdgeInsets(16.0, 0.0, 16.0, 0.0)
  textDirection: ltr
This RenderObject had the following descendants (showing up to depth 5):
  RenderPositionedBox#375f1 relayoutBoundary=up11 NEEDS-PAINT
    RenderParagraph#7bb66 relayoutBoundary=up12 NEEDS-PAINT

amirh added a commit that referenced this pull request Jul 14, 2018
@amirh
Revert "roll engine to 9af920e (#19365)"
b2fe37c 
This reverts commit 44995dc.
@amirh amirh mentioned this pull request Jul 14, 2018
Merged
amirh added a commit that referenced this pull request Jul 14, 2018
@amirh
Revert "roll engine to 9af920e (#19365)" (#19376)
e7832a3 
This reverts commit 44995dc.
teriyakijack added a commit to teriyakijack/flutter that referenced this pull request Jul 17, 2018
@teriyakijack
Merge branch 'flutter_master'
7de8565 
* flutter_master: (810 commits)
  Revert engine roll to 316b026
  roll engine to 316b026 (flutter#19419)
  Revert "enable lint unnecessary_const (flutter#19342)" (flutter#19423)
  enable lint unnecessary_const (flutter#19342)
  Chevrons in month picker are semi-transparent when the month is scrolled (flutter#19363)
  Revert "Use FlutterProject to locate files  (flutter#18913)" (flutter#19409)
  Extra debug information in run_release_test (flutter#19405)
  Fix typo (flutter#19402)
  Use FlutterProject to locate files  (flutter#18913)
  Revert "roll engine to 9af920e (flutter#19365)" (flutter#19376)
  roll engine to 9af920e (flutter#19365)
  increase cache size if image is loaded that is larger than max size (flutter#19352)
  Add Bash and Zsh command-line completion for flutter (flutter#19243)
  Support keyboardAppearance field for iOS (flutter#19244)
  Add option to silence driver extension errors (flutter#19247)
  Add HeroController to CupertinoApp (flutter#19326)
  have text finder convert Text.rich to plain text for comparison (flutter#19270)
  Correct contentPadding type in InputDecoration.debugFillProperties (flutter#19318)
  Revert "Revert "Use runTests in fuchsia tester. (flutter#19178)" (flutter#19321)" (flutter#19327)
  Roll engine to c5a63d (flutter#19288)
  ...
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request Jul 19, 2018
@amirh
roll engine to 9af920e (flutter#19365)
5532952
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request Jul 19, 2018
@amirh
Revert "roll engine to 9af920e (flutter#19365)" (flutter#19376)
0729bd8 
This reverts commit 44995dc.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amirh @jonahwilliams @googlebot