Skip to content

Update Engine to test against JDK 25 - #193470

Merged
auto-submit[bot] merged 7 commits into
flutter:masterfrom
jesswrd:java-to-25-engine
Oct 5, 2026
Merged

auto-submit[bot] merged 7 commits into
flutter:masterfrom
jesswrd:java-to-25-engine

Conversation

@jesswrd

@jesswrd jesswrd commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Update Engine to test against JDK 25

Partially Addresses #193404

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Sep 28, 2026
@github-actions github-actions Bot added the engine flutter/engine related. See also e: labels. label Sep 28, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the OpenJDK dependency version from 'version:21' to 'version:25.0.2' in .ci.yaml, linux_android_emulator.json, and local_engine.json. Feedback indicates that JDK 25 is not yet released and version '25.0.2' does not exist in the CIPD repository, which will cause CI build failures during dependency resolution. It is recommended to use a valid, existing version instead.

Comment thread engine/src/flutter/.ci.yaml Resolved
@jesswrd jesswrd changed the title Update Engine to test against JDK 25 [DO NOT MERGE] Update Engine to test against JDK 25 Sep 28, 2026
@jesswrd

jesswrd commented Sep 28, 2026

Copy link
Copy Markdown
Contributor Author

Do not merge until: #193467 has merged

@jesswrd

jesswrd commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

#193467 has merged

@jesswrd jesswrd changed the title [DO NOT MERGE] Update Engine to test against JDK 25 Update Engine to test against JDK 25 Oct 2, 2026
JDK 25 javadoc reports 'reference not found' for {@link ...#shouldAttachEngineToActivity()} because the builder methods take a boolean parameter. Point the links at shouldAttachEngineToActivity(boolean).
@jesswrd
jesswrd requested a review from a team as a code owner October 2, 2026 22:29
@jesswrd
jesswrd requested review from gmackall and removed request for a team October 2, 2026 22:29
@github-actions github-actions Bot added platform-android Android applications specifically team-android Owned by Android platform team labels Oct 2, 2026
@jesswrd
jesswrd requested a review from camsim99 October 2, 2026 23:52

@camsim99 camsim99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume Gemini bot is wrong

@jesswrd jesswrd added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 5, 2026
@jesswrd

jesswrd commented Oct 5, 2026

Copy link
Copy Markdown
Contributor Author

I assume Gemini bot is wrong

yes gemini bot is wrong

@auto-submit
auto-submit Bot added this pull request to the merge queue Oct 5, 2026
Merged via the queue into flutter:master with commit 0f35e8d Oct 5, 2026
22 of 23 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 5, 2026
suryaKommana2662 pushed a commit to suryaKommana2662/flutter that referenced this pull request Oct 29, 2026
Update Engine to test against JDK 25

Partially Addresses flutter#193404

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant in-code documentation (doc comments with
`///`).
- [x] If this PR introduces a new feature or capability, I created and
linked a website documentation issue or PR in [flutter/website] (or
verified none is needed).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

If this change needs to override an active code freeze, provide a
comment explaining why. The code freeze workflow can be overridden by
code reviewers. See pinned issues for any active code freezes with
guidance.

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[AI contribution guidelines]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[flutter/website]: https://github.com/flutter/website
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD engine flutter/engine related. See also e: labels. platform-android Android applications specifically team-android Owned by Android platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants