Skip to content

[flutter_tools] Fix flutter drive -d chrome hanging on web - #193459

Merged
auto-submit[bot] merged 2 commits into
flutter:masterfrom
mdebbar:investigate_issue_192091_fix
Oct 1, 2026
Merged

auto-submit[bot] merged 2 commits into
flutter:masterfrom
mdebbar:investigate_issue_192091_fix

Conversation

@mdebbar

@mdebbar mdebbar commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

Description

When no-launch-chrome is passed in platform args (e.g. during flutter drive -d chrome, where WebDriver launches the browser instead of Flutter), ChromiumDevice.startApp does not launch Chrome. As a result, ChromiumLauncher.connectedInstance never completes.

This caused flutter drive -d chrome to hang:

  1. ResidentWebRunner.attach awaited ChromiumLauncher.connectedInstance before signaling that the app started. Because DriveCommand awaits driverService.start() before calling startTest(), WebDriver was never started and the command hung indefinitely.
  2. Even if attach was bypassed, DWDS defaulted to Chrome-based debugging for ChromiumDevice, whose connection provider also awaited connectedInstance.

This PR fixes both issues by:

  • Only waiting on connectedInstance in attach() if the tool actually launched Chromium.
  • Switching DWDS to the WebSocket debug connection when no-launch-chrome is set, matching the web-server device behavior.

Fixes #192091

Pre-launch Checklist

When `no-launch-chrome` is set (e.g. during `flutter drive` for web, where
WebDriver launches the browser), the tool does not launch a Chrome instance.
Consequently, `ChromiumLauncher.connectedInstance` never completes.

This previously caused two hangs:
1. `ResidentWebRunner.attach` waited indefinitely for the tool-launched Chrome
   instance before `DriveCommand` could proceed to `startTest()`.
2. DWDS defaulted to Chrome-based debugging for any `ChromiumDevice`, waiting
   on the same uncompleted `connectedInstance` before running `main()`.

Fix this by:
- Only waiting on `connectedInstance` in `attach()` when the tool actually
  launches Chromium (`!no-launch-chrome`).
- Falling back to DWDS WebSocket debugging when the tool does not launch
  Chromium, matching the behavior of the `web-server` device.

Fixes flutter#192091
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Sep 28, 2026
@github-actions github-actions Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 28, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates ResidentWebRunner to prevent waiting for a Chromium instance when no-launch-chrome is enabled, which is verified by new regression tests. The review feedback recommends using the conditional access operator (?.) instead of the null assertion operator (!) on flutterDevice to avoid potential runtime exceptions.

@mdebbar
mdebbar requested a review from bkonyi September 28, 2026 19:00

@bkonyi bkonyi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 1, 2026
@auto-submit
auto-submit Bot added this pull request to the merge queue Oct 1, 2026
Merged via the queue into flutter:master with commit aafc901 Oct 1, 2026
23 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 1, 2026
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Oct 1, 2026
…13104)

Manual roll requested by [email protected]

flutter/flutter@d649d2b...e89fd0a

2026-10-01 [email protected] Manual roll ICU from 6ebb40c59477 to 5aa526207171 (2 revisions) (flutter/flutter#193661)
2026-10-01 [email protected] fix(web): hash source maps before rewriting sourceMappingURL with --web-content-hash (flutter/flutter#193614)
2026-10-01 [email protected] [flutter_tools] Bootstrap DeviceManager in ToolDependencies (flutter/flutter#193524)
2026-10-01 [email protected] [wasm] Set flutter_runtime_mode in tools/gn to_gn_wasm_args (flutter/flutter#193407)
2026-10-01 [email protected] Remove remaining `download_jdk` references (flutter/flutter#193562)
2026-10-01 [email protected] Synchronize dart2wasm feature probes in roll script and flutter_bootstrap.js (flutter/flutter#193271)
2026-10-01 [email protected] [web] Unskip web tests that now pass in gestures, services, and widgets (flutter/flutter#193512)
2026-10-01 [email protected] Roll Fuchsia Test Scripts from whZAV1mfT-Rdc0rQ8... to fCNknap4ZI0AMcvIf... (flutter/flutter#193640)
2026-10-01 [email protected] Roll Skia from 0575a37d0619 to f2d68e0b8863 (2 revisions) (flutter/flutter#193621)
2026-10-01 [email protected] perf(widgets): use const <Never>{} in InheritedModelElement and avoid redundant casts in RenderObjectElement.update (flutter/flutter#192913)
2026-10-01 [email protected] [web] Unskip and strengthen missing glyph tofu test on Wimp (flutter/flutter#193426)
2026-10-01 [email protected] [flutter_tools] Fix `flutter drive -d chrome` hanging on web (flutter/flutter#193459)
2026-10-01 [email protected] [web] Fix hang when Chromium cannot bind remote debugging port (flutter/flutter#193461)
2026-10-01 [email protected] [flutter_tools] Bundle data assets from hooks in flutter test (flutter/flutter#193435)
2026-10-01 [email protected] Roll Packages from 0ba9a82 to d5ec6db (11 revisions) (flutter/flutter#193641)
2026-10-01 [email protected] Revert: [flutter_tools] Fix DTD "Stream already subscribed" error and wait for analysis over DTD in widget preview (flutter/flutter#193637)
2026-10-01 [email protected] Roll Skia from 6182a3cf8f98 to 0575a37d0619 (5 revisions) (flutter/flutter#193613)
2026-10-01 [email protected] [flutter_tools] Fix DTD "Stream already subscribed" error and wait for analysis over DTD in widget preview (flutter/flutter#192930)
2026-09-30 [email protected] [Impeller] Sample the render target rect in offscreen advanced blends (flutter/flutter#192988)
2026-09-30 [email protected] Roll Skia from 01524014dff5 to 6182a3cf8f98 (11 revisions) (flutter/flutter#193594)
2026-09-30 [email protected] [web] Use Xvfb -displayfd and clean up Xvfb after Firefox test suites (flutter/flutter#193510)
2026-09-30 [email protected] Fixes bug where sibling node fail to update size (flutter/flutter#191220)
2026-09-30 [email protected] Roll Skia from c7b323126bf0 to 01524014dff5 (3 revisions) (flutter/flutter#193577)
2026-09-30 [email protected] Remove some Undefined Behavior from run_customer_testing_tests.dart. (flutter/flutter#193582)
2026-09-30 [email protected] Fix pointer id/coordinate mismatch in Android platform view multi-touch (flutter/flutter#191631)
2026-09-30 [email protected] Roll Packages from 3c6ce59 to 0ba9a82 (11 revisions) (flutter/flutter#193578)
2026-09-30 [email protected] Fix unresolved doc comment references in dev/ tooling (flutter/flutter#193501)

If this roll has caused a breakage, revert this CL and set the roller
to dry run mode using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
suryaKommana2662 pushed a commit to suryaKommana2662/flutter that referenced this pull request Oct 29, 2026
…#193459)

## Description

When `no-launch-chrome` is passed in platform args (e.g. during `flutter
drive -d chrome`, where WebDriver launches the browser instead of
Flutter), `ChromiumDevice.startApp` does not launch Chrome. As a result,
`ChromiumLauncher.connectedInstance` never completes.

This caused `flutter drive -d chrome` to hang:
1. `ResidentWebRunner.attach` awaited
`ChromiumLauncher.connectedInstance` before signaling that the app
started. Because `DriveCommand` awaits `driverService.start()` before
calling `startTest()`, WebDriver was never started and the command hung
indefinitely.
2. Even if `attach` was bypassed, DWDS defaulted to Chrome-based
debugging for `ChromiumDevice`, whose connection provider also awaited
`connectedInstance`.

This PR fixes both issues by:
- Only waiting on `connectedInstance` in `attach()` if the tool actually
launched Chromium.
- Switching DWDS to the WebSocket debug connection when
`no-launch-chrome` is set, matching the `web-server` device behavior.

Fixes flutter#192091

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant in-code documentation (doc comments with
`///`).
- [ ] If this PR introduces a new feature or capability, I created and
linked a website documentation issue or PR in [flutter/website] (or
verified none is needed).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[AI contribution guidelines]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[flutter/website]: https://github.com/flutter/website
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[flutter_tools][web] flutter drive -d chrome hangs before WebDriver starts

2 participants