[web] Unskip 12 passing framework tests in text_test and opacity_test by harryterkelsen · Pull Request #193298 · flutter/flutter

harryterkelsen · 2026-09-24T17:49:59Z

Unskips 12 tests across 2 framework test files (packages/flutter/test/widgets/text_test.dart and packages/flutter/test/widgets/opacity_test.dart) that were previously skipped on web (skip: isBrowser) and now pass on Chrome:

packages/flutter/test/widgets/text_test.dart (11 skips removed):
- Unskips 3 semantics tests (Bidi/TextSpan recognizer link semantics and inline widget semantics) skipped for Bidi and semantics on Web #62945.
- Unskips the Overflow is clipping correctly test skipped for [web] text_test 'Overlow is clipping correctly...' test failing on web. #87878.
- Unskips 3 textWidthBasis tests (longestLine, textAlign with parent alignment, and longestLine with loose constraints) skipped for Implement textWidthBasis on the Web #44020.
- Unskips 4 WidgetSpans with no semantic information are elided from semantics tests skipped for [web] text_test semantics tests fails on web. #87877.
packages/flutter/test/widgets/opacity_test.dart (1 skip removed):
- Unskips empty opacity does not crash, skipped for Craft better error message for OffsetLayer.toImage in the HTML renderer #49857 (HTML renderer OffsetLayer.toImage, closed).

The only non-trivial diff is dart format reflowing the textWidthBasis.longestLine confines the width of the paragraph test after its trailing skip: argument was removed; the test body is unchanged.

Related issues:

Pre-launch Checklist

Removes `skip: isBrowser` from 12 tests that now pass on Chrome: - `packages/flutter/test/widgets/text_test.dart` (11 tests): Bidi/link semantics (flutter#62945), ellipsis clipping (flutter#87878), `textWidthBasis` (flutter#44020), and `WidgetSpan` semantics elision (flutter#87877). - `packages/flutter/test/widgets/opacity_test.dart` (1 test): `empty opacity does not crash` (flutter#49857, `OffsetLayer.toImage` is now supported on web).

gemini-code-assist

Code Review

This pull request removes the skip: isBrowser parameter from several tests in opacity_test.dart and text_test.dart, enabling them to run in browser environments. The reviewer feedback recommends removing the obsolete comments that reference the tracking issues for these skipped tests to maintain code cleanliness.

gemini-code-assist · 2026-09-24T17:51:04Z

    final ui.Image image = await offsetLayer.toImage(const Rect.fromLTRB(0.0, 0.0, 1.0, 1.0));
    image.dispose();
-  }, skip: isBrowser); // https://github.com/flutter/flutter/issues/49857
+  }); // https://github.com/flutter/flutter/issues/49857


Since this test is no longer skipped, the comment linking to the issue that tracked the skip is obsolete and should be removed to keep the codebase clean and maintainable.

});

References

Optimize for readability: Code is read more often than it is written. ^(link)

Documentation should be useful: Explain the why and the how. ^(link)

gemini-code-assist · 2026-09-24T17:51:04Z

    expect(semantics, hasSemantics(expectedSemantics, ignoreTransform: true, ignoreId: true));
    semantics.dispose();
-  }, skip: isBrowser); // https://github.com/flutter/flutter/issues/62945
+  }); // https://github.com/flutter/flutter/issues/62945


Since this test is no longer skipped, the comment linking to the issue that tracked the skip is obsolete and should be removed to keep the codebase clean and maintainable.

Suggested change

}); // https://github.com/flutter/flutter/issues/62945

});

References

Optimize for readability: Code is read more often than it is written. ^(link)

Documentation should be useful: Explain the why and the how. ^(link)

gemini-code-assist · 2026-09-24T17:51:05Z

    );
    semantics.dispose();
-  }, skip: isBrowser); // https://github.com/flutter/flutter/issues/62945
+  }); // https://github.com/flutter/flutter/issues/62945


Since this test is no longer skipped, the comment linking to the issue that tracked the skip is obsolete and should be removed to keep the codebase clean and maintainable.

Suggested change

}); // https://github.com/flutter/flutter/issues/62945

});

References

Optimize for readability: Code is read more often than it is written. ^(link)

Documentation should be useful: Explain the why and the how. ^(link)

gemini-code-assist · 2026-09-24T17:51:05Z

    expect(semantics, hasSemantics(expectedSemantics, ignoreTransform: true, ignoreId: true));
    semantics.dispose();
-  }, skip: isBrowser); // https://github.com/flutter/flutter/issues/62945
+  }); // https://github.com/flutter/flutter/issues/62945


Since this test is no longer skipped, the comment linking to the issue that tracked the skip is obsolete and should be removed to keep the codebase clean and maintainable.

Suggested change

}); // https://github.com/flutter/flutter/issues/62945

});

References

Optimize for readability: Code is read more often than it is written. ^(link)

Documentation should be useful: Explain the why and the how. ^(link)

gemini-code-assist · 2026-09-24T17:51:05Z


    expect(find.byType(Text), paints..clipRect(rect: const Rect.fromLTWH(0, 0, 50, 50)));
-  }, skip: isBrowser); // https://github.com/flutter/flutter/issues/87878
+  }); // https://github.com/flutter/flutter/issues/87878


Since this test is no longer skipped, the comment linking to the issue that tracked the skip is obsolete and should be removed to keep the codebase clean and maintainable.

Suggested change

}); // https://github.com/flutter/flutter/issues/87878

});

References

Optimize for readability: Code is read more often than it is written. ^(link)

Documentation should be useful: Explain the why and the how. ^(link)

gemini-code-assist · 2026-09-24T17:51:05Z

    expect(tester.getSize(find.text('LEFT ALIGNED, LONGEST LINE')).width, lessThan(width));
    expect(tester.getSize(find.text('RIGHT ALIGNED, LONGEST LINE')).width, equals(width));
-  }, skip: isBrowser); // https://github.com/flutter/flutter/issues/44020
+  }); // https://github.com/flutter/flutter/issues/44020


Since this test is no longer skipped, the comment linking to the issue that tracked the skip is obsolete and should be removed to keep the codebase clean and maintainable.

Suggested change

}); // https://github.com/flutter/flutter/issues/44020

});

References

Optimize for readability: Code is read more often than it is written. ^(link)

Documentation should be useful: Explain the why and the how. ^(link)

gemini-code-assist · 2026-09-24T17:51:05Z

    );
    semantics.dispose();
-  }, skip: isBrowser); // https://github.com/flutter/flutter/issues/87877
+  }); // https://github.com/flutter/flutter/issues/87877


Since this test is no longer skipped, the comment linking to the issue that tracked the skip is obsolete and should be removed to keep the codebase clean and maintainable.

Suggested change

}); // https://github.com/flutter/flutter/issues/87877

});

References

Optimize for readability: Code is read more often than it is written. ^(link)

Documentation should be useful: Explain the why and the how. ^(link)

gemini-code-assist · 2026-09-24T17:51:05Z

    );
    semantics.dispose();
-  }, skip: isBrowser); // https://github.com/flutter/flutter/issues/87877
+  }); // https://github.com/flutter/flutter/issues/87877


Since this test is no longer skipped, the comment linking to the issue that tracked the skip is obsolete and should be removed to keep the codebase clean and maintainable.

Suggested change

}); // https://github.com/flutter/flutter/issues/87877

});

References

Optimize for readability: Code is read more often than it is written. ^(link)

Documentation should be useful: Explain the why and the how. ^(link)

gemini-code-assist · 2026-09-24T17:51:05Z

    );
    semantics.dispose();
-  }, skip: isBrowser); // https://github.com/flutter/flutter/issues/87877
+  }); // https://github.com/flutter/flutter/issues/87877


Since this test is no longer skipped, the comment linking to the issue that tracked the skip is obsolete and should be removed to keep the codebase clean and maintainable.

Suggested change

}); // https://github.com/flutter/flutter/issues/87877

});

References

Optimize for readability: Code is read more often than it is written. ^(link)

Documentation should be useful: Explain the why and the how. ^(link)

gemini-code-assist · 2026-09-24T17:51:05Z

    );
    semantics.dispose();
-  }, skip: isBrowser); // https://github.com/flutter/flutter/issues/87877
+  }); // https://github.com/flutter/flutter/issues/87877


Since this test is no longer skipped, the comment linking to the issue that tracked the skip is obsolete and should be removed to keep the codebase clean and maintainable.

Suggested change

}); // https://github.com/flutter/flutter/issues/87877

});

References

Optimize for readability: Code is read more often than it is written. ^(link)

Documentation should be useful: Explain the why and the how. ^(link)

flutter-dashboard Bot added the CICD Run CI/CD label Sep 24, 2026

gemini-code-assist Bot reviewed Sep 24, 2026

View reviewed changes

Remove stale skip-reason comments from unskipped tests

d16661e

harryterkelsen requested a review from mdebbar September 24, 2026 17:55

github-actions Bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Sep 24, 2026

mdebbar approved these changes Sep 24, 2026

View reviewed changes

harryterkelsen added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 24, 2026

auto-submit Bot added this pull request to the merge queue Sep 24, 2026

Merged via the queue into flutter:master with commit b57256e Sep 24, 2026
23 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 24, 2026

Navigation Menu

Repository navigation

[web] Unskip 12 passing framework tests in text_test and opacity_test - #193298

[web] Unskip 12 passing framework tests in text_test and opacity_test#193298
auto-submit[bot] merged 2 commits into
flutter:masterfrom
harryterkelsen:unskip-web-tests-batch-3

harryterkelsen commented Sep 24, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Sep 24, 2026

Uh oh!

gemini-code-assist Bot Sep 24, 2026

Uh oh!

gemini-code-assist Bot Sep 24, 2026

Uh oh!

gemini-code-assist Bot Sep 24, 2026

Uh oh!

gemini-code-assist Bot Sep 24, 2026

Uh oh!

gemini-code-assist Bot Sep 24, 2026

Uh oh!

gemini-code-assist Bot Sep 24, 2026

Uh oh!

gemini-code-assist Bot Sep 24, 2026

Uh oh!

gemini-code-assist Bot Sep 24, 2026

Uh oh!

gemini-code-assist Bot Sep 24, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	}); // https://github.com/flutter/flutter/issues/62945
	});

Conversation

harryterkelsen commented Sep 24, 2026

Pre-launch Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Sep 24, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Sep 24, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Sep 24, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Sep 24, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Sep 24, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Sep 24, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Sep 24, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Sep 24, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Sep 24, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Sep 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants