Repository navigation
[web] Report skwasm WebGL context creation failure instead of hanging - #193293
Merged
Merged
Conversation
When skwasm fails to create a WebGL2 context for its OffscreenCanvas, `Surface::ReceiveCanvasOnWorker` printed "Failed to create context!" and returned without ever reporting back to the main thread. On the Dart side `SkwasmSurface.initialized` never completed, so every frame awaited it forever: nothing was rendered, platform views mounted after the first frame were never injected into the DOM, and no error was surfaced. - Thread a `success` flag through `skwasm_reportInitialized` / `surface_onInitialized`; on failure the callback context is 0 (valid context-lost callback ids are always non-zero). - In `SkwasmSurface._initialize`, treat 0 as failure: log a `console.error` and complete `initialized` with a `StateError` so rendering fails fast and visibly. - Add a regression test that forces WebGL context creation to fail by handing skwasm a canvas that already has a 2D context. Fixes flutter#193223
Transferring an OffscreenCanvas that already has a 2d rendering context to the raster worker via postMessage throws InvalidStateError, so the NoWebGLOffscreenCanvasProvider trick only works single-threaded. The chrome-force-st-dart2wasm-skwasm-ui suite still exercises the ReceiveCanvasOnWorker -> OnInitialized failure path.
kevmoo
marked this pull request as ready for review
September 25, 2026 18:01
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Skwasm surface initialization to handle WebGL context creation failures. Instead of waiting indefinitely when WebGL context creation fails, the C++ surface implementation now reports the failure back to the Dart side, which completes the initialization completer with a StateError and logs an error message. A regression test has been added to verify this behavior using a mock canvas provider that fails WebGL context creation. There are no review comments, and I have no feedback to provide.
- Track `_initializationFailed` so `initialized` surfaces the `StateError` once and subsequent `rasterizeToImageBitmaps` / `setSize` calls return early. - Drop the duplicate `console.error` call before completing `initialized` with `StateError`. - Catch errors from `recreateContextForCanvas` in `onContextLost` and add a single-threaded test for post-context-loss recreation failure. - Return `0` early from `_skwasm_getGlContextForCanvas` when `GL.createContext` fails. - Dispose test surfaces with `addTearDown(surface.dispose)`.
harryterkelsen
approved these changes
Nov 10, 2026
Contributor
Author
|
Merged |
harryterkelsen
approved these changes
Nov 10, 2026
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Nov 11, 2026
flutter/flutter@fffd8c2...b98afb5 2026-11-11 [email protected] Roll Dart SDK from 172cf8f121c0 to 8f15c4ca2d41 (1 revision) (flutter/flutter#196367) 2026-11-11 [email protected] Roll Skia from 657283e78115 to cc4c54f752ba (5 revisions) (flutter/flutter#196365) 2026-11-11 [email protected] Roll Skia from 2605c4a9761c to 657283e78115 (1 revision) (flutter/flutter#196358) 2026-11-11 [email protected] Roll Dart SDK from 890c6d15334c to 172cf8f121c0 (1 revision) (flutter/flutter#196352) 2026-11-11 [email protected] [flutter_tools] Migrate general.shard project, runner, and web tests off globals (flutter/flutter#196128) 2026-11-11 [email protected] [flutter_tools] Migrate test helpers and integration tests off globals (flutter/flutter#196124) 2026-11-11 [email protected] [web] Report skwasm WebGL context creation failure instead of hanging (flutter/flutter#193293) 2026-11-11 [email protected] [flutter_tools] Migrate commands.shard tests off globals (flutter/flutter#196139) 2026-11-11 [email protected] [devicelab] Fix memory benchmark tap synchronization and swipe flakes (flutter/flutter#194457) 2026-11-11 [email protected] Roll Skia from 06062e36d938 to 2605c4a9761c (2 revisions) (flutter/flutter#196350) 2026-11-11 [email protected] Do not wait again for a closed mock event stream in tear down (flutter/flutter#196110) 2026-11-11 [email protected] [gen_l10n] Add `use-explicit-plural-values` option (flutter/flutter#194816) 2026-11-11 [email protected] Roll Skia from 7bd33f8a3b70 to 06062e36d938 (2 revisions) (flutter/flutter#196340) 2026-11-11 [email protected] Skip redundant work in plugin_test_* (flutter/flutter#196258) 2026-11-10 [email protected] Drop test_timeout_secs from shards that no longer need it (flutter/flutter#196277) 2026-11-10 [email protected] Roll Dart SDK from 15c1699d3eeb to 890c6d15334c (1 revision) (flutter/flutter#196321) 2026-11-10 [email protected] iOS: Extract FlutterPlatformViewsController platform-thread state to Obj-C (flutter/flutter#196142) 2026-11-10 [email protected] Remove `Mac web_tool_tests` and take new subshard builders out of bringup (flutter/flutter#196276) 2026-11-10 [email protected] Roll Skia from 9c3d43d8a04b to 7bd33f8a3b70 (12 revisions) (flutter/flutter#196317) 2026-11-10 [email protected] Take customer_testing_devtools out of bringup (flutter/flutter#196239) 2026-11-10 [email protected] Roll ICU from a0ea93436c52 to b09986242cfb (1 revision) (flutter/flutter#196316) 2026-11-10 [email protected] [flutter_tools] Avoid unlinking native_assets.json and handle EXDEV (flutter/flutter#196134) 2026-11-10 [email protected] Remove old `Windows tool_integration_tests` builders and take the new shards out of bringup (flutter/flutter#196275) 2026-11-10 [email protected] [SwiftPM] Disable tests for when settings fail to compile (flutter/flutter#196310) 2026-11-10 [email protected] Roll Fuchsia Test Scripts from PXc5D7S_q6sIYpfFJ... to oEU515sDqSTvD8Spx... (flutter/flutter#196289) 2026-11-10 [email protected] Fix ime insets animation jump (flutter/flutter#191453) 2026-11-10 [email protected] Link to original PR in automatic cherry-pick PRs (flutter/flutter#196130) 2026-11-10 [email protected] Roll Packages from 565c657 to 08faf64 (9 revisions) (flutter/flutter#196296) 2026-11-10 [email protected] Roll Skia from b11315d0a096 to 9c3d43d8a04b (45 revisions) (flutter/flutter#196295) 2026-11-10 [email protected] Replace type-specific window widgets with a single Window widget (flutter/flutter#196002) 2026-11-10 [email protected] Roll Dart SDK from a2baae273bb2 to 15c1699d3eeb (2 revisions) (flutter/flutter#196294) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Scope: This fixes the headless / GPU-flags variant of #193223, where skwasm cannot create a WebGL2 context and then hangs silently. The reporter later confirmed that their production symptom (platform view never attached, no errors) was caused by
if (dart.library.js_util)conditional imports resolving to stubs under--wasm, and closed #193223. This PR turns the silent skwasm WebGL2 context failure uncovered by the issue's headless repro into a visible error. It does not make rendering work without WebGL2.When skwasm fails to create a WebGL2 context on the worker (e.g. Chrome launched with
--use-gl=angle --use-angle=gl --enable-gpu-rasterization --ignore-gpu-blocklistin some environments),Surface::ReceiveCanvasOnWorkerprintedFailed to create context!and returned without callingskwasm_reportInitialized. As a result:SkwasmSurface._initializedCompleternever completed.setSize/rasterizeToImageBitmapsawaitedinitializedforever, wedging the render loop (later scenes only overwriterenderQueue.next).Before #179473 this path crashed loudly (#173401); since then it hangs silently.
Fix
skwasm_reportInitialized/surface_onInitializedgain asuccessflag. The failure path now reports initialization withsuccess = false, andOnInitializedpasses0(never a valid callback id, since ids start at ≥ 1 and the context-lost id is always ≥ 2) instead of the context-lost callback id._skwasm_getGlContextForCanvasalso returns0early whenGL.createContextfails so it does not store key0inhandleToCanvasMapor attach awebglcontextlostlistener.SkwasmSurface._initializetreats a0id as failure, sets_initializationFailed = true, and completesinitializedwith aStateErrordescribing the WebGL2 failure instead of hanging. SubsequentrasterizeToImageBitmapsandsetSizecalls return early once_initializationFailedis set so later frames fail quietly rather than rethrowing on every frame, andonContextLostcatches errors fromrecreateContextForCanvasso post-crash context recreation failures do not escape as duplicate unhandled async errors.test/ui/surface_context_lost_test.dartcovering both initial WebGL context creation failure and context recreation failure after context loss.Verification
Failed to create context!in console, later-mountedflt-platform-viewnever attached. Default flags /--disable-gpuunaffected.felt test --gcs-prod --suite chrome-force-st-dart2wasm-skwasm-ui test/ui/surface_context_lost_test.dart:TimeoutException(the hang); existing 4 pass.skwasm.jsglue patched to emulate this C++ change: 5/5 pass.Bad state: Skwasm failed to create a WebGL2 context…error instead of silent hang; no regression with default flags.Note
I did not compile the C++/JS locally (no emsdk/gclient sync), so CI is the first real build of the skwasm and wimp (shares
surface.cc) changes.Related to #193223 (partial: headless/GPU-flags variant only; intentionally not
Fixes, so merging won't close the issue)Pre-launch Checklist
///).