[web] Preserve active autofill form across text input configuration updates by simonpham · Pull Request #193269 · flutter/flutter

simonpham · 2026-09-24T04:37:16Z

Fixes #192102
Fixes #193267

Problem

Toggling TextField.obscureText on Web sends TextInput.updateConfig, which decodes a new EngineAutofillForm lacking an associated DOM form (formElement == null).

On blur (TextInput.clearClient), the web engine bypasses dormancy and tears down the active DOM input element. Refocusing the field leaves it unresponsive to keyboard events.

Solution

Preserve the active EngineAutofillForm across TextInput.updateConfig in DefaultTextEditingStrategy.applyConfiguration. This retains live DOM ownership so the form goes dormant on blur and wakes up cleanly on refocus.

Testing

Added engine unit tests in text_editing_test.dart for multi-field and single-field autofill forms, verifying dormancy and refocus reusability.

Issue	Result
#192102: plain password field	Screen.Recording.2026-09-24.at.15.42.06.mov
#193267: password field with autofill hints	Screen.Recording.2026-09-24.at.15.42.42.mov

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

gemini-code-assist

Code Review

This pull request updates the web text editing engine to preserve and reuse the active autofill form during configuration updates instead of replacing the DOM form. This is achieved by introducing updateFrameworkConfiguration on EngineAutofillForm and updating applyConfiguration in DefaultTextEditingStrategy to reuse the existing autofill group when identity properties match. Corresponding tests were added to verify this behavior. The review feedback suggests refactoring the duplicated identity checks into a helper method hasSameIdentity on EngineAutofillForm to improve maintainability.

gemini-code-assist

Code Review

This pull request modifies EditableTextState to schedule a text input connection restart on web when obscureTextChanged is true, instead of updating the configuration. It also updates the corresponding tests in editable_text_test.dart to verify this behavior specifically on web while skipping the standard configuration update test on web. I have no feedback to provide.

justinmc

LGTM 👍 . I tried this on my Mac using a composing Chinese Pinyin keyboard and I couldn't seem to find cause any bugs. Tapping to change obscureText while in the middle of composing just commits the text as-is, without converting to Chinese characters. This seems to be the same before before and after this PR.

Renzo-Olivares

Thanks for digging into this @simonpham!

I think the fix belongs in the web engine rather than in EditableText. The root cause is that #182024 made the autofill <form> lazily created and reused across connections, but TextInput.updateConfig still decodes a brand new EngineAutofillForm with no DOM form and swaps it in for the live one. On the next blur, disable() sees formElement == null and removes the <input> instead of letting the form go dormant. If the form went dormant earlier, wakeUp then calls replaceWith on a detached element, so the new <input> never makes it into the DOM.

Because of that, restarting the connection for obscureText only covers one of the callers. I tried this branch in Chrome and the same dead field still reproduces when keyboardType or readOnly changes while the field is focused (focus, blur, focus, change the property, blur, focus, type). The viewId change and any third-party TextInputClient that calls TextInputConnection.updateConfig go through the same path.

Renzo-Olivares · 2026-10-01T19:31:07Z

fyi @mdebbar @flutter-zl if y'all had any thoughts on the web diagnosis #193269 (review)

simonpham · 2026-10-02T00:09:42Z

Thanks for digging into this @simonpham!

I think the fix belongs in the web engine rather than in EditableText. The root cause is that #182024 made the autofill <form> lazily created and reused across connections, but TextInput.updateConfig still decodes a brand new EngineAutofillForm with no DOM form and swaps it in for the live one. On the next blur, disable() sees formElement == null and removes the <input> instead of letting the form go dormant. If the form went dormant earlier, wakeUp then calls replaceWith on a detached element, so the new <input> never makes it into the DOM.

Because of that, restarting the connection for obscureText only covers one of the callers. I tried this branch in Chrome and the same dead field still reproduces when keyboardType or readOnly changes while the field is focused (focus, blur, focus, change the property, blur, focus, type). The viewId change and any third-party TextInputClient that calls TextInputConnection.updateConfig go through the same path.

Thanks for this insight. ~~But your suggestion was my initial attempt to fix and it did not work. You can see the first commit of this PR (which later I force-pushed the right fix in the framework).~~
nevermind. Let me test with your suggested fix later and let you know.

mdebbar · 2026-10-02T19:37:37Z

+1 I agree with @Renzo-Olivares's assessment to fixing this in the engine.

Renzo-Olivares

LGTM, google testing failures need a rebase to fully verify. Analyzer failures seem unrelated.

…updateConfig

…pdates When TextInput.updateConfig arrives while an autofill form is active, the newly decoded EngineAutofillForm has no associated DOM form. Preserve the active form so that on blur/disable the form goes dormant and remains reusable rather than incorrectly removing the live element. Fixes flutter#192102

SemanticsTextEditingStrategy never sets _appendedToForm, so the check skipped preserving the active autofill form in semantics mode. Rely on the active group's formElement alone.

…nfig

Resolves the conflicts with flutter#187108, flutter#190942 and flutter#193269, and reformats the change for the Dart 3.13 formatter from flutter#192649.

…pdates (flutter#193269) Fixes flutter#192102 Fixes flutter#193267 ### Problem Toggling `TextField.obscureText` on Web sends `TextInput.updateConfig`, which decodes a new `EngineAutofillForm` lacking an associated DOM form (`formElement == null`). On blur (`TextInput.clearClient`), the web engine bypasses dormancy and tears down the active DOM input element. Refocusing the field leaves it unresponsive to keyboard events. ### Solution Preserve the active `EngineAutofillForm` across `TextInput.updateConfig` in `DefaultTextEditingStrategy.applyConfiguration`. This retains live DOM ownership so the form goes dormant on blur and wakes up cleanly on refocus. ### Testing Added engine unit tests in `text_editing_test.dart` for multi-field and single-field autofill forms, verifying dormancy and refocus reusability. | Issue | Result | | - | - | | flutter#192102: plain password field | https://github.com/user-attachments/assets/a8c98c15-7dbe-4d91-bf32-bbe90bfffc08 | | flutter#193267: password field with autofill hints | https://github.com/user-attachments/assets/7c57998f-4e80-42bc-bc3c-b7bdc49f27db | ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing.

github-actions Bot added a: text input Entering text in a text field or keyboard related problems engine flutter/engine related. See also e: labels. platform-web Web applications specifically team-web Owned by Web platform team labels Sep 24, 2026

gemini-code-assist Bot reviewed Sep 24, 2026

View reviewed changes

Comment thread engine/src/flutter/lib/web_ui/lib/src/engine/text_editing/text_editing.dart Resolved

Comment thread engine/src/flutter/lib/web_ui/lib/src/engine/text_editing/text_editing.dart Resolved

simonpham force-pushed the master branch from 92c32c8 to c9c0114 Compare September 24, 2026 04:46

simonpham changed the title ~~[web] Preserve autofill form across TextInput.updateConfig~~ draft: [web] Preserve autofill form across TextInput.updateConfig Sep 24, 2026

simonpham marked this pull request as draft September 24, 2026 08:21

simonpham changed the title ~~draft: [web] Preserve autofill form across TextInput.updateConfig~~ draft: [web] Restart text input connection when obscureText changes Sep 24, 2026

simonpham force-pushed the master branch from c9c0114 to 922ccd5 Compare September 24, 2026 08:41

github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. and removed engine flutter/engine related. See also e: labels. platform-web Web applications specifically team-web Owned by Web platform team labels Sep 24, 2026

simonpham changed the title ~~draft: [web] Restart text input connection when obscureText changes~~ [web] Restart text input connection when obscureText changes Sep 24, 2026

simonpham marked this pull request as ready for review September 24, 2026 08:59

simonpham force-pushed the master branch from db3f6f6 to 42bf829 Compare September 24, 2026 09:02

gemini-code-assist Bot reviewed Sep 24, 2026

View reviewed changes

justinmc requested review from Renzo-Olivares and justinmc September 24, 2026 20:46

justinmc added the CICD Run CI/CD label Sep 24, 2026

justinmc previously approved these changes Sep 24, 2026

View reviewed changes

Renzo-Olivares reviewed Oct 1, 2026

View reviewed changes

Comment thread packages/flutter/lib/src/widgets/editable_text.dart Resolved

Renzo-Olivares added the waiting for response The Flutter team cannot make further progress on this issue until the original reporter responds label Oct 1, 2026

github-actions Bot removed the waiting for response The Flutter team cannot make further progress on this issue until the original reporter responds label Oct 2, 2026

simonpham dismissed justinmc’s stale review via ae47399 October 5, 2026 03:21

simonpham force-pushed the master branch from 42bf829 to ae47399 Compare October 5, 2026 03:21

mdebbar added the CICD Run CI/CD label Oct 8, 2026

mdebbar requested a review from Renzo-Olivares October 8, 2026 15:10

Renzo-Olivares approved these changes Oct 8, 2026

View reviewed changes

simonpham added 5 commits October 8, 2026 11:20

[web] Add tests for preserving active autofill form across TextInput.…

f269da6

…updateConfig

[web] Preserve active autofill form in semantics mode on updateConfig

47b49ef

SemanticsTextEditingStrategy never sets _appendedToForm, so the check skipped preserving the active autofill form in semantics mode. Rely on the active group's formElement alone.

[web] Use same() matcher in updateConfig autofill form test

4972757

[web] Add semantics test for preserving autofill form across updateCo…

faa872a

…nfig

Renzo-Olivares added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 8, 2026

Renzo-Olivares force-pushed the master branch from 62f0c68 to faa872a Compare October 8, 2026 18:20

flutter-dashboard Bot removed the CICD Run CI/CD label Oct 8, 2026

Renzo-Olivares added the CICD Run CI/CD label Oct 8, 2026

auto-submit Bot added this pull request to the merge queue Oct 8, 2026

Merged via the queue into flutter:master with commit 4c15b12 Oct 8, 2026
24 of 25 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 8, 2026

diegolopezrm mentioned this pull request Oct 9, 2026

[web] Stop placeElement() from dereferencing an element a blur already removed #194057

Draft

10 tasks done

Navigation Menu

Repository navigation

[web] Preserve active autofill form across text input configuration updates - #193269

[web] Preserve active autofill form across text input configuration updates#193269
auto-submit[bot] merged 5 commits into
flutter:masterfrom
simonpham:master

simonpham commented Sep 24, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

justinmc left a comment

Uh oh!

Renzo-Olivares left a comment

Uh oh!

Uh oh!

Renzo-Olivares commented Oct 1, 2026

Uh oh!

simonpham commented Oct 2, 2026 •

edited

Loading

Uh oh!

mdebbar commented Oct 2, 2026

Uh oh!

Renzo-Olivares left a comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

simonpham commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Solution

Testing

Pre-launch Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Renzo-Olivares left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Renzo-Olivares commented Oct 1, 2026

Uh oh!

simonpham commented Oct 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mdebbar commented Oct 2, 2026

Uh oh!

Renzo-Olivares left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

simonpham commented Sep 24, 2026 •

edited

Loading

simonpham commented Oct 2, 2026 •

edited

Loading