Repository navigation
remove compile benchmarks from bringup - #193249
Merged
auto-submit[bot] merged 1 commit intoSep 24, 2026
Merged
Conversation
okorohelijah
marked this pull request as ready for review
September 23, 2026 22:18
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the bringup: true property from several Mac benchmark targets in .ci.yaml, including Mac_benchmark basic_material_app_ios__compile, Mac_benchmark flutter_gallery_ios__compile, Mac_benchmark hello_world_ios__compile, and Mac_benchmark imitation_game_flutter. There are no review comments, and I have no feedback to provide.
jtmcdole
approved these changes
Sep 23, 2026
jtmcdole
left a comment
jtmcdole
left a comment
Member
There was a problem hiding this comment.
💵 The CodeFu LGTM Note
The LGTM exchange rates are currently trading at:
- 1 LGTM = golden images match closely enough if I squint.
- 2 LGTMs = I checked that this won't break the devicelab benchmarks
- 3 LGTMs = I trust that this C++ pointer won't leak memory every frame.
- 4 LGTMs = CI is green on the first try without a single retry or shard failure
💵 Value officially backed by the full faith, credit, and compute budget of the Flutter EngProd Infrastructure.
okorohelijah
added
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
This was referenced Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove compile benchmarks from bringup
Part of #192472
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.