Repository navigation
[web] Unskip 6 passing framework tests in proxy_box_test and editable_text_test - #193237
Merged
auto-submit[bot] merged 3 commits intoSep 24, 2026
Merged
Conversation
…ble_text_test` Unskips 6 tests across 2 framework test files (`packages/flutter/test/rendering/proxy_box_test.dart` and `packages/flutter/test/widgets/editable_text_test.dart`) that were previously skipped on web (`skip: isBrowser` / `skip: kIsWeb`) and now pass on Chrome: - `test/rendering/proxy_box_test.dart`: - Unskips 2 `RenderRepaintBoundary` async/sync image capture tests (`toImage` / `toImageSync`) previously skipped for the deleted HTML renderer (flutter#49857, closed). - Unskips 3 composited layer replacement and offset assertion check tests (flutter#102086). - `test/widgets/editable_text_test.dart`: - Unskips 1 RTL cursor position test (flutter#78550, closed).
github-actions
Bot
added
a: text input
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes browser-skipping parameters (skip: isBrowser and skip: kIsWeb) from several tests in proxy_box_test.dart and editable_text_test.dart. Feedback points out that during these changes, two assertions verifying pixel values at image.width - 1, 20 were accidentally deleted in proxy_box_test.dart, and recommends restoring them to maintain test coverage.
Restores `expect(getPixel(image.width - 1, 20), equals(0xffffffff));` in both `RenderRepaintBoundary` image capture tests (`RenderRepaintBoundary can capture images of itself` and `RenderRepaintBoundary can capture images of itself synchronously`).
mdebbar
approved these changes
Sep 24, 2026
harryterkelsen
added
the
autosubmit
|
________________________________
De: Mouad Debbar ***@***.***>
Enviado: jueves, 24 de septiembre de 2026 16:28
Para: flutter/flutter ***@***.***>
Cc: Subscribed ***@***.***>
Asunto: Re: [flutter/flutter] [web] Unskip 6 passing framework tests in proxy_box_test and editable_text_test (PR #193237)
@mdebbar approved this pull request.
—
Reply to this email directly, view it on GitHub<#193237?email_source=notifications&email_token=AADSPMG3TCBB2CG22SEJQKT5QUVRHA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMZQGU4DANZTGQZ2M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSWGM33PORSXEX3DNRUWG2Y#pullrequestreview-5305807343>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AADSPMGY6OTCVBHP2UALF535QUVRHAVCNFSNUABEKJSXA33TNF2G64TZHMZTCNZZGI4DENB3JFZXG5LFHM2TKNJYGY4DEOJTG6QXMAQ>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
flutter-dashboard
Bot
removed
the
autosubmit
This was referenced Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unskips 6 tests across 2 framework test files (
packages/flutter/test/rendering/proxy_box_test.dartandpackages/flutter/test/widgets/editable_text_test.dart) that were previously skipped on web (skip: isBrowser/skip: kIsWeb) due to issues that have since been resolved:packages/flutter/test/rendering/proxy_box_test.dart(5 skips removed):RenderRepaintBoundaryimage capture tests (RenderRepaintBoundary can capture images of itselfandRenderRepaintBoundary can capture images of itself synchronously) that were skipped for Craft better error message for OffsetLayer.toImage in the HTML renderer #49857 (HTML rendererOffsetLayer.toImage, closed).RenderObject with repaint boundary asserts when a composited layer is replaced during layer property update,... during painting, and... tries to update its own offset) that were skipped for Tests of assertion errors seem to behave differently on the web #102086 and now pass on Chrome.packages/flutter/test/widgets/editable_text_test.dart(1 skip removed):Cursor position is updated on RTL) that was skipped for [web][CanvasKit] TextField with TextDirection.rtl has misplaced cursor #78550 (closed).Related issues:
Pre-launch Checklist
///).