Repository navigation
[win32] Fix PopupWindowControllerWin32 message handling - #193233
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
github-actions
Bot
added
the
framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the handling of the _WM_SIZE message and moves the _WM_DESTROY message handling block within PopupWindowControllerWin32.handleMessage. The review feedback points out a critical regression: moving the _WM_DESTROY block below the _destroyed check prevents the engine's destroy message from being processed when the window is already marked as destroyed, which causes resource leaks. It is recommended to keep the _WM_DESTROY handling at the top of the method while adding a view ID check, and to remove the duplicate block at the end of the method.
mattkae
left a comment
mattkae
left a comment
There was a problem hiding this comment.
That sounds more right to me!
mattkae
added
the
autosubmit
auto-submit
Bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/flutter/193233, because - The status or check suite ci.yaml validation has failed. Please fix the issues identified (or deflake) before re-applying this label. |
f5bd7ca to
12bbcbc
Compare
mattkae
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.