Reland "Roll engine to fed2ea458ed49088d33eddabc546ba56d600c717 (includes dart roll) again" #19322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utter#19277)" (flutter#19295)" This reverts commit cc122f1.
aam
changed the title
zanderso
approved these changes
Jul 12, 2018
Contributor
|
IMHO we should revert this. It caused serious regressions to |
Contributor
|
I believe this also breaks the debugger, see #19379. |
Member
Author
|
See #19340 |
Contributor
|
I can still reproduce the crash with that commit patched into master |
Contributor
|
I made a mistake when rebuilding that patch - confirmed that it does fix the issue. |
This was referenced Jul 16, 2018
Closed
Contributor
|
I'm seeing some new crashes on Mine is the same steps as #17838 but instead of pausing unexpected on the will-be-caught exception, it terminates and I just get |
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
Jul 19, 2018
…utter#19277)" (flutter#19295)" (flutter#19322) This reverts commit cc122f1.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relands #19277 .
This reverts commit cc122f1 as we found culprit for hot mode test failures, which is believed to be fixed with b075229