Repository navigation
[win32] Multi-window should never have implicit view - #193174
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces an allow_implicit_view parameter to FlutterWindowsEngine::CreateView to control whether the implicit view ID is allowed when creating a view, updating various platform files and unit tests accordingly. The review feedback points out a style guide violation in host_window.cc regarding the spacing in the inline parameter comment /* allow_implicit_view=*/false and suggests formatting it as /*allow_implicit_view=*/false.
github-actions
Bot
added
engine
knopp
force-pushed
the
windows_view_id
branch
from
September 23, 2026 10:07
7476d70 to
edd61ad
Compare
mattkae
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
This was referenced Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now the first window of a multi-window application on win32 will have
view_id= 0, which is wrong, as it prevents view removal when the window closes (implicit views don't get removed).This PR preserves existing behavior where the legacy single view
FlutterViewControllerwill have an implicit view.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.