Repository navigation
Remove deprecated useInheritedMediaQuery - #193146
AbdeMohlbi wants to merge 2 commits into
Conversation
github-actions
Bot
added
the
framework
|
This pull request contains changes to Material or Cupertino, which are currently frozen in this repository. Changes should be made in Please refer to #188444 for instructions. |
github-actions
Bot
added
p: material_ui
i am aware see flutter/packages#12969, if the changes were not also made in the framework users will still use |
AbdeMohlbi
changed the title
useInheritedMediaQueryuseInheritedMediaQuery
…ion guide (#13916) This change adds `useInheritedMediaQuery` removal breaking change entry and migration guide. unblocks : - flutter/packages#12970 - flutter/packages#12969 - flutter/flutter#193146 _PRs or commits this PR depends on (if any):_ ## Presubmit checklist - [x] If you are unwilling, or unable, to sign the CLA, even for a _tiny_, one-word PR, please file an issue instead of a PR. - [x] If this PR is not meant to land until a future stable release, mark it as draft with an explanation. - [x] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style)—for example, it doesn't use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first-person pronouns). - [x] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer. --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the deprecated 'useInheritedMediaQuery' parameter and field from 'CupertinoApp', 'MaterialApp', and 'WidgetsApp', as well as its associated tests and usages across the test suite. There are no review comments, and I have no feedback to provide.
|
From triage: I think we should not remove the deprecated properties from |
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
seems the plans have changed... , thanks @dkwingsmt for you efforts. |
blocked on:
useInheritedMediaQuerypackages#12969useInheritedMediaQueryflag inCupertinoApppackages#12970useInheritedMediaQueryremoval breaking change entry and migration guide website#13916Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.