Repository navigation
[flutter_tools] Wait for iOS simulator log stream before launch #193142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
auto-submit
merged 8 commits into
flutter:master
from
koji-1009:fix/ios_log_reader_start_race
Oct 15, 2026
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
eace7b1
[flutter_tools] Wait for iOS simulator log stream before launch
koji-1009 310b0f7
Change error message
koji-1009 d47eef6
Return a failed launch when the log stream does not start
koji-1009 2656461
Reset the log stream readiness on every listen
koji-1009 249fe15
Merge branch 'master' into fix/ios_log_reader_start_race
okorohelijah 7223286
Fix comment
koji-1009 6d3d865
Warn instead of failing when the log stream is slow to start
koji-1009 da96280
Merge branch 'master' into fix/ios_log_reader_start_race
vashworth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Reset the log stream readiness on every listen
- Loading branch information
commit 2656461a7f9f6810bceb8ebd93dd44404df138b4
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see where events are being dropped?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied, since the reason for waiting is already in the comment in
startApp. 7223286By "dropped" I meant that
log streamdoesn't deliver events logged before it prints that line, so in #181771 the Dart VM Service URL was never seen by the tool.