Skip to content

Add xvfb: "1" to Linux flavors test - #193122

Merged
auto-submit[bot] merged 1 commit into
masterfrom
linux_flav
Sep 21, 2026
Merged

auto-submit[bot] merged 1 commit into
masterfrom
linux_flav

Conversation

@jtmcdole

@jtmcdole jtmcdole commented Sep 21, 2026 •

Copy link
Copy Markdown
Member

Staging test passes:

led get-builder 'luci.flutter.staging:Linux flavors_test_linux' | led edit -pa git_ref='refs/pull/193122/head' | led edit -pa git_url='https://github.com/flutter/flutter' | led edit -p xvfb='"1"' | led launch

fixes #192651

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Sep 21, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the .ci.yaml configuration file by adding the 'xvfb: "1"' property to a target. There are no review comments, and I have no feedback to provide.

@jtmcdole

Copy link
Copy Markdown
Member Author

Launching test:

led get-builder 'luci.flutter.staging:Linux flavors_test_linux' | led edit -pa git_ref='refs/pull/193122/head' | led edit -pa git_url='https://github.com/flutter/flutter' | led edit -p xvfb='"1"' | led launch

@jtmcdole
jtmcdole requested a review from gaaclarke September 21, 2026 21:18

@gaaclarke gaaclarke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jtmcdole jtmcdole added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 21, 2026
@auto-submit
auto-submit Bot added this pull request to the merge queue Sep 21, 2026
Merged via the queue into master with commit 9cb45e8 Sep 21, 2026
34 checks passed
@auto-submit
auto-submit Bot deleted the linux_flav branch September 21, 2026 22:51
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 21, 2026
pull Bot pushed a commit to Mu-L/flutter that referenced this pull request Sep 22, 2026
Test is passing after flutter#193122 landed.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant in-code documentation (doc comments with
`///`).
- [ ] If this PR introduces a new feature or capability, I created and
linked a website documentation issue or PR in [flutter/website] (or
verified none is needed).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Linux flavors_test_linux failing

2 participants