Repository navigation
Remove webDevFS tests for the AMD module system - #193028
Merged
Merged
Conversation
AMD modules are no longer supported by flutter tools, DDC library bundles are now the only supported option. devfs_web_test.dart and devfs_web_ddc_modules.dart were initially copies of each other to cover all the same test cases with the two module formats. Over time they drifted apart. This change was created by: 1) Copying the contents of dev_web_ddc_modules_test.dart into devfs_web_test.dart. 2) Reverting the diffs that deleted test cases. 3) Applying similar style changes and refactors that had previously been only applied in devfs_web_ddc_modules.dart in the reverted diff sections. 4) Migrating the reverted diff sections use to DDC library bundles. This should ensure the remaining file contains the combination of all test cases that appeared in the diverging files.
github-actions
Bot
added
the
tool
nshahan
marked this pull request as ready for review
September 18, 2026 22:49
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
|
The files-changed count looks large ( Please confirm:
Not blocking on line count alone — just want confirmation the merged suite is the union of the old cases, not an accidental subset. |
bkonyi
approved these changes
Sep 21, 2026
nshahan
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
This was referenced Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AMD modules are no longer supported by flutter tools, DDC library bundles are now the only supported option.
The Github UI is not showing this diff well. Locally in VSCode it is easier to see only the changes and ignore the whitespace diffs.
devfs_web_test.dart and devfs_web_ddc_modules.dart were initially copies of each other to cover all the same test cases with the two module formats. Over time they drifted apart.
This change was created by:
devfs_web_test.dart.
only applied in devfs_web_ddc_modules_test.dart in the reverted diff sections.
This ensures the remaining file contains the combination of all test cases that appeared in the diverging files.
Issue: #142060
Pre-launch Checklist
///).