Repository navigation
Add platform_views_layout to build_tests so iOS/Android build breaks are caught in presubmit - #192985
Merged
auto-submit[bot] merged 2 commits intoNov 5, 2026
Conversation
…are caught in presubmit dev/benchmarks/platform_views_layout is only ever built by post-submit devicelab benchmarks (platform_views_scroll_perf_* on Mac_ios and Linux_pixel_7pro/Linux_mokey). It is the only app in the repo that depends on the google_mobile_ads plugin, so a change that breaks native plugin integration for that app is invisible to presubmit. That is exactly what happened with flutter#185431 (Xcode 26.2 / iOS 26 CI upgrade): the GoogleMobileAds xcframework failed to link (missing Swift compatibility and libc++ symbols) only in the post-submit Mac_ios platform_views_scroll_perf_* devicelab tasks (flutter#185510), and the PR had to be reverted (flutter#185513). Building this app in the build_tests shard would have surfaced the failure on the presubmit Mac_arm64 build_tests_* builders. _runExampleProjectBuildTests only builds platforms whose project folder exists, so this adds: * Linux/Mac/Windows: flutter build apk --debug / --release * Mac only: flutter build ios --no-codesign --debug / --release No web/macos/linux/windows build is attempted (those folders do not exist). Subshards are index/total driven from the SUBSHARD environment variable, so no .ci.yaml change is required; the test count goes from 27 to 28 across 5 subshards. platform_views_layout_hybrid_composition is intentionally NOT added: it has no plugin dependencies, its iOS project is not built anywhere in CI today, and the risk that motivated this change is specific to google_mobile_ads. Fixes flutter#185538
okorohelijah
marked this pull request as ready for review
October 21, 2026 13:05
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Piinks
added
platform-android
vashworth
approved these changes
Oct 29, 2026
github-actions
Bot
removed
platform-android
vashworth
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
This was referenced Nov 5, 2026
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Nov 6, 2026
Roll Flutter from 3623d2d34543 to 09175cdeac89 (61 revisions) flutter/flutter@3623d2d...09175cd 2026-11-06 [email protected] Roll Skia from ae35b7b2221f to 793b8ac73d4b (3 revisions) (flutter/flutter#196091) 2026-11-06 [email protected] [web] Rasterize scenes at the size passed to `FlutterView.render` (flutter/flutter#196052) 2026-11-06 [email protected] Roll Skia from 4aa043a81e0c to ae35b7b2221f (1 revision) (flutter/flutter#196086) 2026-11-06 [email protected] Roll Fuchsia Linux SDK from Fqe3UlLwAohsPbsCS... to KIc0XZbhLmvDpTluZ... (flutter/flutter#196085) 2026-11-06 [email protected] Allow a zero scale change in InteractiveViewer (flutter/flutter#194949) 2026-11-06 [email protected] Roll Skia from dd5c2553a856 to 4aa043a81e0c (2 revisions) (flutter/flutter#196079) 2026-11-06 [email protected] [web] Keep ImageFilter.blur bounds in equality and description (flutter/flutter#196013) 2026-11-06 [email protected] iOS: Remove unused PlatformViewIOS setup from FlutterPlatformViewsTest (flutter/flutter#196033) 2026-11-06 [email protected] Serialize LoggerTests that mutate the shared Logger (flutter/flutter#196028) 2026-11-06 [email protected] Use reverseDuration for the AnimatedCrossFade size animation (flutter/flutter#194860) 2026-11-05 [email protected] Roll Skia from a5aacd103e68 to dd5c2553a856 (8 revisions) (flutter/flutter#196073) 2026-11-05 [email protected] Fix ListWheelScrollView null check error when it reads itemIndex before content dimensions are set (flutter/flutter#194859) 2026-11-05 [email protected] Allow zero cross axis extent in SliverGridDelegateWithMaxCrossAxisExtent (flutter/flutter#194858) 2026-11-05 [email protected] Revert: Allow color delta tolerance in in-memory fuzzy image comparator (flutter/flutter#196067) 2026-11-05 [email protected] Revert: Mitigate snapshot race in 3D transform test by reducing loop density (flutter/flutter#196066) 2026-11-05 [email protected] Delegate createStream in ResizeImage and ScrollAwareImageProvider (flutter/flutter#194756) 2026-11-05 [email protected] [iOS] Introduce FlutterShell and move thread host and profiler (flutter/flutter#195388) 2026-11-05 [email protected] [web] Support FragmentShader.getImageSampler on CanvasKit and Skwasm (flutter/flutter#195854) 2026-11-05 [email protected] Deprecates setFloat API (flutter/flutter#195505) 2026-11-05 [email protected] [flutter_tools] Remove public GlobalToolContext and globals from runner (flutter/flutter#195561) 2026-11-05 [email protected] Defer TLHC PlatformViewWrapper frame post and avoid initial 1x1 buffer resize (flutter/flutter#195861) 2026-11-05 [email protected] Roll Skia from b5abed66da86 to a5aacd103e68 (17 revisions) (flutter/flutter#196054) 2026-11-05 [email protected] Made `FlutterWindowControllerSizeTest.SizedToContentNotResizable` more robust (flutter/flutter#195845) 2026-11-05 [email protected] Update docs for contributor ladder (flutter/flutter#196011) 2026-11-05 [email protected] [Impeller] Use the transfer stage for the Vulkan readback barrier (flutter/flutter#194991) 2026-11-05 [email protected] Remove Mac mac_unopt builder (flutter/flutter#196027) 2026-11-05 [email protected] Updated Instructions for Determining Gradle Version for `gradle_dists` in CIPD (flutter/flutter#193310) 2026-11-05 [email protected] Move ios_app_with_extensions_test into the tool integration shard (flutter/flutter#195609) 2026-11-05 [email protected] [web] Respect Uint8List view bounds when detecting animated WebP/GIF (flutter/flutter#196010) 2026-11-05 [email protected] Add platform_views_layout to build_tests so iOS/Android build breaks are caught in presubmit (flutter/flutter#192985) 2026-11-05 [email protected] [flutter_tools] Detect macOS TCC permission crashes and provide diagnostic guidance (flutter/flutter#192432) 2026-11-05 [email protected] Roll Packages from 670b30e to 0478162 (15 revisions) (flutter/flutter#196047) 2026-11-05 [email protected] [web] Support Skwasm rendering without bitmap capture (flutter/flutter#195103) 2026-11-05 [email protected] [flutter_tools] Reland fix for local CanvasKit asset paths on Windows (flutter/flutter#195770) 2026-11-05 [email protected] Roll Skia from f96be51af95d to b5abed66da86 (14 revisions) (flutter/flutter#196017) 2026-11-05 [email protected] Split chrome web engine test drone (flutter/flutter#195873) 2026-11-05 [email protected] Roll Dart SDK from c9153304136a to 6623b84628f3 (1 revision) (flutter/flutter#196026) 2026-11-05 [email protected] Roll ICU from 4fe960221710 to a0ea93436c52 (6 revisions) (flutter/flutter#196025) 2026-11-05 [email protected] Add more guidance in README and AGENTS for contributing to flutter_tools (flutter/flutter#195998) 2026-11-05 [email protected] Roll Fuchsia Linux SDK from p0HDXLISPIElJfSz7... to Fqe3UlLwAohsPbsCS... (flutter/flutter#196019) 2026-11-05 [email protected] Roll Dart SDK from e362a23e9738 to c9153304136a (18 revisions) (flutter/flutter#196014) 2026-11-05 [email protected] [Impeller] Fix dilation input bounds when clipping saveLayers (flutter/flutter#195652) 2026-11-05 [email protected] Add `variantOf` to the M3E migration checklist (flutter/flutter#195099) 2026-11-05 [email protected] [flutter_tools] Eliminate globals from remaining subsystem files (flutter/flutter#195555) 2026-11-05 [email protected] Fix gap flipping when dragging variable height reorderable items (flutter/flutter#194478) 2026-11-05 [email protected] [A11y] Send un-merged SemanticsNodes in the same update that first references them (flutter/flutter#195829) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dev/benchmarks/platform_views_layoutis only ever built by post-submit devicelab benchmarks (Mac_ios platform_views_scroll_perf_*andLinux_pixel_7pro/Linux_mokey platform_views_scroll_perf*). It is also the only app in the repo that depends on thegoogle_mobile_adsplugin, so a change that breaks native plugin integration for that app is invisible to presubmit.That is exactly what happened with #185431 (Xcode 26.2 / iOS 26 CI upgrade): the
GoogleMobileAdsxcframework failed to link (missing__swift_FORCE_LOAD_$_swiftCompatibility*and libc++ symbols) only in the post-submitMac_ios platform_views_scroll_perf_*devicelab tasks (#185510), and the PR had to be reverted (#185513) before being fixed by enabling SwiftPM for the plugin (#185548). Building this app in thebuild_testsshard would have surfaced the failure on the presubmitMac_arm64 build_tests_*builders instead.This PR adds the directory to
exampleDirectoriesin_runBuildTests(dev/bots/test.dart)._runExampleProjectBuildTestsonly builds platforms whose project folder exists, so concretely this adds:build_tests_*flutter build apk --debug -v,flutter build apk --release -vbuild_tests_*onlyflutter build ios --no-codesign --debug -v,flutter build ios --no-codesign --release -vNo web / macOS / Linux / Windows desktop build is attempted (the app has no such folders, and the shard prints e.g.
has no linux directory, skipping Linux— verified with--dry-run).Sub-sharding is
{index}_{total}driven by theSUBSHARDenv var and the test list is shuffled with a fixed seed, so no.ci.yamlchange is needed. Thebuild_teststest count goes from 27 → 28 across 5 subshards (Linux/Mac) and 9 (Windows); the new entry lands in4_5on Linux with the current seed.With the help of Gemini
Fixes #185538
Pre-launch Checklist
///). (N/A — added an inline//comment explaining why the entry exists; no public API touched.)dev/bots/test.dart; the change is exercised directly by theLinux/Mac/Windows build_tests_*presubmit builders on this very PR.)